m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1935526035
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -4165,14 +4165,6 @@ class ReplicaManagerTest {
val response = replicaManager.becomeLeaderOrFollower(0,
leaderAndIsrRequest(0), (_, _) => ())
assertEquals(Errors.NONE,
response.partitionErrors(topicNames).get(topicPartition))
assertFalse(replicaManager.localLog(topicPartition).isEmpty)
- val id = topicIds.get(topicPartition.topic())
Review Comment:
> Looking at this again, does this test actually make sense to keep? It's
supposed to test the metadata file get created but we've now removed these
assertions.
If we're removing the created file assertion, we should also remove this
test. This make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
