Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan merged PR #17698: URL: https://github.com/apache/kafka/pull/17698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1872303946 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -463,31 +463,118 @@ class TransactionCoordinatorTest { v

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1872299439 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -463,31 +463,118 @@ class TransactionCoordinatorTest { verify(tr

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1872269359 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -524,15 +754,16 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1872247769 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -524,15 +754,16 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1872243055 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -724,8 +977,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1871984412 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -724,8 +977,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1871964862 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -724,8 +977,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1871905289 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -724,8 +977,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1870427097 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -524,15 +757,16 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1870423392 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -723,9 +980,8 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1870423392 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -723,9 +980,8 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1870422061 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -506,6 +507,238 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1870211891 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -524,15 +757,16 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1868276616 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1866825893 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1866762808 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1866756895 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1861250626 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859947357 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859632802 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859536529 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859537198 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859530416 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -505,20 +579,68 @@ class TransactionCoordinatorTest { ve

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859529641 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3036,12 +3178,10 @@ public void testEpochUpdateAfterBu

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859417510 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859415059 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859415059 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +627,44 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859401198 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -505,20 +579,68 @@ class TransactionCoordinatorTest { verify(tra

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859375050 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3036,12 +3178,10 @@ public void testEpochUpdateAfterBumpFromEn

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859379951 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -125,7 +126,8 @@ public void testBuildWithCurrentMessageFormat() {

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859362179 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2()

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859352623 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -172,7 +172,11 @@ private void initializeTransactionManager(Opti

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859110614 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1672,6 +1682,11 @@ private TxnOffsetCommitHandler(TransactionalReq

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1857554819 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -477,23 +484,27 @@ private[transaction] class TransactionMetadata(val trans

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1857460756 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -592,7 +586,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1857425707 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -592,7 +586,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1857417829 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -592,7 +586,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1857410244 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -333,16 +333,17 @@ private[transaction] class TransactionMetadata(val transaction

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on PR #17698: URL: https://github.com/apache/kafka/pull/17698#issuecomment-2495138629 Green build https://github.com/apache/kafka/actions/runs/11979198275/job/33405415151 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854833179 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854240231 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +633,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854625036 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,39 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854625036 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,39 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854568831 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854568831 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854568831 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854559934 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +633,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854265949 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1854240231 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,41 +633,44 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1853036403 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConf

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848891260 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2()

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851126514 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849325108 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val transactiona

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851078539 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851070563 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { producer1.begin

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851079348 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851079348 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851068727 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1672,6 +1682,11 @@ private TxnOffsetCommitHandler(TransactionalReq

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851077207 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851077207 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -498,6 +498,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1851067966 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -85,7 +105,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRate = me

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1850910941 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val tran

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on PR #17698: URL: https://github.com/apache/kafka/pull/17698#issuecomment-2489304850 @artemlivshits @jolshan I added a table for the state transition. Can you help double check if it is what we expected? -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1850772981 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1850687296 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { producer1.begin

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849322960 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -629,10 +629,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Return true if t

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849337372 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -411,7 +421,7 @@ RuntimeException lastError() { synchro

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848875185 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -476,7 +476,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849411061 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849324300 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849340745 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -225,7 +245,7 @@ class AddPartitionsToTxnManager( val code =

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849325623 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { producer1.begin

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849318159 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val tran

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848949645 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1672,6 +1682,11 @@ private TxnOffsetCommitHandler(Transact

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848978343 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,33 +592,10 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848891260 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2()

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848952661 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -476,7 +476,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848884604 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { producer1.begin

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848881103 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -794,6 +814,8 @@ class TransactionsTest extends IntegrationTestHarness { val producerI

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848880463 ## core/src/test/java/kafka/admin/AdminFenceProducersTest.java: ## @@ -97,9 +97,11 @@ void testFenceAfterProducerCommit() throws Exception { Execut

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848881103 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -794,6 +814,8 @@ class TransactionsTest extends IntegrationTestHarness { val producerI

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848876562 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -629,10 +629,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Return true if the given

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847462022 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -411,7 +421,7 @@ RuntimeException lastError() { synchroni

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848874334 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1672,6 +1682,11 @@ private TxnOffsetCommitHandler(TransactionalReq

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847485787 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,33 +592,10 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847395234 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val transactiona

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847491788 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -610,7 +615,18 @@ class TransactionCoordinator(txnConfig: TransactionCo

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847491440 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val tran

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847483622 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1672,6 +1682,11 @@ private TxnOffsetCommitHandler(Transact

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847494440 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847487125 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -586,15 +589,20 @@ class TransactionsTest extends IntegrationTestHarness { pro

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847482941 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -476,7 +476,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847491440 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val tran

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847482941 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -476,7 +476,7 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847489952 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -394,8 +402,10 @@ public synchronized void maybeAddPartition

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847487700 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -794,6 +814,8 @@ class TransactionsTest extends IntegrationTestHarness { val p

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847485787 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -564,33 +592,10 @@ class TransactionCoordinator(txnConfig: TransactionC

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847480170 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -629,10 +629,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Return true if t

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847474172 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -922,6 +946,103 @@ public void testTransactionManagerEna

  1   2   >