artemlivshits commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1859632802
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
producerEpochCopy = txnMetadata.producerEpoch
// PrepareEpochFence has slightly different epoch bumping logic so
don't include it here.
val currentTxnMetadataIsAtLeastTransactionsV2 =
!txnMetadata.pendingState.contains(PrepareEpochFence) &&
txnMetadata.clientTransactionVersion.supportsEpochBump()
+ val incomingEndTxnIsAtLeastTransactionsV2 =
!txnMetadata.pendingState.contains(PrepareEpochFence) &&
clientTransactionVersion.supportsEpochBump()
Review Comment:
Do we need 2 checks? Can we just check the incoming client version (which
we always know here) and use it in all conditions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
