jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1859110614
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1672,6 +1682,11 @@ private
TxnOffsetCommitHandler(TransactionalRequestResult result,
this.builder = builder;
}
+ private TxnOffsetCommitHandler(TxnOffsetCommitRequest.Builder builder)
{
+ super("TxnOffsetCommitHandler");
+ this.builder = builder;
Review Comment:
Taking a look, it seems like we pass a result if it exists, otherwise the
string param creates a new result with that string name. Seems like this should
be ok 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
