jolshan merged PR #15837:
URL: https://github.com/apache/kafka/pull/15837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1594302492
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarke
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1594302111
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3036,15 +3061,32 @@ class KafkaApisTest extends Logging {
assertEquals(expectedErrors, markers
sidyag commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1593693523
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging {
}
@Test
- def shouldAppendToLogOn
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1593105981
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging {
}
@Test
- def shouldAppendToLogO
jolshan commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2098727340
Sorry I was out of town (at KSB). I will try to take a look today, but
thanks Luke for approving as well :)
--
This is an automated message from the Apache Git Service.
To respond to t
sidyag commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1592106849
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarker
sidyag commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1592106849
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarker
showuon commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1591749069
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarke
sidyag commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088272313
> The only comment is that we should update 1) the documentation in
docs/security.html#operations_resources_and_protocols to mention this change 2)
the release notes of 3.8 once they are c
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088221738
I looked over the failures in the build, but the test failures appear to be
unrelated to this change
--
This is an automated message from the Apache Git Service.
To respond to the messag
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088220856
Heya @jolshan since you cast a vote on the KIP would you have some time to
review this pull request as well?
--
This is an automated message from the Apache Git Service.
To respond to th
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088220267
The only comment is that we should update 1) the documentation in
docs/security.html#operations_resources_and_protocols to mention this change 2)
the release notes of 3.8 once they are cre
sidyag opened a new pull request, #15837:
URL: https://github.com/apache/kafka/pull/15837
Allowing WriteTxnMarkers API to run with AlterCluster permissions
https://issues.apache.org/jira/browse/KAFKA-16513
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1037%3A+Allow+Writ
14 matches
Mail list logo
