sidyag commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1592106849
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2822,6 +2822,31 @@ class KafkaApisTest extends Logging {
() => kafkaApis.handleWriteTxnMarkersRequest(null,
RequestLocal.withThreadConfinedCaching))
}
+ @Test
+ def requiredAclsNotPresentWriteTxnMarkersThrowsAuthorizationException():
Unit = {
Review Comment:
That is the happy case path verified by existing tests. As mocks are not
present there, by default the CLUSTER_ACTION check doesn't throw an exception,
and the ALTER check returns false.
I can modify the existing tests to make that explicit and duplicate it to
test for the second scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
