Re: [PR] KAFKA-18941: Do not test 3.3 in upgrade_tests.py [kafka]

2025-03-10 Thread via GitHub
TaiJuWu commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2712790669 Hi @josefk31 , thanks for this patch. I ran following command without this patch, it pass on local and I can't reproduce this issue. Could you help to check or share your step ?

Re: [PR] KAFKA-18954: Add ELR election rate metric [kafka]

2025-03-10 Thread via GitHub
cmccabe commented on PR #19180: URL: https://github.com/apache/kafka/pull/19180#issuecomment-2711730859 Wouldn't "ElectionFromElr" be more descriptive? Also can you update KIP-966 with this metric if it's not already there (and email and ADDENDUM if needed...) -- This is an automat

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-10 Thread via GitHub
mjsax commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2712712475 Second system test run. This time 48 tests failed. Did not look into details if it's the same of different tests http://ducktape-open-source-results.confluent.io.s3-website-us-west-2

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-10 Thread via GitHub
mjsax commented on PR #18091: URL: https://github.com/apache/kafka/pull/18091#issuecomment-2712706203 Seems the PR need to be rebased to resolve merge conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-10 Thread via GitHub
jsancio commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1987805617 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java: ## @@ -52,13 +53,17 @@ import java.util.concurrent.atomic.AtomicLong; import java.util.s

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-03-10 Thread via GitHub
junrao commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1987826859 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -333,7 +336,9 @@ abstract class AbstractFetcherThread(name: String, // In this case,

[jira] [Updated] (KAFKA-18958) Kafka services are unstable in 3 node cluster

2025-03-10 Thread Sravani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sravani updated KAFKA-18958: Affects Version/s: 3.9.0 > Kafka services are unstable in 3 node cluster > ---

[jira] [Created] (KAFKA-18958) Kafka services are unstable in 3 node cluster

2025-03-10 Thread Sravani (Jira)
Sravani created KAFKA-18958: --- Summary: Kafka services are unstable in 3 node cluster Key: KAFKA-18958 URL: https://issues.apache.org/jira/browse/KAFKA-18958 Project: Kafka Issue Type: Bug

Re: [PR] MINOR Mark Tls13SelectorTest#testCloseOldestConnection as flaky [kafka]

2025-03-10 Thread via GitHub
mumrah commented on PR #19178: URL: https://github.com/apache/kafka/pull/19178#issuecomment-2712309853 https://develocity.apache.org/scans/tests?search.names=Git%20Repository&search.rootProjectNames=kafka&search.tags=github%2Ctrunk%2Cnot:new%2Cnot:flaky&search.tasks=test&search.timeZoneId=Am

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-10 Thread via GitHub
artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1987985812 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader

Re: [PR] MINOR: Removed unused local variable in method DefaultStateUpdater.drainRestoredActiveTasks [kafka]

2025-03-10 Thread via GitHub
mjsax commented on PR #18385: URL: https://github.com/apache/kafka/pull/18385#issuecomment-2712590100 This PR was subsumed by https://github.com/apache/kafka/pull/18963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MINOR: Removed unused local variable in method DefaultStateUpdater.drainRestoredActiveTasks [kafka]

2025-03-10 Thread via GitHub
mjsax closed pull request #18385: MINOR: Removed unused local variable in method DefaultStateUpdater.drainRestoredActiveTasks URL: https://github.com/apache/kafka/pull/18385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18167 - Disable TLS session ticket extension [kafka]

2025-03-10 Thread via GitHub
github-actions[bot] commented on PR #18070: URL: https://github.com/apache/kafka/pull/18070#issuecomment-2712495002 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2025-03-10 Thread via GitHub
github-actions[bot] commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-2712494730 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates [kafka]

2025-03-10 Thread via GitHub
github-actions[bot] commented on PR #15647: URL: https://github.com/apache/kafka/pull/15647#issuecomment-2712494749 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18600 Cleanup NetworkClient zk related logging [kafka]

2025-03-10 Thread via GitHub
m1a2st commented on PR #18644: URL: https://github.com/apache/kafka/pull/18644#issuecomment-2712467801 Hello @mumrah, If there are no further changes needed for this PR, perhaps it can be merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-10 Thread via GitHub
github-actions[bot] commented on PR #18463: URL: https://github.com/apache/kafka/pull/18463#issuecomment-2712458553 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] MINOR:Add documentation to describe default quotas for user and client-id. [kafka]

2025-03-10 Thread via GitHub
Rancho-7 opened a new pull request, #19184: URL: https://github.com/apache/kafka/pull/19184 Add documentation to describe default quotas for user and client-id, which were previously missing. https://github.com/user-attachments/assets/05fb9759-ea46-4211-9185-875e004c4527"; />

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1988295503 ## committer-tools/reviewers.py: ## @@ -35,6 +39,41 @@ def prompt_for_user(): return clean_input +def update_trailers(body, trailer): +with temp

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1988296755 ## committer-tools/reviewers.py: ## @@ -87,9 +126,11 @@ def prompt_for_user(): continue if selected_reviewers: -out = "\n\nReviewers: " -

[PR] KAFKA-18819 StreamsGroupHeartbeat API and StreamsGroupDescribe API check topic describe [kafka]

2025-03-10 Thread via GitHub
DL1231 opened a new pull request, #19183: URL: https://github.com/apache/kafka/pull/19183 This patch filters out the topic describe unauthorized topics from the StreamsGroupHeartbeat and StreamsGroupDescribe response. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18941: Do not test 3.3 in upgrade_tests.py [kafka]

2025-03-10 Thread via GitHub
ijuma commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2712314111 Hmm, our documentation says that upgades from 3.3 are supported. So, I'm surprised we removed the test for that version. -- This is an automated message from the Apache Git Service. To re

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mumrah commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1988246558 ## committer-tools/reviewers.py: ## @@ -35,6 +39,41 @@ def prompt_for_user(): return clean_input +def update_trailers(body, trailer): +with tempfile

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-10 Thread via GitHub
showuon commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1988244400 ## docs/upgrade.html: ## @@ -61,10 +67,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/x/K5sODg";>KIP-896 for the details.

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1987552051 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -234,67 +257,93 @@ private GroupAssignment newAssignm

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-10 Thread via GitHub
mumrah commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1987411712 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -234,67 +257,93 @@ private GroupAssignment newAssignmentHeterog

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-10 Thread via GitHub
artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1988203221 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] KAFKA-18943: Kafka Streams incorrectly commits TX during task revokation [kafka]

2025-03-10 Thread via GitHub
ableegoldman commented on code in PR #19164: URL: https://github.com/apache/kafka/pull/19164#discussion_r1988199982 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1153,8 +1157,7 @@ void handleRevocation(final Collection revokedPar

[PR] KAFKA-18954: Add ELR election rate metric [kafka]

2025-03-10 Thread via GitHub
CalvinConfluent opened a new pull request, #19180: URL: https://github.com/apache/kafka/pull/19180 Add a metric to track the number of election is done using ELR. https://issues.apache.org/jira/browse/KAFKA-18954 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-18941: Do not test 3.3 in upgrade_tests.py [kafka]

2025-03-10 Thread via GitHub
cmccabe merged PR #19162: URL: https://github.com/apache/kafka/pull/19162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-13281) Support live upgrades with dynamic addition/removal of modular topologies

2025-03-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-13281. Resolution: Won't Do > Support live upgrades with dynamic addition/removal

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-10 Thread via GitHub
junrao commented on PR #19030: URL: https://github.com/apache/kafka/pull/19030#issuecomment-2711372677 Also, could you run some more perf tests like kafka-producer-perf-test.sh and kafka-consumer-perf-test.sh to make sure there is no regression? -- This is an automated message from the Ap

Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19145: URL: https://github.com/apache/kafka/pull/19145#discussion_r1988160218 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java: ## @@ -84,10 +84,6 @@ public boolean fetchOnlyLeader() { return isF

[jira] [Assigned] (KAFKA-18956) Enable junit tests to optionally use more than one KRaft controller

2025-03-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18956: --- Assignee: TengYao Chi > Enable junit tests to optionally use more than one KRaft controller

Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-10 Thread via GitHub
junrao commented on code in PR #19145: URL: https://github.com/apache/kafka/pull/19145#discussion_r1988106743 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java: ## @@ -84,10 +84,6 @@ public boolean fetchOnlyLeader() { return isFromFollo

Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19145: URL: https://github.com/apache/kafka/pull/19145#discussion_r1988106898 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java: ## @@ -85,7 +85,7 @@ public boolean fetchOnlyLeader() { } public

Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on PR #19145: URL: https://github.com/apache/kafka/pull/19145#issuecomment-2711987843 > @apoorvmittal10 : Thanks for the PR. Left a comment. Thanks for the review @junrao. I have addressed the comment. -- This is an automated message from the Apache Git Serv

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-10 Thread via GitHub
soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1988106394 ## clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java: ## @@ -1923,9 +1922,9 @@ private void checkRequest(AbstractRequest req) {

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-10 Thread via GitHub
cadonna commented on PR #19181: URL: https://github.com/apache/kafka/pull/19181#issuecomment-2711972843 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-10 Thread via GitHub
cadonna opened a new pull request, #19181: URL: https://github.com/apache/kafka/pull/19181 The Streams heartbeat request has some fields that are always sent. Those are: - group ID - member ID - member epoch - group instance ID (if static membership is used) Then it has fi

[jira] [Commented] (KAFKA-18957) Impossible to recover hanging transactions in Kafka 3.9 in KRaft mode using EOS

2025-03-10 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934039#comment-17934039 ] Justine Olshan commented on KAFKA-18957: As an aside, the EndTransaction request

[jira] [Commented] (KAFKA-18957) Impossible to recover hanging transactions in Kafka 3.9 in KRaft mode using EOS

2025-03-10 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934038#comment-17934038 ] Justine Olshan commented on KAFKA-18957: Hey there, thanks for reporting.  This

Re: [PR] KAFKA-18858: Refactor FeatureControlManager to avoid using uninitialized MV [kafka]

2025-03-10 Thread via GitHub
FrankYang0529 commented on PR #19040: URL: https://github.com/apache/kafka/pull/19040#issuecomment-2711062357 @chia7712 Fixed conflict. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-03-10 Thread via GitHub
mimaison commented on PR #19064: URL: https://github.com/apache/kafka/pull/19064#issuecomment-2711907902 Converted to draft as per https://lists.apache.org/thread/hwrrztts7j8jwwkk740848hd6y8p2c0x Giving the community a few days to review the proposed changes. If no objections are rai

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-10 Thread via GitHub
mimaison commented on PR #19030: URL: https://github.com/apache/kafka/pull/19030#issuecomment-2711890242 > Also, could you run some more perf tests like kafka-producer-perf-test.sh and kafka-consumer-perf-test.sh to make sure there is no regression? Yes once we're happy with the rewri

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-10 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1988055534 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2302 @@ public class UnifiedLog { public static final String STR

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1987798872 ## committer-tools/reviewers.py: ## @@ -35,6 +37,30 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): +

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on PR #19168: URL: https://github.com/apache/kafka/pull/19168#issuecomment-2711466211 @mumrah Thanks for reviewing. Make modifications based on the comments. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Updates to status and metrics) [kafka]

2025-03-10 Thread via GitHub
gharris1727 commented on code in PR #17988: URL: https://github.com/apache/kafka/pull/17988#discussion_r1987931269 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -562,6 +562,20 @@ public boolean isRunning(String connName) { return w

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-10 Thread via GitHub
mimaison commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1988007335 ## raft/src/test/java/org/apache/kafka/raft/QuorumConfigTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] KAFKA-18942: Add reviewers to PR body with committer-tools [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on code in PR #19168: URL: https://github.com/apache/kafka/pull/19168#discussion_r1987597807 ## committer-tools/reviewers.py: ## @@ -35,6 +37,30 @@ def prompt_for_user(): return clean_input +def append_message_to_pr_body(pr_url, message): R

Re: [PR] KAFKA-18310: Flaky AbstractCoordinatorTest [kafka]

2025-03-10 Thread via GitHub
lianetm closed pull request #18665: KAFKA-18310: Flaky AbstractCoordinatorTest URL: https://github.com/apache/kafka/pull/18665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987326364 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987328707 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1348,6 +1381,34 @@ private void throwIfEmptyString( }

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-10 Thread via GitHub
m1a2st commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1987352108 ## docs/upgrade.html: ## @@ -61,10 +67,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/x/K5sODg";>KIP-896 for the details.

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1987317310 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3918,10 +3918,8 @@ class KafkaApisTest extends Logging { ) when(sharePartitionM

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on PR #19114: URL: https://github.com/apache/kafka/pull/19114#issuecomment-2710665901 @cadonna Thanks for the comments! Ready for re-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987326870 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,280 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18195: Enter incompatible instead of leaving incompatible entires blank in Kafka Streams broker compatibility matrix [kafka]

2025-03-10 Thread via GitHub
FrankYang0529 commented on code in PR #18258: URL: https://github.com/apache/kafka/pull/18258#discussion_r1987327665 ## docs/streams/upgrade-guide.html: ## @@ -1735,73 +1735,38 @@ Streams API broker compatibility -The following table shows which versions of the Ka

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987325758 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987320429 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987318593 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1480,6 +1600,34 @@ private boolean isSubset( return tr

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987320785 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TasksTuple.java: ## @@ -30,11 +34,11 @@ * An immutable tuple containing active, standby

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987319987 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,280 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-10 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1987319620 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,280 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1987317310 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3918,10 +3918,8 @@ class KafkaApisTest extends Logging { ) when(sharePartitionM

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1987157915 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -234,67 +257,93 @@ private GroupAssignment newAssignm

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1987145943 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,71 @@ private GroupAssignment newAssignm

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
AndrewJSchofield commented on PR #19148: URL: https://github.com/apache/kafka/pull/19148#issuecomment-2710312166 Please update `clients/src/main/resources/common/message/ShareFetchRequest.json` too to remove `PartitionMaxBytes`. -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1987113040 ## clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java: ## @@ -226,23 +189,18 @@ public int maxWait() { return data.maxWaitM

Re: [PR] KAFKA-18943: Kafka Streams incorrectly commits TX during task revokation [kafka]

2025-03-10 Thread via GitHub
cadonna commented on code in PR #19164: URL: https://github.com/apache/kafka/pull/19164#discussion_r1987079448 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1163,10 +1166,12 @@ void handleRevocation(final Collection revokedPartit

[PR] MINOR: Remove unused ConfigCommandOptions#forceOpt [kafka]

2025-03-10 Thread via GitHub
frankvicky opened a new pull request, #19170: URL: https://github.com/apache/kafka/pull/19170 This field is unused, and we should remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986980330 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -427,29 +426,20 @@ private CompletableFuture shareFetchData, +public ShareFetchCon

Re: [PR] KAFKA-18947: Remove unused raftManager in metadataShell [kafka]

2025-03-10 Thread via GitHub
frankvicky commented on code in PR #19169: URL: https://github.com/apache/kafka/pull/19169#discussion_r1986944093 ## shell/src/main/java/org/apache/kafka/shell/MetadataShell.java: ## @@ -82,7 +72,7 @@ public Builder setFaultHandler(FaultHandler faultHandler) { }

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-10 Thread via GitHub
TaiJuWu commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1986863784 ## raft/src/test/java/org/apache/kafka/raft/QuorumConfigTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] MINOR: Remove unused ConfigCommandOptions#forceOpt [kafka]

2025-03-10 Thread via GitHub
chia7712 commented on PR #19170: URL: https://github.com/apache/kafka/pull/19170#issuecomment-2709272673 @frankvicky Generally, we should avoid removing fields from tools, even if they are currently unused. However, I suspect this particular unused field has existed for an extended period.

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986913023 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -427,29 +426,20 @@ private CompletableFuture shareFetchData, +public ShareFetchCo

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-10 Thread via GitHub
TaiJuWu commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1986881728 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -102,12 +103,12 @@ public class QuorumConfig { public static final ConfigDef CONFIG_DEF = new

[PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-10 Thread via GitHub
mimaison opened a new pull request, #19175: URL: https://github.com/apache/kafka/pull/19175 Delete unused methods in CoreUtils and switch to Utils.newInstance() where possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-18837: Validate controller.quorum.fetch.timeout.ms is a positive value [kafka]

2025-03-10 Thread via GitHub
TaiJuWu commented on code in PR #18998: URL: https://github.com/apache/kafka/pull/18998#discussion_r1986881728 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -102,12 +103,12 @@ public class QuorumConfig { public static final ConfigDef CONFIG_DEF = new

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986881002 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -258,14 +257,14 @@ public CompletableFuture> fetchMessages( FetchParams fetch

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1986879277 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -427,29 +426,20 @@ private CompletableFuture shareFetchData, +public ShareFetchCon

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-10 Thread via GitHub
TaiJuWu commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2709813527 > @TaiJuWu thanks for your sharing. Do you know why consumer sends join-group and sync-group request before receiving response of FindCoordinatorRequestData? @chia7712 Thanks for y

Re: [PR] MINOR: fix: add missing @Test lost while rebasing [kafka]

2025-03-10 Thread via GitHub
jeqo commented on code in PR #19149: URL: https://github.com/apache/kafka/pull/19149#discussion_r1986822013 ## storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java: ## @@ -245,7 +246,7 @@ public void testDoNotCreateFileUntilNeeded() throws IOEx

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-03-10 Thread via GitHub
lucasbru merged PR #18963: URL: https://github.com/apache/kafka/pull/18963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-03-10 Thread via GitHub
mingyen066 commented on PR #19062: URL: https://github.com/apache/kafka/pull/19062#issuecomment-2709757157 @chia7712 I agree. If a class has mutable fields, we shouldn't migrate it to Java record because record assume all fields are immutable. -- This is an automated message from the Apac

[PR] KAFKA-18946: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module [kafka]

2025-03-10 Thread via GitHub
frankvicky opened a new pull request, #19174: URL: https://github.com/apache/kafka/pull/19174 JIRA: KAFKA-18946 This patch is to move `DynamicProducerStateManagerConfig` and `BrokerReconfigurable` to the server module. -- This is an automated message from the Apache Git Service

[jira] [Commented] (KAFKA-16700) Kafka Streams: possible message loss on KTable-KTable FK Left Join

2025-03-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933764#comment-17933764 ] Karsten Stöckmann commented on KAFKA-16700: --- [~mjsax] Awesome, thanks for the

Re: [PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-03-10 Thread via GitHub
ijuma commented on PR #19062: URL: https://github.com/apache/kafka/pull/19062#issuecomment-2709445938 For the classes without `hashCode`/`equals`, we are verifying that it's ok to change the implementation of `hashCode` and `equals`? -- This is an automated message from the Apache Git Ser

[jira] [Commented] (KAFKA-18696) Migrate suitable classes to records

2025-03-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933742#comment-17933742 ] Chia-Ping Tsai commented on KAFKA-18696: it would be great to ensure we change t

Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]

2025-03-10 Thread via GitHub
showuon commented on code in PR #19172: URL: https://github.com/apache/kafka/pull/19172#discussion_r1986734547 ## docs/upgrade.html: ## @@ -31,6 +31,12 @@ Notable changes in 4 Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +Note: Apache Kafka 4.0 only supp

[jira] [Comment Edited] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-10 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933727#comment-17933727 ] Rameshkanna N edited comment on KAFKA-18938 at 3/10/25 7:04 AM: --