jeqo commented on code in PR #19149:
URL: https://github.com/apache/kafka/pull/19149#discussion_r1986822013


##########
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##########
@@ -245,7 +246,7 @@ public void testDoNotCreateFileUntilNeeded() throws 
IOException {
     }
 
     @Test
-    void testAppendAndCollectAfterClose() throws IOException {
+    public void testAppendAndCollectAfterClose() throws IOException {

Review Comment:
   Thanks @chia7712! Agree. Was adding them just to keep it align with the 
other tests, but can remove for new ones, 👍🏽 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to