[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-08 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925343#comment-17925343 ] Nil Madhab commented on KAFKA-18713: [https://github.com/nilmadhab/kafka-examples/bl

[jira] [Assigned] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-08 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nil Madhab reassigned KAFKA-18713: -- Assignee: Nil Madhab > Kafka Streams Left-Join not always emitting the last value > -

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-08 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925342#comment-17925342 ] Nil Madhab commented on KAFKA-18713: If I don't create 10 partition, will the issue

Re: [PR] KAFKA-17828: Reverse Checkpointing in MM2 [kafka]

2025-02-08 Thread via GitHub
sgn2607 commented on PR #17593: URL: https://github.com/apache/kafka/pull/17593#issuecomment-2646085988 @urbandan I see the PR is marked stale, but the KIP is still in progress. Is it still active? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-08 Thread via GitHub
ijuma commented on PR #18783: URL: https://github.com/apache/kafka/pull/18783#issuecomment-2646059254 Yes, I think a benchmark for `TopicIdPartition` would be a good one since the original implementation is pretty simple and if the generated implementation has additional fixed overhead, tha

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-08 Thread via GitHub
frankvicky commented on PR #18783: URL: https://github.com/apache/kafka/pull/18783#issuecomment-2646051954 I see. I will prepare one 🙇🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-17688 Move TransactionsTest to storage module [kafka]

2025-02-08 Thread via GitHub
github-actions[bot] commented on PR #17732: URL: https://github.com/apache/kafka/pull/17732#issuecomment-2646050655 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-08 Thread via GitHub
chia7712 commented on PR #18783: URL: https://github.com/apache/kafka/pull/18783#issuecomment-2646048265 > you would want to write a benchmark and confirm @frankvicky Since we have many JIRA tickets related to rewriting code with record classes, it would be great to have a JMH benchma

Re: [PR] KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-02-08 Thread via GitHub
github-actions[bot] commented on PR #18489: URL: https://github.com/apache/kafka/pull/18489#issuecomment-2646045155 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18168: Adding checkpointing for GlobalKTable during restoration… [kafka]

2025-02-08 Thread via GitHub
github-actions[bot] commented on PR #18752: URL: https://github.com/apache/kafka/pull/18752#issuecomment-2646045130 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-18697) Migrate suitable classes to records in connect module

2025-02-08 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925333#comment-17925333 ] Ismael Juma commented on KAFKA-18697: - {quote}[~ijuma] Would you recommend applying

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-08 Thread via GitHub
ijuma commented on PR #18783: URL: https://github.com/apache/kafka/pull/18783#issuecomment-2646033413 @TaiJuWu I know about the spec, but the actual implementation details matter. So, you would want to write a benchmark and confirm - not simply rely on reading the specification. -- This

Re: [PR] KAFKA-16368: Update defaults for LOG_MESSAGE_TIMESTAMP_AFTER_MAX_MS_D… [kafka]

2025-02-08 Thread via GitHub
divijvaidya commented on PR #18106: URL: https://github.com/apache/kafka/pull/18106#issuecomment-2645938748 @mjsax I am sorry to hear that people had to spend multiple hours trying to fix this. I considered this change safe for KS without an expert review because: 1. the change maintained

[jira] [Created] (KAFKA-18761) kafka-share-groups.sh --describe only shows offset information when members exist

2025-02-08 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18761: Summary: kafka-share-groups.sh --describe only shows offset information when members exist Key: KAFKA-18761 URL: https://issues.apache.org/jira/browse/KAFKA-18761

Re: [PR] KAFKA-18728 Move ListOffsetsPartitionStatus to server module [kafka]

2025-02-08 Thread via GitHub
m1a2st commented on code in PR #18807: URL: https://github.com/apache/kafka/pull/18807#discussion_r1947929551 ## server/src/main/java/org/apache/kafka/server/ListOffsetsPartitionStatus.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-02-08 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2645884106 @apoorvmittal10, @Goooler and @poom-kitti: feel free to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-02-08 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2645879873 I just pushed another commit that solves issues described by @poom-kitti above. Herewith my environment and some test I performed :arrow_down: ## Environment: Java

Re: [PR] KAFKA-18728 Move ListOffsetsPartitionStatus to server module [kafka]

2025-02-08 Thread via GitHub
kamalcph commented on code in PR #18807: URL: https://github.com/apache/kafka/pull/18807#discussion_r1947891621 ## server/src/main/java/org/apache/kafka/server/ListOffsetsPartitionStatus.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-18728 Move ListOffsetsPartitionStatus to server module [kafka]

2025-02-08 Thread via GitHub
kamalcph commented on code in PR #18807: URL: https://github.com/apache/kafka/pull/18807#discussion_r1947868160 ## server/src/main/java/org/apache/kafka/server/ListOffsetsPartitionStatus.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Comment Edited] (KAFKA-18737) KafkaDockerWrapper setup functions fails due to storage format command

2025-02-08 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924908#comment-17924908 ] TengYao Chi edited comment on KAFKA-18737 at 2/8/25 3:26 PM: -

[jira] [Updated] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-08 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nil Madhab updated KAFKA-18713: --- Description: There seems to be an issue when performing a left-join, the latest value with of the j

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-02-08 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1947824039 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,38 @@ private boolean canConvertToRelativeOffset(long offset)

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-08 Thread via GitHub
frankvicky commented on PR #18844: URL: https://github.com/apache/kafka/pull/18844#issuecomment-2645600078 The main issue is deciding which flag(--standalone, --initial-controllers, or --no-initial-controllers) should be used in run time. `--initial-controllers` is the easiest one; we

[PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-08 Thread via GitHub
frankvicky opened a new pull request, #18844: URL: https://github.com/apache/kafka/pull/18844 JIRA: KAFKA-18737 KafkaDockerWrapper is unable to execute the setup command properly since Apache Kafka 4.0 sets dynamic quorum as the default setting. When executing StorageTool, KafkaDockerWra

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-02-08 Thread via GitHub
ukpagrace commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2645509003 > Did not forget about it. Just no time yet. Thanks for the update, Matthias. If someone else can review it, let me know who to reach out to. -- This is an automated message fr

[jira] [Commented] (KAFKA-18755) Align timeout in kafka-share-groups.sh with other group-related tools

2025-02-08 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925187#comment-17925187 ] Jimmy Wang commented on KAFKA-18755: Hi [~schofielaj] , I could help to handle this

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-08 Thread via GitHub
JimmyWang6 commented on PR #18819: URL: https://github.com/apache/kafka/pull/18819#issuecomment-2644750671 FLAKY ⚠️ EagerConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() FLAKY ⚠️ AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion() FLAKY ⚠️ Coo

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-08 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925180#comment-17925180 ] Nil Madhab commented on KAFKA-18713: Can I pick this up or is it bit too challenging

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-08 Thread via GitHub
frankvicky commented on code in PR #18394: URL: https://github.com/apache/kafka/pull/18394#discussion_r1947539654 ## core/src/main/java/kafka/docker/Log4jConfiguration.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr