dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2645879873
I just pushed another commit that solves issues described by @poom-kitti above. Herewith my environment and some test I performed :arrow_down: ## Environment: Java version: ``` dejan@dejan-HP-ProBook-450-G7:~/kafka$ java -version openjdk version "17.0.14" 2025-01-21 OpenJDK Runtime Environment (build 17.0.14+7-Ubuntu-124.04) OpenJDK 64-Bit Server VM (build 17.0.14+7-Ubuntu-124.04, mixed mode, sharing) ``` Related PR git commits (four of them) plus trunk baseline commit: ``` dejan@dejan-HP-ProBook-450-G7:~/kafka$ git log -5 --oneline 9a2043041d (HEAD -> KAFKA-18142, origin/KAFKA-18142) solved issues with dependency tree for external projects with 'org.apache.kafka:kafka-clients' dependency 1e37b4e77b KAFKA-18142 shadow plugin version bumped to 8.3.6 7ddc6a519b (KAFKA-18142-shadow-8.3.5) Fix shadow configs e386d10229 KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` 649cd6b42c MINOR Fix conditional in Update Test Catalog workflow (#18289) dejan@dejan-HP-ProBook-450-G7:~/kafka$ ``` ## Testing: ### Create three `"kafka-clients"` versions: 1. create `kafka-clients` artifacts without PR changes/commits (i.e. use trunk baseline): ``` git checkout 649cd6b42c change 'gradle.properties' version to `4.1.0.1-SNAPSHOT` execute ./gradlew :clients:publishToMavenLocal -PskipSigning=true ``` 2. create `kafka-clients` artifacts with shadow plugin upgrade related commits (note: these artifacts will reproduce error described by @poom-kitti) ``` git checkout 1e37b4e77b change 'gradle.properties' version to `4.1.0.2-SNAPSHOT` execute ./gradlew :clients:publishToMavenLocal -PskipSigning=true ``` 3. create `kafka-clients` artifacts with a latest commit (that solves issues mentioned above, in step number 2.): ``` git checkout 9a2043041d change 'gradle.properties' version to `4.1.0.3-SNAPSHOT` execute ./gradlew :clients:publishToMavenLocal -PskipSigning=true ``` ### Generate dependency tree for a simple project (that uses `kafka-clients` versions from above): Use https://github.com/dejan2609/poc-kafka-18142.git in order to test dependency tree for project (and test all three kafka-clients versions created above). Note: `txt` files with dependency trees are created using `./gradlew dependencies > deps-X.txt` :bulb: _**You will find that these two files are equivalent:**_ - https://github.com/dejan2609/poc-kafka-18142/blob/trunk/deps-1.txt - https://github.com/dejan2609/poc-kafka-18142/blob/trunk/deps-3.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
