divijvaidya commented on PR #18106: URL: https://github.com/apache/kafka/pull/18106#issuecomment-2645938748
@mjsax I am sorry to hear that people had to spend multiple hours trying to fix this. I considered this change safe for KS without an expert review because: 1. the change maintained the configuration prior to this PR by explicitly setting `"log.message.timestamp.after.max.ms", String.valueOf(Long.MAX_VALUE)`. Hence, the assumption was that there is no change at all from test perspective?! 2. the test was successful after changing the config value to a value prior to the PR. I will look at why assumption 1 above was not correct in this scenario and improve the gap in my thought process. Also, I would explore how can we make it easier to for non-experts to change KS code as well, since, I think it would be beneficial for the community if we are able to scale without having to rely on experts for changes to a component. Separately, do you have any suggestions on how could we have reduced the time to mitigation from hours to minutes here? Where was the most time spent on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
