chia7712 commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1940637732
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -96,10 +100,32 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
frankvicky commented on code in PR #18789:
URL: https://github.com/apache/kafka/pull/18789#discussion_r1940619541
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -621,13 +621,14 @@ public void transitionToProspective() {
}
int retries = is
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940562488
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -640,10 +606,11 @@ public final void addStateStore(final StoreFa
junrao commented on PR #18277:
URL: https://github.com/apache/kafka/pull/18277#issuecomment-2632993183
@CalvinConfluent : Do you want to create a cherry-pick PR for 4.0 branch
just to make sure all tests pass there?
--
This is an automated message from the Apache Git Service.
To respond t
junrao merged PR #18277:
URL: https://github.com/apache/kafka/pull/18277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mjsax merged PR #18700:
URL: https://github.com/apache/kafka/pull/18700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567499
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -423,10 +423,8 @@ public void process(final Record record) {
}
}
}
-@Depre
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567798
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -423,10 +423,8 @@ public void process(final Record record) {
}
}
}
-@Depre
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940566642
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1963,7 +1924,6 @@ public String toString() {
+
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940565584
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -729,13 +707,21 @@ public boolean isStoreVersioned(final String
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564999
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564189
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563796
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563422
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -507,46 +510,23 @@ public final void addSink(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940561921
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -587,31 +550,34 @@ public final void addProcessor(final String n
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940558829
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -507,46 +510,23 @@ public final void addSink(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554541
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -368,7 +370,7 @@ private SinkNodeFactory(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549273
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -135,7 +139,7 @@ public synchronized Topology addSource(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554151
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -74,6 +74,8 @@ public InternalTopologyBuilder() {
}
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553801
##
streams/src/main/java/org/apache/kafka/streams/internals/ApiUtils.java:
##
@@ -81,6 +82,8 @@ public static String prepareMillisCheckFailMsgPrefix(final
Object value,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553477
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -677,10 +662,10 @@ public synchronized Topology
addProcessor(final String na
*
* @thr
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940552054
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -677,10 +662,10 @@ public synchronized Topology
addProcessor(final String na
*
* @thr
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940551476
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -617,7 +600,9 @@ public synchronized Topology addSink(final String
name,
*
* @throws
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940550708
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -510,62 +517,38 @@ public synchronized Topology addSink(final String
name,
}
/**
-
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940548959
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -119,10 +119,14 @@ private static AutoOffsetResetInternal
convertOldToNew(final Topology.AutoOffse
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1940546264
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() {
assertTh
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1940543756
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() {
assertTh
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1940544007
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() {
assertTh
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1940544007
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() {
assertTh
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1940543756
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() {
assertTh
[
https://issues.apache.org/jira/browse/KAFKA-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18693.
Fix Version/s: 4.1.0
Resolution: Fixed
> Remove PasswordEncoder
> -
Chia-Ping Tsai created KAFKA-18724:
--
Summary: fix flaky
SocketServerTest#testUnmuteChannelWithBufferedReceives
Key: KAFKA-18724
URL: https://issues.apache.org/jira/browse/KAFKA-18724
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18724:
---
Issue Type: Test (was: Improvement)
> fix flaky SocketServerTest#testUnmuteChannelWithBuffe
chia7712 merged PR #18790:
URL: https://github.com/apache/kafka/pull/18790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #18790:
URL: https://github.com/apache/kafka/pull/18790#issuecomment-2632902763
testFencingOnTransactionExpiration is traced by #18793
testOutdatedCoordinatorAssignment ->
https://issues.apache.org/jira/browse/KAFKA-15900
testUnmuteChannelWithBufferedR
chia7712 commented on code in PR #18641:
URL: https://github.com/apache/kafka/pull/18641#discussion_r1940475710
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -48,13 +48,6 @@ import scala.collection._
import scala.jdk.CollectionConverters._
/**
- * Dyn
chia7712 commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2632790573
> I think that could be done separately from this PR
yes, that can be a follow-up
Additionally, could you please check the license of
`AutoRepeatTestExtension.java` and plea
[
https://issues.apache.org/jira/browse/KAFKA-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923298#comment-17923298
]
Ukpa Uchechi edited comment on KAFKA-17345 at 2/4/25 3:49 AM:
[
https://issues.apache.org/jira/browse/KAFKA-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923551#comment-17923551
]
Ukpa Uchechi commented on KAFKA-17345:
--
oh sorry, I didn't see the security tag the
github-actions[bot] commented on PR #14717:
URL: https://github.com/apache/kafka/pull/14717#issuecomment-2632742313
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #15321: KAFKA-16102: fix the dynamic
modification of listeners' IP or port no…
URL: https://github.com/apache/kafka/pull/15321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #15321:
URL: https://github.com/apache/kafka/pull/15321#issuecomment-2632742459
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #15277:
URL: https://github.com/apache/kafka/pull/15277#issuecomment-2632742417
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #15277: KAFKA-16066: Upgrade apacheds
to 2.0.0.AM27 With apache kerby
URL: https://github.com/apache/kafka/pull/15277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-2632742391
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #17248:
URL: https://github.com/apache/kafka/pull/17248#issuecomment-2632742883
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] closed pull request #15189: KAFKA-16123:
KStreamKStreamJoinProcessor does not drop late records.
URL: https://github.com/apache/kafka/pull/15189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] closed pull request #14720: Update subscriptions at the end.
URL: https://github.com/apache/kafka/pull/14720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #14720:
URL: https://github.com/apache/kafka/pull/14720#issuecomment-2632742350
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #14717: IGNORE: Test PR for KAFKA-15062
URL: https://github.com/apache/kafka/pull/14717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #18711:
URL: https://github.com/apache/kafka/pull/18711#issuecomment-2632717925
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18463:
URL: https://github.com/apache/kafka/pull/18463#issuecomment-2632718000
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18715:
URL: https://github.com/apache/kafka/pull/18715#issuecomment-2632717898
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923545#comment-17923545
]
Chia-Ping Tsai commented on KAFKA-18459:
[~cmccabe] thanks for your feedback. Wh
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18459:
--
Assignee: Chia-Ping Tsai
> Support multiple JDKs in ducktape
> --
mjsax merged PR #18721:
URL: https://github.com/apache/kafka/pull/18721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax merged PR #18734:
URL: https://github.com/apache/kafka/pull/18734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #18780:
URL: https://github.com/apache/kafka/pull/18780#issuecomment-2632569081
Merged to `trunk` and cherry-picked to `4.0` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-18459:
-
Description:
Eventually we will need to support multiple JDKs in ducktape.
One example of why w
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-18459:
-
Description:
Eventually we will need to support multiple JDKs in ducktape.
One example of why w
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923539#comment-17923539
]
Colin McCabe commented on KAFKA-18459:
--
[~chia7712] thanks for commenting. I wasn't
[
https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923539#comment-17923539
]
Colin McCabe edited comment on KAFKA-18459 at 2/4/25 1:35 AM:
mjsax merged PR #18780:
URL: https://github.com/apache/kafka/pull/18780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #18765:
URL: https://github.com/apache/kafka/pull/18765#discussion_r1940327370
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1543,38 +1547,30 @@ private boolean close(final Optional timeout,
final boolean leaveGroup) {
FrankYang0529 commented on code in PR #18784:
URL: https://github.com/apache/kafka/pull/18784#discussion_r1940340298
##
metadata/src/test/java/org/apache/kafka/metadata/MockConfigRepository.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kirktrue commented on code in PR #18795:
URL: https://github.com/apache/kafka/pull/18795#discussion_r1940329129
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -408,22 +407,52 @@ protected Map
prepareFetchRequests()
long c
kirktrue commented on PR #18795:
URL: https://github.com/apache/kafka/pull/18795#issuecomment-2632512270
@jeffkbkim @junrao @lianetm-this is the second attempt at fixing the fix
session eviction bug (#17700). I've highlight the differences between the two
PRs. It really boils down to the ad
kirktrue commented on code in PR #18795:
URL: https://github.com/apache/kafka/pull/18795#discussion_r1940312912
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -408,22 +407,52 @@ protected Map
prepareFetchRequests()
long c
kirktrue opened a new pull request, #18795:
URL: https://github.com/apache/kafka/pull/18795
This change reduces fetch session cache evictions on the broker for
`AsyncKafkaConsumer` by altering its logic to determine which partitions it
includes in fetch requests.
# Background
mjsax commented on code in PR #18765:
URL: https://github.com/apache/kafka/pull/18765#discussion_r1938064632
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -347,8 +347,9 @@ private boolean setState(final State newState) {
} else if (state
jolshan opened a new pull request, #18794:
URL: https://github.com/apache/kafka/pull/18794
Noticed this while working on other bugfixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jolshan merged PR #18720:
URL: https://github.com/apache/kafka/pull/18720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan opened a new pull request, #18793:
URL: https://github.com/apache/kafka/pull/18793
It appears this test was failing because the transaction was never aborting
and the concurrent transactions errors would not go away.
https://github.com/apache/kafka/commit/ccab9eb8b4781eb4b8e
bbejeck commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1940245490
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1284 @@
+/*
+ * Licensed to the Apache Software Founda
jolshan commented on PR #18720:
URL: https://github.com/apache/kafka/pull/18720#issuecomment-2632380819
> Can we add a bit more information as to what is the nature of the perf
regression? And the PR description indicates that we are planning to add a
producer bench result?
I will ad
bbejeck commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940199139
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -662,87 +418,30 @@ public synchronized Topology addSink(final String name,
}
/**
-
CalvinConfluent commented on code in PR #18680:
URL: https://github.com/apache/kafka/pull/18680#discussion_r1940117855
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -113,15 +113,15 @@ public enum MetadataVersion {
// Bootstrap met
CalvinConfluent commented on PR #18277:
URL: https://github.com/apache/kafka/pull/18277#issuecomment-2632212123
@junrao Thanks for the review, now the tests look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/KAFKA-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-18723:
---
Description:
It is possible for a KRaft replica to send corrupted re
[
https://issues.apache.org/jira/browse/KAFKA-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923477#comment-17923477
]
José Armando García Sancio commented on KAFKA-18723:
What do you thi
cadonna commented on PR #18551:
URL: https://github.com/apache/kafka/pull/18551#issuecomment-2632069474
> Thanks for the updates @cadonna. Just nits. Any fixes to port from the
last changes to consumer/abstract membership manager?
Thanks a lot for this comment, @lucasbru ! I indeed fo
mimaison commented on code in PR #18201:
URL: https://github.com/apache/kafka/pull/18201#discussion_r1940016513
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -37,14 +38,17 @@ import org.apache.kafka.common.{KafkaException,
TopicPartit
José Armando García Sancio created KAFKA-18723:
--
Summary: KRaft must handle corrupted records in the fetch response
Key: KAFKA-18723
URL: https://issues.apache.org/jira/browse/KAFKA-18723
[
https://issues.apache.org/jira/browse/KAFKA-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923475#comment-17923475
]
Matthias J. Sax commented on KAFKA-18168:
-
Yeah I know... It's in our review bac
jeffkbkim commented on PR #18720:
URL: https://github.com/apache/kafka/pull/18720#issuecomment-2632038120
Can we add a bit more information as to what is the nature of the perf
regression? And the PR description indicates that we are planning to add a
producer bench result?
--
This is an
wernerdv commented on code in PR #18201:
URL: https://github.com/apache/kafka/pull/18201#discussion_r1939992923
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -45,6 +46,15 @@ import org.apache.kafka.storage.internals.log.AppendOrigin
i
iatsuk commented on PR #10333:
URL: https://github.com/apache/kafka/pull/10333#issuecomment-2631829391
Unfortunately, I can't remember. Actually, it could be a good idea to finish
the merge request, but for now, I don't have a suitable demo stand with metrics
to measure the final effect of
mumrah commented on PR #18792:
URL: https://github.com/apache/kafka/pull/18792#issuecomment-2631766929
I noticed that this trunk build did not have any test failures, but the
overall job still failed
https://github.com/apache/kafka/actions/runs/13117378766/job/36595745993. This
is because
mumrah opened a new pull request, #18792:
URL: https://github.com/apache/kafka/pull/18792
Increase the maximum number of flaky tests we tolerate for the main test
suite from 3 to 10. This will result in fewer failed trunk builds.
--
This is an automated message from the Apache Git Service
lianetm commented on code in PR #18702:
URL: https://github.com/apache/kafka/pull/18702#discussion_r1939721414
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1326,7 +1331,7 @@ private void close(Duration timeout, boolean
swa
lianetm commented on code in PR #18702:
URL: https://github.com/apache/kafka/pull/18702#discussion_r1939721414
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1326,7 +1331,7 @@ private void close(Duration timeout, boolean
swa
kamalcph commented on PR #18787:
URL: https://github.com/apache/kafka/pull/18787#issuecomment-2631717442
> > Unrelated to this change, but are we still using
> > ```
> > public int metadataPartition(TopicIdPartition topicIdPartition) {
> > return rlmTopicPartitioner.metad
kamalcph opened a new pull request, #18791:
URL: https://github.com/apache/kafka/pull/18791
- Reduced the scope of method access modifier from public to
package-protected
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-18722:
Assignee: Kamal Chandraprakash
> Remove the unreferenced methods from Top
clolov commented on code in PR #18783:
URL: https://github.com/apache/kafka/pull/18783#discussion_r1939765619
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -18,45 +18,15 @@
import org.apache.kafka.common.Uuid;
-import java.util.O
kamalcph merged PR #18787:
URL: https://github.com/apache/kafka/pull/18787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
1 - 100 of 259 matches
Mail list logo