kamalcph commented on PR #18787:
URL: https://github.com/apache/kafka/pull/18787#issuecomment-2631717442
> > Unrelated to this change, but are we still using
> > ```
> > public int metadataPartition(TopicIdPartition topicIdPartition) {
> > return rlmTopicPartitioner.metadataPartition(topicIdPartition);
> > }
> >
> > // Visible For Testing
> > public Optional<Long> readOffsetForPartition(int metadataPartition) {
> > return consumerManager.readOffsetForPartition(metadataPartition);
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > in TopicBasedRemoteLogMetadataManager? My IDE shows them as unreferenced
and I did a bit of historical lookup and the tests they were used in seem to
have since been removed.
>
> Filed [KAFKA-18722](https://issues.apache.org/jira/browse/KAFKA-18722) to
remove the unreferenced methods. Thanks for the review!
Opened #18791 to address this comment. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
