Re: [PR] KAFKA-18230: handle not controller or not leader error in admin client [kafka]

mimaison commented on PR #18165: URL: https://github.com/apache/kafka/pull/18165#issuecomment-2626501269 I'll try to take a look today. @AndrewJSchofield if you have time, can you take a look too? Thanks -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-18685: Refactor DynamicLogConfig constructor [kafka]

m1a2st commented on code in PR #18764: URL: https://github.com/apache/kafka/pull/18764#discussion_r1936800369 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -362,23 +361,6 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging

[PR] KAFKA-18685: Refactor DynamicLogConfig constructor [kafka]

m1a2st opened a new pull request, #18764: URL: https://github.com/apache/kafka/pull/18764 Jira: https://issues.apache.org/jira/browse/KAFKA-18685 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

dajac commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2626462534 @junrao @kirktrue If the cherry-pick is clean, we can just cherry-pick it to 4.0 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on PR #18737: URL: https://github.com/apache/kafka/pull/18737#issuecomment-2626426396 Hi @kirktrue Thanks for the review. Since the current version is hugely different from the previous one, please retake a look. -- This is an automated message from the Apache

Re: [PR] KAFKA-18677: Update ConsoleConsumerTest system test [kafka]

frankvicky commented on PR #18763: URL: https://github.com/apache/kafka/pull/18763#issuecomment-2626420375 e2e result on my local:  -- This is an automated message

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1936745835 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -250,7 +251,10 @@ private void process(final SyncCo

[jira] [Created] (KAFKA-18684) Implement new base exception classes

Kaushik Raina created KAFKA-18684: - Summary: Implement new base exception classes Key: KAFKA-18684 URL: https://issues.apache.org/jira/browse/KAFKA-18684 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-18684) Implement new base exception classes

[ https://issues.apache.org/jira/browse/KAFKA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina reassigned KAFKA-18684: - Assignee: Kaushik Raina > Implement new base exception classes > --

[PR] KAFKA-18677: Update ConsoleConsumerTest system test [kafka]

frankvicky opened a new pull request, #18763: URL: https://github.com/apache/kafka/pull/18763 JIRA: KAFKA-18677 The ConsoleConsumerTest system test still relied on ZK, so it failed. We should convert it to kraft. ### Committer Checklist (excluded from commit message) - [ ] Ve

[jira] [Resolved] (KAFKA-15048) Improve handling of unexpected quorum controller errors

[ https://issues.apache.org/jira/browse/KAFKA-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15048. - Resolution: Fixed > Improve handling of unexpected quorum controller errors > --

[jira] [Resolved] (KAFKA-15271) Historicalterator can exposes elements that are too new

[ https://issues.apache.org/jira/browse/KAFKA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15271. - Resolution: Fixed > Historicalterator can exposes elements that are too new > --

[jira] [Resolved] (KAFKA-15318) Update the Authorizer using AclPublisher

[ https://issues.apache.org/jira/browse/KAFKA-15318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15318. - Resolution: Fixed > Update the Authorizer using AclPublisher > -

[jira] [Resolved] (KAFKA-15458) Fully resolve endpoint information before registering controllers

[ https://issues.apache.org/jira/browse/KAFKA-15458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15458. - Resolution: Fixed > Fully resolve endpoint information before registering controllers >

Re: [PR] KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… [kafka]

ashwinpankaj commented on PR #18762: URL: https://github.com/apache/kafka/pull/18762#issuecomment-2626359847 @mimaison @C0urante @yashmayya can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… [kafka]

ashwinpankaj opened a new pull request, #18762: URL: https://github.com/apache/kafka/pull/18762 …-startup-success A minor bug was introduced as part of [EOS in Apache Kafka 3 years ago](https://github.com/apache/kafka/commit/9e8ef8bb317599c184ce8201d494edf109d9c528#diff-90b4072cc070e1

[PR] MINOR: cleanup KStream JavaDocs (8/N) - stream-stream-inner-join [kafka]

mjsax opened a new pull request, #18761: URL: https://github.com/apache/kafka/pull/18761 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Assigned] (KAFKA-18677) Update ConsoleConsumerTest system test

[ https://issues.apache.org/jira/browse/KAFKA-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18677: -- Assignee: TengYao Chi > Update ConsoleConsumerTest system test >

[PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

mjsax opened a new pull request, #18760: URL: https://github.com/apache/kafka/pull/18760 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on PR #18721: URL: https://github.com/apache/kafka/pull/18721#issuecomment-2626258595 Rebased to resolve merge conflicts, and address review comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: cleanup KStream JavaDocs (3/N) - groupBy[Key] [kafka]

mjsax merged PR #18705: URL: https://github.com/apache/kafka/pull/18705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

mjsax merged PR #18722: URL: https://github.com/apache/kafka/pull/18722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] [WIP] KAFKA-16717 Add AdminClient.alterShareGroupOffsets [kafka]

github-actions[bot] commented on PR #18675: URL: https://github.com/apache/kafka/pull/18675#issuecomment-2626204477 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18461; Fix potential NPE in setDelta after map is erased [kafka]

github-actions[bot] commented on PR #18684: URL: https://github.com/apache/kafka/pull/18684#issuecomment-2626204457 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Resolved] (KAFKA-18594) Cleanup BrokerLifecycleManager

[ https://issues.apache.org/jira/browse/KAFKA-18594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18594. - Resolution: Fixed > Cleanup BrokerLifecycleManager > -- > > Key: KAF

[jira] [Commented] (KAFKA-18677) Update ConsoleConsumerTest system test

[ https://issues.apache.org/jira/browse/KAFKA-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922551#comment-17922551 ] TengYao Chi commented on KAFKA-18677: - Hi [~dajac]  I would like to handle it if yo

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

CalvinConfluent commented on code in PR #18277: URL: https://github.com/apache/kafka/pull/18277#discussion_r1936517489 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -432,23 +443,29 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

CalvinConfluent commented on PR #18277: URL: https://github.com/apache/kafka/pull/18277#issuecomment-2626049014 @junrao @splett2 Based on the feedback, I updated the following: 1. Instead of modifying the whole ClusterControl register logic, I added a clean shutdown flag for the Repli

[jira] [Commented] (KAFKA-18522) Limit fetch records batches as per acquired records

[ https://issues.apache.org/jira/browse/KAFKA-18522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922550#comment-17922550 ] Apoorv Mittal commented on KAFKA-18522: --- Thanks for confirming [~junrao], I have c

[jira] [Created] (KAFKA-18683) File records slice errors when sliced for moved start position

Apoorv Mittal created KAFKA-18683: - Summary: File records slice errors when sliced for moved start position Key: KAFKA-18683 URL: https://issues.apache.org/jira/browse/KAFKA-18683 Project: Kafka

[jira] [Assigned] (KAFKA-18676) Update Benchmark system tests

[ https://issues.apache.org/jira/browse/KAFKA-18676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18676: - Assignee: PoAn Yang > Update Benchmark system tests > - > >

[jira] [Assigned] (KAFKA-18678) Update TestVerifiableProducer system test

[ https://issues.apache.org/jira/browse/KAFKA-18678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18678: - Assignee: PoAn Yang > Update TestVerifiableProducer system test > -

[jira] [Updated] (KAFKA-16524) Metrics for KIP-853

[ https://issues.apache.org/jira/browse/KAFKA-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16524: --- Fix Version/s: 4.1.0 > Metrics for KIP-853 > --- > >

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

jolshan commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936496849 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -569,20 +569,21 @@ class UnifiedLog(@volatile var logStartOffset: Long, * Maybe create and return the Verif

[PR] WIP: Handle slicing of file records for updated start position [kafka]

apoorvmittal10 opened a new pull request, #18759: URL: https://github.com/apache/kafka/pull/18759 To be filled ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentati

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

jolshan commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936485613 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -569,20 +569,21 @@ class UnifiedLog(@volatile var logStartOffset: Long, * Maybe create and return the Verif

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

artemlivshits commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936469374 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -569,20 +569,21 @@ class UnifiedLog(@volatile var logStartOffset: Long, * Maybe create and return the

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on PR #18727: URL: https://github.com/apache/kafka/pull/18727#issuecomment-2625968864 @chia7712 @junrao The tests should now be passing for this PR. The comments should also make it clear what's going on. The main point of contention is whether we should remove v0-v2 from th

Re: [PR] [ KAFKA-17049 ] fix Incremental rebalances assign too many tasks for the same connector together [kafka]

seankumar-tl commented on PR #16486: URL: https://github.com/apache/kafka/pull/16486#issuecomment-2625946154 @yazgoo - I just wanted to check if there has been any additional progress here and if you've been able to run your PR on a production environment to solve task distribution based on

[jira] [Resolved] (KAFKA-16524) Metrics for KIP-853

[ https://issues.apache.org/jira/browse/KAFKA-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-16524. Resolution: Fixed > Metrics for KIP-853 > --- > >

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

jsancio merged PR #18304: URL: https://github.com/apache/kafka/pull/18304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-17182) Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922543#comment-17922543 ] Kirk True commented on KAFKA-17182: --- PR has been merged into trunk, and working to bac

Re: [PR] KAFKA-18645: New consumer should align close timeout handling with classic consumer [kafka]

kirktrue commented on PR #18702: URL: https://github.com/apache/kafka/pull/18702#issuecomment-2625755604 > Hi @kirktrue > > > I'd like to see a sanity check unit test added to somewhere like KafkaConsumerTest that ensures that the value of request.timeout.ms is used over the timeout

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2625747914 > @kirktrue : Do we want to create a separate PR to cherry-pick this to 4.0? Yes. Is that step performed by the merge-r or the contributor? Sometimes the person merging to `trunk`

[jira] [Commented] (KAFKA-18034) CommitRequestManager should fail pending requests on fatal coordinator errors

[ https://issues.apache.org/jira/browse/KAFKA-18034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922533#comment-17922533 ] Lianet Magrans commented on KAFKA-18034: PR with initial changes + fix needed af

[jira] [Comment Edited] (KAFKA-18034) CommitRequestManager should fail pending requests on fatal coordinator errors

[ https://issues.apache.org/jira/browse/KAFKA-18034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922533#comment-17922533 ] Lianet Magrans edited comment on KAFKA-18034 at 1/30/25 9:58 PM: -

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

jolshan commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936348768 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -67,10 +67,14 @@ object AddPartitionsToTxnManager { *genericErrorSupported: This maps t

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

lianetm merged PR #18754: URL: https://github.com/apache/kafka/pull/18754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

jolshan commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936346953 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -950,7 +958,7 @@ class ReplicaManager(val config: KafkaConfig, ): Unit = { // Skip verification

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

jolshan commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936346455 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -67,10 +67,14 @@ object AddPartitionsToTxnManager { *genericErrorSupported: This maps t

[PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

jolshan opened a new pull request, #18758: URL: https://github.com/apache/kafka/pull/18758 Fixed the typo that used the wrong producer ID and epoch when returning so that we handle epoch overflow correctly. We also had to rearrange the concurrent transaction handling so that we don't

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

artemlivshits commented on code in PR #18720: URL: https://github.com/apache/kafka/pull/18720#discussion_r1936311685 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -67,10 +67,14 @@ object AddPartitionsToTxnManager { *genericErrorSupported: This

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936336116 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -264,8 +273,11 @@ public boolean hasValidVersion() { return oldestVersion() <= late

Re: [PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

jolshan merged PR #18730: URL: https://github.com/apache/kafka/pull/18730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-18680) Design unclean recovery elections subsystem

Jonah Hooper created KAFKA-18680: Summary: Design unclean recovery elections subsystem Key: KAFKA-18680 URL: https://issues.apache.org/jira/browse/KAFKA-18680 Project: Kafka Issue Type: Sub-t

[jira] [Commented] (KAFKA-17379) KafkaStreams: Unexpected state transition from ERROR to PENDING_SHUTDOWN

[ https://issues.apache.org/jira/browse/KAFKA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922531#comment-17922531 ] Lucas Brutschy commented on KAFKA-17379: Since there wasn't any activity on this

[jira] [Assigned] (KAFKA-17379) KafkaStreams: Unexpected state transition from ERROR to PENDING_SHUTDOWN

[ https://issues.apache.org/jira/browse/KAFKA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-17379: -- Assignee: Lucas Brutschy (was: TengYao Chi) > KafkaStreams: Unexpected state transit

[jira] [Assigned] (KAFKA-18682) Designated Leadership Elections

[ https://issues.apache.org/jira/browse/KAFKA-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper reassigned KAFKA-18682: Assignee: Jonah Hooper > Designated Leadership Elections > --

[jira] [Created] (KAFKA-18682) Designated Leadership Elections

Jonah Hooper created KAFKA-18682: Summary: Designated Leadership Elections Key: KAFKA-18682 URL: https://issues.apache.org/jira/browse/KAFKA-18682 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-18681) GetReplicaLogInfo request

Jonah Hooper created KAFKA-18681: Summary: GetReplicaLogInfo request Key: KAFKA-18681 URL: https://issues.apache.org/jira/browse/KAFKA-18681 Project: Kafka Issue Type: Sub-task Re

[jira] [Assigned] (KAFKA-18680) Design unclean recovery elections subsystem

[ https://issues.apache.org/jira/browse/KAFKA-18680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper reassigned KAFKA-18680: Assignee: Jonah Hooper > Design unclean recovery elections subsystem > --

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

junrao commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2625605547 @kirktrue : Do we want to create a separate PR to cherry-pick this to 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2625605468 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

junrao merged PR #17700: URL: https://github.com/apache/kafka/pull/17700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18024 ConcurrentModificationException in Kafka OffsetFetcher - Proposal for Thread-Safety Fix - Update OffsetFetcher.java [kafka]

chia7712 commented on PR #17826: URL: https://github.com/apache/kafka/pull/17826#issuecomment-2625590727 That's interesting. `remainingToSearch` is a local variable, and it's modified within a synchronized block (`synchronized (future)`). How can it be modified concurrently? Have you tested

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

bbejeck commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1936292204 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -956,36 +956,36 @@ static > String createRepartition } @Overrid

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

chia7712 commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936263117 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -264,8 +273,11 @@ public boolean hasValidVersion() { return oldestVersion() <= l

Re: [PR] KAFKA-18325: Add TargetAssignmentBuilder [kafka]

bbejeck commented on code in PR #18676: URL: https://github.com/apache/kafka/pull/18676#discussion_r1936153413 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TargetAssignmentBuilder.java: ## @@ -0,0 +1,366 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2625517999 @junrao @lianetm @jeffkbkim—all green! Can we merge? 🥺 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-18168) GlobalKTable does not checkpoint restored offsets until next 10K events

[ https://issues.apache.org/jira/browse/KAFKA-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922521#comment-17922521 ] Matthias J. Sax commented on KAFKA-18168: - Thanks. Will put it into my review ba

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936224109 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -69,11 +74,6 @@ public ProduceRequest build(short version) { return buil

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936221997 ## clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java: ## @@ -208,26 +208,26 @@ public static String toHtml() { // Responses b

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936220770 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -341,10 +353,7 @@ public static EnumSet controllerApis() { } public static EnumS

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936219937 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -149,6 +149,12 @@ public enum ApiKeys { private static final Map ID_TO_TYPE = Arrays.s

Re: [PR] KAFKA-18659: librdkafka compressed produce fails unless api versions returns produce v0 [kafka]

ijuma commented on code in PR #18727: URL: https://github.com/apache/kafka/pull/18727#discussion_r1936219425 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -264,8 +273,11 @@ public boolean hasValidVersion() { return oldestVersion() <= late

[PR] KAFKA-18667: Add ducktape tests for simultaneous broker + controller failure [kafka]

kevin-wu24 opened a new pull request, #18757: URL: https://github.com/apache/kafka/pull/18757 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrad

Re: [PR] MINOR: cleanup KStream JavaDocs (3/N) - groupBy[Key] [kafka]

mjsax commented on code in PR #18705: URL: https://github.com/apache/kafka/pull/18705#discussion_r1936209602 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -960,126 +960,65 @@ KTable toTable(final Named named, final Materi

[jira] [Commented] (KAFKA-18522) Limit fetch records batches as per acquired records

[ https://issues.apache.org/jira/browse/KAFKA-18522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922512#comment-17922512 ] Jun Rao commented on KAFKA-18522: - [~apoorvmittal10] : Thanks for finding this. I think

Re: [PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

jeffkbkim commented on code in PR #18730: URL: https://github.com/apache/kafka/pull/18730#discussion_r1936184450 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -408,13 +408,16 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

jolshan commented on code in PR #18730: URL: https://github.com/apache/kafka/pull/18730#discussion_r1936172868 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -408,13 +408,16 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1936163586 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1791,10 +1875,23 @@ be removed once all the messages (0-99) are acknowledged (ACCEPT or REJ

Re: [PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

jeffkbkim commented on code in PR #18730: URL: https://github.com/apache/kafka/pull/18730#discussion_r1936161525 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -408,13 +408,16 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

junrao commented on code in PR #18277: URL: https://github.com/apache/kafka/pull/18277#discussion_r1936160182 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -432,23 +443,29 @@ public ControllerResult registerBroker(

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1936153459 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2213,7 +2213,7 @@ KStream join(final KTable table,

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

lucasbru commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1936150222 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2097,276 +2103,115 @@ KStream outerJoin(final KStream otherStream, *

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1936148530 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1825,8 +1921,8 @@ private boolean canMoveStartOffset() { NavigableMap.Entry entry

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

lucasbru commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1936145367 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2213,7 +2213,7 @@ KStream join(final KTable table,

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1936142802 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2160,6 +2234,43 @@ private long startOffsetDuringInitialization(long partitionDataStartOffs

Re: [PR] MINOR: remove close from contextual processors javadoc [kafka]

mjsax commented on PR #18746: URL: https://github.com/apache/kafka/pull/18746#issuecomment-2625344185 Thanks for the PR. Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (KAFKA-17680) StandbyTaskEOSMultiRebalanceIntegrationTest caused build failure

[ https://issues.apache.org/jira/browse/KAFKA-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-17680. - Resolution: Cannot Reproduce We did not see this error again, and the test has 100% pass

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1936142802 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2160,6 +2234,43 @@ private long startOffsetDuringInitialization(long partitionDataStartOffs

Re: [PR] MINOR: remove close from contextual processors javadoc [kafka]

mjsax merged PR #18746: URL: https://github.com/apache/kafka/pull/18746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Comment Edited] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922495#comment-17922495 ] Lucas Brutschy edited comment on KAFKA-18355 at 1/30/25 7:00 PM: -

[jira] [Commented] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922495#comment-17922495 ] Lucas Brutschy commented on KAFKA-18355: I injected Authentication Errors into t

[jira] [Assigned] (KAFKA-15580) KIP-966: Unclean Recovery

[ https://issues.apache.org/jira/browse/KAFKA-15580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-15580: Assignee: Jonah Hooper > KIP-966: Unclean Recovery > - > >

[PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

lianetm opened a new pull request, #18756: URL: https://github.com/apache/kafka/pull/18756 Broker and Consumer notable changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] MINOR: cleanup KStream JavaDocs (3/N) - groupBy[Key] [kafka]

lucasbru commented on code in PR #18705: URL: https://github.com/apache/kafka/pull/18705#discussion_r1936113529 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -960,126 +960,65 @@ KTable toTable(final Named named, final Mat

[PR] MINOR: cleanup KStream JavaDocs (6/N) - map[Values] [kafka]

mjsax opened a new pull request, #18755: URL: https://github.com/apache/kafka/pull/18755 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

CalvinConfluent commented on code in PR #18277: URL: https://github.com/apache/kafka/pull/18277#discussion_r1936106162 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -422,7 +425,15 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

CalvinConfluent commented on code in PR #18277: URL: https://github.com/apache/kafka/pull/18277#discussion_r1936106162 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -422,7 +425,15 @@ public ControllerResult registerBroker(

  1   2   3   >