ashwinpankaj opened a new pull request, #18762: URL: https://github.com/apache/kafka/pull/18762
…-startup-success A minor bug was introduced as part of [EOS in Apache Kafka 3 years ago](https://github.com/apache/kafka/commit/9e8ef8bb317599c184ce8201d494edf109d9c528#diff-90b4072cc070e1d6417b3bb59a4a35668c4d97ce1dd6a2587db9f2c9a9ebf93e) The line ``` final TaskStatus.Listener taskStatusListener = workerMetricsGroup.wrapStatusListener(statusListener); ``` wraps herder's listener in workerMetricsGroup's listener. WorkerMetricsGroup is the entity which records task success and failure in the metric . In the PR, the wrapped listener was missed and instead the herder listener is passed to the task builder (as part of constructor). *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* workerMetricsGroup's UT already validates that the metrics get updated when tasks fail or succeed. I did not see a way to test connector's metrics using JMX ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
