kirktrue commented on PR #18702:
URL: https://github.com/apache/kafka/pull/18702#issuecomment-2625755604

   > Hi @kirktrue
   > 
   > > I'd like to see a sanity check unit test added to somewhere like 
KafkaConsumerTest that ensures that the value of request.timeout.ms is used 
over the timeout passed in. If that's the intended and documented behavior, we 
should validate it to be so.
   > 
   > I think it's not easy to check it. Could we rely on 
`ConsumeBounceTest#testClose` to validate this behavior ?
   
   If it's a lot of work, I guess we can skip it and assume `testClose()` 
validates the desired behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to