dajac merged PR #17277:
URL: https://github.com/apache/kafka/pull/17277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
jeqo commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2376067147
We have received feedback of this issue persisting on 3.8, so I guess we
could have another look at this PR.
@showuon I have made the TransactionIndexFile channel access methods
synch
smjn commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1776430833
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java:
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
showuon commented on PR #14119:
URL: https://github.com/apache/kafka/pull/14119#issuecomment-2376058424
@amangandhi94 , thanks for your contribution! For this question:
> Just wondering how can I get more attention to bugs or PR i have raised
next time onwards?
I'm sorry that I did
showuon closed pull request #14119: KAFKA-15266: Static configs set for non
primary synonyms are ignored for Log configs
URL: https://github.com/apache/kafka/pull/14119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon opened a new pull request, #17278:
URL: https://github.com/apache/kafka/pull/17278
Backporting https://github.com/apache/kafka/pull/17258
Several Kafka log configurations in have synonyms. For example, log
retention can be configured either by log.retention.ms, or by
log.rete
smjn commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1776452137
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java:
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
showuon merged PR #17258:
URL: https://github.com/apache/kafka/pull/17258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776431850
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -732,17 +732,7 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Brok
showuon commented on PR #17258:
URL: https://github.com/apache/kafka/pull/17258#issuecomment-2376012733
All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
smjn commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1776423900
##
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/StateBatchUtilTest.java:
##
@@ -0,0 +1,472 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
showuon commented on code in PR #17132:
URL: https://github.com/apache/kafka/pull/17132#discussion_r1776418279
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1588,6 +1588,100 @@ private void doTestFindOffsetByTimestamp(long ts, long
startOffset, int ta
satishd merged PR #17112:
URL: https://github.com/apache/kafka/pull/17112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
TaiJuWu commented on code in PR #17168:
URL: https://github.com/apache/kafka/pull/17168#discussion_r1776371598
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##
@@ -131,9 +131,11 @@ private static void validateProperties(Properties
properties
[
https://issues.apache.org/jira/browse/KAFKA-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu reassigned KAFKA-16966:
---
Assignee: TaiJuWu
> Allow offset commit fetch to reuse previous request if partitions are a subset
[
https://issues.apache.org/jira/browse/KAFKA-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884851#comment-17884851
]
Logan Zhu commented on KAFKA-17606:
---
Hi, [~davidarthur]
Can I have this one? thanks!
[
https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu-Lin Chen resolved KAFKA-17515.
-
Resolution: Fixed
Since the Jenkins build on the trunk has been disabled today, close the second
chenyulin0719 commented on PR #17272:
URL: https://github.com/apache/kafka/pull/17272#issuecomment-2375839932
Close it sinece the Jenkins build has been disable.
We shouldn't see the unstable build again. Will keep monitoring this issue.
--
This is an automated message from the Apache
chenyulin0719 closed pull request #17272: KAFKA-17515: Fix flaky
RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener by
increasing stream client start timeout
URL: https://github.com/apache/kafka/pull/17272
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-17615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884837#comment-17884837
]
黃竣陽 commented on KAFKA-17615:
-
Hi [~cmccabe], if you're not working on this, may I take this
mjsax commented on PR #17259:
URL: https://github.com/apache/kafka/pull/17259#issuecomment-2375771525
`UnnecessaryStubbingException` -- no idea where this is coming from 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mjsax merged PR #17163:
URL: https://github.com/apache/kafka/pull/17163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi reassigned KAFKA-15588:
---
Assignee: TengYao Chi
> Purge the unsent offset commits/fetches when the member is fenced/f
[
https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884834#comment-17884834
]
Kirk True commented on KAFKA-17518:
---
Thanks! :)
> AsyncKafkaConsumer cannot reliably
[
https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884833#comment-17884833
]
TengYao Chi commented on KAFKA-17518:
-
Hi [~kirktrue]
Thanks for information.
I wi
kirktrue commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2375754964
cc @FrankYang0529 since you're working on KAFKA-17519 👋
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kirktrue commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2375753117
cc @frankvicky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884832#comment-17884832
]
Kirk True commented on KAFKA-17518:
---
[~frankvicky]—as [~lianetm] mentioned, this Jira
mjsax commented on code in PR #16050:
URL: https://github.com/apache/kafka/pull/16050#discussion_r1776270654
##
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest.java:
##
@@ -125,8 +125,8 @@ public static v
[
https://issues.apache.org/jira/browse/KAFKA-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884831#comment-17884831
]
Fake commented on KAFKA-17590:
--
CorruptRecordException first [~junrao]
> ReplicaFetcher t
[
https://issues.apache.org/jira/browse/KAFKA-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16778:
--
Labels: kip-848-client-support (was: )
> AsyncKafkaConsumer fetcher might occasionally try to fetch t
[
https://issues.apache.org/jira/browse/KAFKA-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16778:
--
Component/s: clients
consumer
> AsyncKafkaConsumer fetcher might occasionally try to
[
https://issues.apache.org/jira/browse/KAFKA-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884828#comment-17884828
]
Kirk True commented on KAFKA-16966:
---
[~taijuwu]—feel free to take it :)
> Allow offse
mjsax commented on PR #16761:
URL: https://github.com/apache/kafka/pull/16761#issuecomment-2375693057
Thanks! The PR LGTM, but you should close the VOTE for KIP-1087 before we
merge it, by replying to the VOTE thread, calling the vote closed and the KIP
as accepted, summarizing the voting r
[
https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884827#comment-17884827
]
Kirk True commented on KAFKA-15588:
---
[~frankvicky]—I can't say with any certainty, but
mjsax commented on PR #17182:
URL: https://github.com/apache/kafka/pull/17182#issuecomment-2375672399
Thanks for the update. Overall LGTM -- one more minor question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-17581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17581:
--
Labels: consumer-threading-refactor kip-848-client-support (was: )
> AsyncKafkaConsumer can't unsubsc
mjsax commented on code in PR #17182:
URL: https://github.com/apache/kafka/pull/17182#discussion_r1776244084
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -139,7 +139,7 @@ public class StreamsMetricsImplTest {
mjsax commented on code in PR #17182:
URL: https://github.com/apache/kafka/pull/17182#discussion_r1776242300
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -3030,7 +3030,7 @@ private StreamTask createSingleSourceStateless(final
[
https://issues.apache.org/jira/browse/KAFKA-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884826#comment-17884826
]
TengYao Chi commented on KAFKA-17613:
-
Hello [~cmccabe]
If you haven’t started wor
[
https://issues.apache.org/jira/browse/KAFKA-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17582:
--
Component/s: consumer
> Unpredictable consumer position after transaction abort
>
mjsax commented on PR #17275:
URL: https://github.com/apache/kafka/pull/17275#issuecomment-2375648848
Thanks Bill. Made a pass. Can you also trigger a system test run and share
the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776232271
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -216,12 +208,7 @@ def collect_results(self, sleep_time_secs):
broker_type=["leader"],
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776232271
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -216,12 +208,7 @@ def collect_results(self, sleep_time_secs):
broker_type=["leader"],
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776229140
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -152,16 +151,9 @@ def confirm_topics_on_all_brokers(self,
expected_topic_set):
def s
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776227488
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -152,16 +151,9 @@ def confirm_topics_on_all_brokers(self,
expected_topic_set):
def s
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776222580
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = Kafka
kirktrue commented on PR #17244:
URL: https://github.com/apache/kafka/pull/17244#issuecomment-2375629455
@FrankYang0529—I just want to say I like the current approach. It's much
cleaner 😄
I haven't had a chance to dig into the root cause as I'm curious what can be
done at that layer
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776222580
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = Kafka
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776221750
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = Kafka
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776221513
##
tests/kafkatest/services/streams.py:
##
@@ -627,11 +627,6 @@ def prop_file(self):
def start_cmd(self, node):
args = self.args.copy()
-
-if self
[
https://issues.apache.org/jira/browse/KAFKA-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17439:
--
Labels: consumer-threading-refactor kip-848-client-support (was:
consumer-threading-refactor)
> Make
mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1776220211
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -18,9 +18,8 @@
from ducktape.mark.resource import cluster
from ducktape.tests.test import Te
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1776206186
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -65,16 +69,60 @@ protected void maybeThrowAuthFailure(Node node) {
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1776205457
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -3387,6 +3394,71 @@ public void
testWhenFetchResponseReturnsA
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1776205136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -697,6 +698,8 @@ public ConsumerRecords poll(final Duration timeout
kirktrue commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1776180315
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1341,6 +1342,79 @@ public void testCloseAwaitPendingAsyncCommi
kirktrue commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2375564338
Hi @chia7712!
> Apologies, but I have another question. If the interrupt is swallowed, how
can users forcefully close the consumer? The wakeup method doesn't work during
close, an
[
https://issues.apache.org/jira/browse/KAFKA-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-16955:
---
Fix Version/s: 3.8.1
> ConcurrentModification exception thrown by KafkaStrea
ableegoldman commented on PR #16337:
URL: https://github.com/apache/kafka/pull/16337#issuecomment-2375553507
Went ahead and cherrypicked back to 3.8 🤷♀️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Justine Olshan created KAFKA-17617:
--
Summary: New GitHub Actions build builds Java 8 with 2.13 instead
of 2.12
Key: KAFKA-17617
URL: https://issues.apache.org/jira/browse/KAFKA-17617
Project: Kafka
jolshan commented on PR #17093:
URL: https://github.com/apache/kafka/pull/17093#issuecomment-2375532175
Still seeing an issue with Scala 2.12 :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jolshan merged PR #17265:
URL: https://github.com/apache/kafka/pull/17265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
TaiJuWu commented on PR #17260:
URL: https://github.com/apache/kafka/pull/17260#issuecomment-2375517375
> > test on: [TaiJuWu#10](https://github.com/TaiJuWu/kafka/pull/10)
>
> I don't find any changes as per this PR on mentioned test PR, am I missing
something?
Hi @apoorvmittal
jolshan commented on PR #17273:
URL: https://github.com/apache/kafka/pull/17273#issuecomment-2375517383
I was looking for the Jenkins build on a few PR and now I understand why it
is gone. Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375500521
> Also, I wonder if we should do a git fetch origin as part of the command.
Otherwise, we might pull in a SHA that doesn't exist locally
I think it will not work well for all cases
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375498807
Ok, now we need to take the SHA captured by `cut` and use update-ref to
create a local branch.
I'd like to see this output:
```
$ git update-cache
Local branch 'trunk-c
jolshan commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776137936
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buf
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375493797
The new `cut` options are working 👍
```
$ git update-cache
264131cdaaef3f4696942f26534b3f61f3a2a162
```
--
This is an automated message from the Apache G
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375491776
Oops, sorry didn't mean to update the branch. `gh update-branch` did the
opposite that I expected 😅
--
This is an automated message from the Apache Git Service.
To respond to the messag
jolshan commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776131479
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buf
jolshan commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776131479
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buf
jolshan commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776131026
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buf
jolshan commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776130089
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buf
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375488213
Also, I wonder if we should do a `git fetch origin` as part of the command.
Otherwise, we might pull in a SHA that doesn't exist locally
--
This is an automated message from the Apac
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375488174
Oh! Okay, I will modify the options, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375486383
Thanks @fonsdant! I tried it and got an error from `cut`. I'm on an Apple
Silicon Mac
```
$ ./committer-tools/update-cache.sh
cut: illegal option -- -
usage: cut -b list [-
[
https://issues.apache.org/jira/browse/KAFKA-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Chuan Yu reassigned KAFKA-17607:
-
Assignee: Chia-Chuan Yu
> Add CI step to verify LICENSE-binary
> -
[
https://issues.apache.org/jira/browse/KAFKA-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884813#comment-17884813
]
David Arthur commented on KAFKA-17607:
--
Sounds good, [~chiacyu]. Go for it :)
> A
[
https://issues.apache.org/jira/browse/KAFKA-16339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884814#comment-17884814
]
João Pedro Fonseca commented on KAFKA-16339:
[~mjsax], should I base the PRs
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2375473179
@mumrah, @chia7712, I have created an `update-cache.sh` script inside
`committer-tools`. It retrieves the latest commit (by `created_at`). Also, it
makes the Git alias, if it does not al
[
https://issues.apache.org/jira/browse/KAFKA-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884811#comment-17884811
]
Chia-Chuan Yu commented on KAFKA-17607:
---
Hi, [~davidarthur]
Can I have this one?
cmccabe commented on code in PR #17146:
URL: https://github.com/apache/kafka/pull/17146#discussion_r1776104765
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1065,6 +1065,11 @@ public void
handleCommit(BatchReader reader) {
cmccabe commented on code in PR #17146:
URL: https://github.com/apache/kafka/pull/17146#discussion_r1776104122
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1065,6 +1065,11 @@ public void
handleCommit(BatchReader reader) {
cmccabe commented on code in PR #17146:
URL: https://github.com/apache/kafka/pull/17146#discussion_r1776103853
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1065,6 +1065,11 @@ public void
handleCommit(BatchReader reader) {
[
https://issues.apache.org/jira/browse/KAFKA-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884810#comment-17884810
]
PoAn Yang commented on KAFKA-17614:
---
Hi [~cmccabe], if you're not working on this, may
cmccabe commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776102833
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -732,17 +744,14 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Bro
cmccabe commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776102102
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -732,17 +744,14 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Bro
cmccabe commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776101826
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -732,17 +744,14 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Bro
squah-confluent opened a new pull request, #17277:
URL: https://github.com/apache/kafka/pull/17277
Bring the homogeneous case from ServerSideAssignorBenchmark
to TargetAssignmentBuilderBenchmark.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and imple
Colin McCabe created KAFKA-17611:
Summary: Remove ZK from Kafka 4.0
Key: KAFKA-17611
URL: https://issues.apache.org/jira/browse/KAFKA-17611
Project: Kafka
Issue Type: Task
Reporte
cmccabe opened a new pull request, #17276:
URL: https://github.com/apache/kafka/pull/17276
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
[
https://issues.apache.org/jira/browse/KAFKA-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-17612:
-
Summary: Remove some tests that only apply to ZK mode or migration (was:
Remove some tests that
junrao commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776097413
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buff
junrao commented on code in PR #16443:
URL: https://github.com/apache/kafka/pull/16443#discussion_r1776097413
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java:
##
@@ -82,17 +84,31 @@ public static UpdateFeaturesResponse parse(ByteBuffer
buff
Colin McCabe created KAFKA-17616:
Summary: Remove KafkaServer
Key: KAFKA-17616
URL: https://issues.apache.org/jira/browse/KAFKA-17616
Project: Kafka
Issue Type: Sub-task
Reporter:
Colin McCabe created KAFKA-17615:
Summary: Remove KafkaServer references in tests
Key: KAFKA-17615
URL: https://issues.apache.org/jira/browse/KAFKA-17615
Project: Kafka
Issue Type: Sub-task
Colin McCabe created KAFKA-17613:
Summary: Remove ZK migration code
Key: KAFKA-17613
URL: https://issues.apache.org/jira/browse/KAFKA-17613
Project: Kafka
Issue Type: Sub-task
Rep
m1a2st commented on PR #16381:
URL: https://github.com/apache/kafka/pull/16381#issuecomment-2375431411
@chia7712, @apoorvmittal10, Thanks for your reminder, I will update the Jira
Title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
junrao commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776088538
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -732,17 +744,14 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Brok
1 - 100 of 217 matches
Mail list logo
