cmccabe commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776102102
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -732,17 +744,14 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Brok
override def reconfigure(oldConfig: KafkaConfig, newConfig: KafkaConfig):
Unit = {
val originalLogConfig = logManager.currentDefaultConfig
val originalUncleanLeaderElectionEnable =
originalLogConfig.uncleanLeaderElectionEnable
- val newBrokerDefaults = new util.HashMap[String,
Object](originalLogConfig.originals)
- newConfig.valuesFromThisConfig.forEach { (k, v) =>
- if (DynamicLogConfig.ReconfigurableConfigs.contains(k)) {
- DynamicLogConfig.KafkaConfigToLogConfigName.get(k).foreach {
configName =>
- if (v == null)
- newBrokerDefaults.remove(configName)
- else
- newBrokerDefaults.put(configName, v.asInstanceOf[AnyRef])
- }
+ val newBrokerDefaults = new util.HashMap[String,
Object](newConfig.extractLogConfigMap)
+ val originalLogConfigMap = originalLogConfig.originals()
+ DynamicLogConfig.NonReconfigrableLogConfigs.foreach(k => {
+ Option(originalLogConfigMap.get(k)) match {
+ case None => newBrokerDefaults.remove(k)
+ case Some(v) => newBrokerDefaults.put(k, v)
Review Comment:
Because we want the non-reconfigurable configuration to have the same value
(or lack of value) that it had previously. It should not change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
