showuon commented on code in PR #17258:
URL: https://github.com/apache/kafka/pull/17258#discussion_r1776431850
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -732,17 +732,7 @@ class DynamicLogConfig(logManager: LogManager, server:
KafkaBroker) extends Brok
override def reconfigure(oldConfig: KafkaConfig, newConfig: KafkaConfig):
Unit = {
val originalLogConfig = logManager.currentDefaultConfig
val originalUncleanLeaderElectionEnable =
originalLogConfig.uncleanLeaderElectionEnable
- val newBrokerDefaults = new util.HashMap[String,
Object](originalLogConfig.originals)
- newConfig.valuesFromThisConfig.forEach { (k, v) =>
- if (DynamicLogConfig.ReconfigurableConfigs.contains(k)) {
Review Comment:
Good call @rajinisivaram !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
