Re: [PR] KAFKA-12605 - make GZIP decompression use BufferSupplier [kafka]

2024-01-21 Thread via GitHub
funky-eyes commented on PR #10624: URL: https://github.com/apache/kafka/pull/10624#issuecomment-1903411104 Hi, does this issue cause off-heap memory leak? Our client uses gzip compression, and the off-heap memory can't be reclaimed under high concurrency and heavy traffic, and I suspect tha

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-21 Thread via GitHub
showuon commented on code in PR #15133: URL: https://github.com/apache/kafka/pull/15133#discussion_r1461439023 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -529,20 +564,33 @@ class BrokerTopicMetrics(name: Option[String], configOpt: java.util.Optional[Ka

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-21 Thread via GitHub
showuon commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1461388432 ## docs/ops.html: ## @@ -3992,6 +3980,133 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the cl

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-21 Thread via GitHub
showuon commented on code in PR #15235: URL: https://github.com/apache/kafka/pull/15235#discussion_r1461360949 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -101,6 +101,10 @@ protected LeaderState( * @return the remainingMs before the checkQuorumTimer

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-01-21 Thread via GitHub
github-actions[bot] commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-1903103195 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: KAFKA-15526 followup [kafka]

2024-01-21 Thread via GitHub
github-actions[bot] commented on PR #14485: URL: https://github.com/apache/kafka/pull/14485#issuecomment-1903103104 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Created] (KAFKA-16181) Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-21 Thread Deng Ziming (Jira)
Deng Ziming created KAFKA-16181: --- Summary: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh Key: KAFKA-16181 URL: https://issues.apache.org/jira/browse/KAFKA-16181 Project: K

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-21 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1461110485 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1461065097 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return matchPattern;

[jira] [Commented] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2024-01-21 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809148#comment-17809148 ] Jorge Esteban Quilcate Otoya commented on KAFKA-15931: -- [~satish.du

[PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2024-01-21 Thread via GitHub
jeqo opened a new pull request, #15241: URL: https://github.com/apache/kafka/pull/15241 Cached TransactionIndex may get closed if interrupted, causing following calls to always fail with ClosedChannelException, and forcing process to be restarted. In order to avoid this issue, a new method

[jira] [Assigned] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2024-01-21 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-15931: Assignee: Jorge Esteban Quilcate Otoya > Cached transacti

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1461010891 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java: ## @@ -38,6 +39,7 @@ public class ClientMetricsInstance { private long l

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1461010437 ## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ## @@ -919,4 +922,101 @@ public void testPushTelemetryConcurrentRequestAfterSubsc

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1460972479 ## server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java: ## @@ -14,10 +14,11 @@ * See the License for the specific languag

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1460971499 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -253,10 +266,18 @@ private ClientMetricsInstance clientInstance(Uuid clientInst

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-21 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1460970956 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java: ## @@ -38,6 +39,7 @@ public class ClientMetricsInstance { private long l

[jira] [Commented] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809117#comment-17809117 ] Kamal Chandraprakash commented on KAFKA-15776: -- > I think having to configu

[jira] [Commented] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809116#comment-17809116 ] Kamal Chandraprakash commented on KAFKA-15776: -- [~fvisconte]  We are cance

Re: [PR] KAFKA-15094: RemoteIndexCache stats [kafka]

2024-01-21 Thread via GitHub
kamalcph commented on PR #14073: URL: https://github.com/apache/kafka/pull/14073#issuecomment-1902635518 @abhijeetk88 Are these metrics proposed in the KIP? I don't see them on the below KIPs: 1. [KIP-930](https://cwiki.apache.org/confluence/display/KAFKA/KIP-930%3A+Rename+amb

Re: [PR] KAFKA-16073: [Tiered] Update localLogStartOffset before deleting segments in memory t… [kafka]

2024-01-21 Thread via GitHub
kamalcph commented on PR #15141: URL: https://github.com/apache/kafka/pull/15141#issuecomment-1902633822 @hzh0425 Could you please address the review comments? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] MINOR Removed unused CommittedOffsetsFile class. [kafka]

2024-01-21 Thread via GitHub
kamalcph commented on PR #15209: URL: https://github.com/apache/kafka/pull/15209#issuecomment-1902632941 > Task :core:compileTestScala FAILED Please fix the test compilation failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on