apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1461010891
########## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java: ########## @@ -38,6 +39,7 @@ public class ClientMetricsInstance { private long lastPushRequestTimestamp; private volatile boolean terminating; private volatile Errors lastKnownError; + private TimerTask expirationTimerTask; Review Comment: Though I moved the getter as synchronised as well so we do not have an issue in future if someone starts using the getter method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org