showuon commented on code in PR #15133:
URL: https://github.com/apache/kafka/pull/15133#discussion_r1461439023
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -529,20 +564,33 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
}
}
-class BrokerTopicAggregatedMetric() {
+class BrokerTopicAggregatedMetric(allTopics: Boolean = false) {
private val partitionMetricValues = new ConcurrentHashMap[Int, Long]()
+ private val topicMetricValues = new ConcurrentHashMap[String, Long]()
def setPartitionMetricValue(partition: Int, partitionValue: Long): Unit = {
partitionMetricValues.put(partition, partitionValue)
}
+ def setTopicMetricValue(topic: String, topicValue: Long): Unit = {
Review Comment:
Ah, I know what you mean now. Give me some time to fix it. Thanks for
pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
