[GitHub] [kafka] gitlw commented on pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

gitlw commented on PR #12029: URL: https://github.com/apache/kafka/pull/12029#issuecomment-1107367652 @dajac In the new test `UnifiedLogTest.testRenamingDirWithoutReinitialization`, after renaming a log's dir without re-initialization, I added logic to trigger `UnifiedLog.appendAsLeader`,

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r856845305 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2703,6 +2711,26 @@ class ReplicaManagerTest { assertEquals(HostedPartition.None, replicaMa

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r856845084 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -306,24 +306,27 @@ class UnifiedLog(@volatile var logStartOffset: Long, * - Otherwise set _topicId to None

[GitHub] [kafka] dajac commented on a diff in pull request #12089: MINOR: Rename `AlterIsrManager` to `AlterPartitionManager`

dajac commented on code in PR #12089: URL: https://github.com/apache/kafka/pull/12089#discussion_r856832341 ## core/src/main/scala/kafka/server/AlterPartitionManager.scala: ## @@ -61,12 +61,14 @@ trait AlterIsrManager { ): CompletableFuture[LeaderAndIsr] } -case class Alte

[jira] [Assigned] (KAFKA-13850) kafka-metadata-shell is missing some record types

[ https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13850: -- Assignee: dengziming > kafka-metadata-shell is missing some record types > --

[jira] [Comment Edited] (KAFKA-13850) kafka-metadata-shell is missing some record types

[ https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526750#comment-17526750 ] David Arthur edited comment on KAFKA-13850 at 4/23/22 2:25 AM: ---

[jira] [Commented] (KAFKA-13850) kafka-metadata-shell is missing some record types

[ https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526750#comment-17526750 ] David Arthur commented on KAFKA-13850: -- Awesome! Good to know [~dengziming]. I'll a

[jira] [Commented] (KAFKA-13850) kafka-metadata-shell is missing some record types

[ https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526746#comment-17526746 ] dengziming commented on KAFKA-13850: In fact I already found this problem, however,

[GitHub] [kafka] dengziming commented on a diff in pull request #11732: MINOR: enable KRaft in ConfigCommandTest

dengziming commented on code in PR #11732: URL: https://github.com/apache/kafka/pull/11732#discussion_r856750503 ## core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala: ## @@ -26,15 +26,17 @@ import org.apache.kafka.common.config.ConfigException impor

[GitHub] [kafka] dengziming commented on a diff in pull request #12089: MINOR: Rename `AlterIsrManager` to `AlterPartitionManager`

dengziming commented on code in PR #12089: URL: https://github.com/apache/kafka/pull/12089#discussion_r856745253 ## core/src/test/scala/unit/kafka/cluster/AbstractPartitionTest.scala: ## @@ -49,7 +49,7 @@ class AbstractPartitionTest { var logDir1: File = _ var logDir2: Fil

[GitHub] [kafka] dengziming commented on a diff in pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

dengziming commented on code in PR #11951: URL: https://github.com/apache/kafka/pull/11951#discussion_r856745020 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig, } private def

[jira] [Resolved] (KAFKA-13398) The caller program will be shut down directly when the execution of Kafka script is abnormal

[ https://issues.apache.org/jira/browse/KAFKA-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun resolved KAFKA-13398. -- Resolution: Not A Problem > The caller program will be shut down directly when the execution of Kafka

[GitHub] [kafka] ddrid commented on pull request #12080: KAFKA-13843: Fix incorrect transactionManager state when receiving success response on an expired batch

ddrid commented on PR #12080: URL: https://github.com/apache/kafka/pull/12080#issuecomment-1107097330 @hachikuji hi, could you help review this bug fix？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] jsancio commented on a diff in pull request #11732: MINOR: enable KRaft in ConfigCommandTest

jsancio commented on code in PR #11732: URL: https://github.com/apache/kafka/pull/11732#discussion_r856668003 ## core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala: ## @@ -43,8 +45,9 @@ class ConfigCommandIntegrationTest extends QuorumTestHarness wit

[GitHub] [kafka] jsancio commented on a diff in pull request #12032: MINOR: Change validation `AlterPartition` validation order in `KafkaController`

jsancio commented on code in PR #12032: URL: https://github.com/apache/kafka/pull/12032#discussion_r856654851 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -890,65 +890,289 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12032: MINOR: Change validation `AlterPartition` validation order in `KafkaController`

hachikuji commented on code in PR #12032: URL: https://github.com/apache/kafka/pull/12032#discussion_r856620950 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -2348,7 +2348,20 @@ class KafkaController(val config: KafkaConfig, controllerContext.pa

[GitHub] [kafka] hachikuji commented on a diff in pull request #12032: MINOR: Change validation `AlterPartition` validation order in `KafkaController`

hachikuji commented on code in PR #12032: URL: https://github.com/apache/kafka/pull/12032#discussion_r856620950 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -2348,7 +2348,20 @@ class KafkaController(val config: KafkaConfig, controllerContext.pa

[GitHub] [kafka] hachikuji opened a new pull request, #12089: MINOR: Rename `AlterIsrManager` to `AlterPartitionManager`

hachikuji opened a new pull request, #12089: URL: https://github.com/apache/kafka/pull/12089 Since we have changed the `AlterIsr` API to `AlterPartition`, it makes sense to rename `AlterIsrManager` as well. ### Committer Checklist (excluded from commit message) - [ ] Verify design

[GitHub] [kafka] hachikuji commented on a diff in pull request #12081: MINOR: Refactor `kafka.cluster.Replica`

hachikuji commented on code in PR #12081: URL: https://github.com/apache/kafka/pull/12081#discussion_r856597477 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -885,15 +885,18 @@ class Partition(val topicPartition: TopicPartition, * * @return true if the HW w

[GitHub] [kafka] hachikuji commented on a diff in pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

hachikuji commented on code in PR #11951: URL: https://github.com/apache/kafka/pull/11951#discussion_r856590248 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig, } private def s

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

artemlivshits commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r856590081 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPa

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: [WIP] KRaft upgrade - MetadataVersion

ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r856573612 ## core/src/test/scala/unit/kafka/api/ApiVersionTest.scala: ## @@ -184,6 +184,37 @@ class ApiVersionTest { assertEquals("3.2", KAFKA_3_2_IV0.shortVersion) } +

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12049: KAFKA-10888: Sticky partition leads to uneven produce msg

artemlivshits commented on code in PR #12049: URL: https://github.com/apache/kafka/pull/12049#discussion_r855698824 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1321,21 +1339,30 @@ private ClusterResourceListeners configureClusterResourc

[GitHub] [kafka] philipnee commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

philipnee commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1106836089 Hey @junrao - I think I rebased it onto the wrong head. It seems fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: [WIP] KRaft upgrade - MetadataVersion

mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r856529766 ## core/src/test/scala/unit/kafka/api/ApiVersionTest.scala: ## @@ -184,6 +184,37 @@ class ApiVersionTest { assertEquals("3.2", KAFKA_3_2_IV0.shortVersion) } +

[GitHub] [kafka] dajac merged pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

dajac merged PR #12071: URL: https://github.com/apache/kafka/pull/12071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] philipnee opened a new pull request, #12088: KAFKA-12841 bug fix and tests

philipnee opened a new pull request, #12088: URL: https://github.com/apache/kafka/pull/12088 Duplicated to https://github.com/apache/kafka/pull/12064 - but the tests aren't being fired up there. So created this PR to trigger the tests. The bug was introduced in https://github.com/apache/k

[GitHub] [kafka] ArvinZheng closed pull request #11840: KAFKA-13707: unify the naming convention of in-flight

ArvinZheng closed pull request #11840: KAFKA-13707: unify the naming convention of in-flight URL: https://github.com/apache/kafka/pull/11840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Assigned] (KAFKA-13848) Clients remain connected after SASL re-authentication fails

[ https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Csaki reassigned KAFKA-13848: Assignee: Andras Csaki > Clients remain connected after SASL re-authentication fails > --

[GitHub] [kafka] divijvaidya opened a new pull request, #12087: KAFKA-13851: Add integration tests for DeleteRecords API

divijvaidya opened a new pull request, #12087: URL: https://github.com/apache/kafka/pull/12087 ## Changes Added integration tests to test the DeleteRecords API for the following scenarios: 1. Happy case when the records are deleted 2. Error case when an invalid topic is provided

[jira] [Created] (KAFKA-13851) Tests are missing for DeleteRecords API

Divij Vaidya created KAFKA-13851: Summary: Tests are missing for DeleteRecords API Key: KAFKA-13851 URL: https://issues.apache.org/jira/browse/KAFKA-13851 Project: Kafka Issue Type: Improveme

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: [WIP] KRaft upgrade - MetadataVersion

ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r856374878 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] nicolasguyomar opened a new pull request, #12086: Minor : cleanup.policy is a comma separated list

nicolasguyomar opened a new pull request, #12086: URL: https://github.com/apache/kafka/pull/12086 Minor doc improvement ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify do

[GitHub] [kafka] dajac opened a new pull request, #12085: KAFKA-13790; ReplicaManager should be robust to all partition updates from kraft metadata log

dajac opened a new pull request, #12085: URL: https://github.com/apache/kafka/pull/12085 This PR sits on top of https://github.com/apache/kafka/pull/12071 and https://github.com/apache/kafka/pull/12081. They should be merged before proceeding with this one. WIP - Opening it to get th

[jira] [Assigned] (KAFKA-13620) The request handler metric name for ControllerApis should be different than KafkaApis

[ https://issues.apache.org/jira/browse/KAFKA-13620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13620: -- Assignee: dengziming > The request handler metric name for ControllerApis should be different

[GitHub] [kafka] dajac commented on a diff in pull request #12081: MINOR: Refactor `kafka.cluster.Replica`

dajac commented on code in PR #12081: URL: https://github.com/apache/kafka/pull/12081#discussion_r856260128 ## core/src/test/scala/unit/kafka/cluster/LogTest.scala: ## @@ -0,0 +1,132 @@ +/* Review Comment: I have renamed this file. Those tests have nothing to do with the Rep

[jira] [Created] (KAFKA-13850) kafka-metadata-shell is missing some record types

David Arthur created KAFKA-13850: Summary: kafka-metadata-shell is missing some record types Key: KAFKA-13850 URL: https://issues.apache.org/jira/browse/KAFKA-13850 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-13849) All topics whose cleanup policy contains `compact` are not executing deleteLogStartOffsetBreachedSegments as expected

[ https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526443#comment-17526443 ] RivenSun commented on KAFKA-13849: -- After reading the code carefully, I found that the

[jira] [Resolved] (KAFKA-13849) All topics whose cleanup policy contains `compact` are not executing deleteLogStartOffsetBreachedSegments as expected

[ https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun resolved KAFKA-13849. -- Resolution: Not A Bug > All topics whose cleanup policy contains `compact` are not executing > delet

[GitHub] [kafka] mumrah commented on pull request #12050: KAFKA-13830 Introduce metadata.version for KRaft

mumrah commented on PR #12050: URL: https://github.com/apache/kafka/pull/12050#issuecomment-1106518486 @dengziming @cmccabe FYI, there is another PR coming soon which includes a big consolidation of ApiVersion and MetadataVersion. I will wait to merge this one until that one is done. --

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: [WIP] KRaft upgrade - MetadataVersion

mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r856220444 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856218757 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856214743 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856213267 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856211769 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856210085 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856198705 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[jira] [Commented] (KAFKA-13849) All topics whose cleanup policy contains `compact` are not executing deleteLogStartOffsetBreachedSegments as expected

[ https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526409#comment-17526409 ] RivenSun commented on KAFKA-13849: -- Hi [~guozhang]  [~hachikuji]  , [~showuon] Could yo

[jira] [Created] (KAFKA-13849) All topics whose cleanup policy contains `compact` are not executing deleteLogStartOffsetBreachedSegments as expected

RivenSun created KAFKA-13849: Summary: All topics whose cleanup policy contains `compact` are not executing deleteLogStartOffsetBreachedSegments as expected Key: KAFKA-13849 URL: https://issues.apache.org/jira/browse

[jira] [Updated] (KAFKA-13848) Clients remain connected after SASL re-authentication fails

[ https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Csaki updated KAFKA-13848: - Summary: Clients remain connected after SASL re-authentication fails (was: Clients remaining co

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r855922918 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -331,7 +331,7 @@ public class KafkaAdminClient extends AdminClient { /**

[jira] [Updated] (KAFKA-13848) Clients remaining connected after SASL re-authentication fails

[ https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Csaki updated KAFKA-13848: - Summary: Clients remaining connected after SASL re-authentication fails (was: Clients remaing c

[jira] [Commented] (KAFKA-13848) Clients remaing connected after SASL re-authentication fails

[ https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526248#comment-17526248 ] Andras Csaki commented on KAFKA-13848: -- Please assign this to me. My fix is underw

[GitHub] [kafka] dengziming opened a new pull request, #12084: KAFKA-13845: Add support for reading KRaft snapshots in kafka-dump-log

dengziming opened a new pull request, #12084: URL: https://github.com/apache/kafka/pull/12084 *More detailed description of your change* 1. Support metadata snapshot suffix ".checkpoint" 2. print metadata snapshot header and footer *Summary of testing strategy (including rat

[jira] [Created] (KAFKA-13848) Clients remaing connected after SASL re-authentication fails

Andras Csaki created KAFKA-13848: Summary: Clients remaing connected after SASL re-authentication fails Key: KAFKA-13848 URL: https://issues.apache.org/jira/browse/KAFKA-13848 Project: Kafka

[jira] [Assigned] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13845: -- Assignee: dengziming > Add support for reading KRaft snapshots in kafka-dump-log > --

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855843521 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand { CommonClientConfigs.SECURITY_PROTOC

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855836217 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1139,7 +1139,7 @@ object KafkaConfig { .define(MetadataMaxRetentionMillisProp, LONG, Defaults.LogRete