[jira] [Updated] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-25 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Description: 可多次用错误的密码进行访问,没有防暴力破解的 功能: when kafka-server's properties is setted sasl.mechanism.in

[jira] [Updated] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-25 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Description: 可多次用错误的密码进行访问,没有防暴力破解的 功能: when kafka-server's properties is setted sasl.mechanism.in

[jira] [Updated] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-25 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Description: 可多次用错误的密码进行访问,没有防暴力破解的 功能: when kafka-server's properties is setted sasl.mechanism.in

[jira] [Commented] (KAFKA-12987) kafka用户无密码防暴力破解功能

2021-06-25 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369824#comment-17369824 ] chenzongyi commented on KAFKA-12987: refresh > kafka用户无密码防暴力破解功能 >

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369794#comment-17369794 ] ASF GitHub Bot commented on KAFKA-12993: ableegoldman commented on pull request

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-25 Thread GitBox
skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r659104126 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -40,7 +43,11 @@ * individual deletion

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369781#comment-17369781 ] ASF GitHub Bot commented on KAFKA-12993: showuon commented on a change in pull r

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369782#comment-17369782 ] ASF GitHub Bot commented on KAFKA-12993: showuon commented on pull request #361:

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-25 Thread GitBox
skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r659102319 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java ## @@ -24,7 +24,7 @@ public final String idVal

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659095900 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +158,14 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659097305 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +158,14 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] ableegoldman commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2021-06-25 Thread GitBox
ableegoldman commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-868900284 I completely agree that these are too frequent to warrant even being at INFO, however it's unfortunate to lose this information entirely as @showuon pointed out. Can we sti

[GitHub] [kafka] cmccabe opened a new pull request #10931: KAFKA-12998: Implement broker-side KRaft snapshots (WIP)

2021-06-25 Thread GitBox
cmccabe opened a new pull request #10931: URL: https://github.com/apache/kafka/pull/10931 This PR implements broker-side KRaft snapshots, including both saving and loading. The code for triggering a periodic broker-side snapshot will come in a follow-on PR. Loading should work with ju

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659096284 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +158,14 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659095900 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +158,14 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659094924 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659094924 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659094718 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659094582 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -106,7 +158,14 @@ object LogLoader extends Logging { loadSegmentFiles(params)

[jira] [Created] (KAFKA-12998) Implement broker snapshots

2021-06-25 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12998: Summary: Implement broker snapshots Key: KAFKA-12998 URL: https://issues.apache.org/jira/browse/KAFKA-12998 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659093901 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[jira] [Commented] (KAFKA-9177) Pause completed partitions on restore consumer

2021-06-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369771#comment-17369771 ] A. Sophie Blee-Goldman commented on KAFKA-9177: --- [~apolyakov] this ticket w

[GitHub] [kafka] jsancio commented on pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on pull request #10812: URL: https://github.com/apache/kafka/pull/10812#issuecomment-868894446 > I realize this is a bit messy to test, but it would be good to have a test that the QuorumController really did trigger a snapshot after X bytes of records were added to the l

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091562 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -367,6 +435,36 @@ private void checkSnapshotContents(

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091527 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -282,7 +285,71 @@ public void testSnapshotSaveAndLoad()

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091491 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -269,7 +269,10 @@ public void testSnapshotSaveAndLoad()

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091444 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -374,6 +375,7 @@ object KafkaConfig { val BrokerSessionTimeoutMsProp = "broker.s

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

2021-06-25 Thread GitBox
jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091359 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] cmccabe merged pull request #10927: MINOR: add MockConfigRepository

2021-06-25 Thread GitBox
cmccabe merged pull request #10927: URL: https://github.com/apache/kafka/pull/10927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369758#comment-17369758 ] A. Sophie Blee-Goldman commented on KAFKA-12993: Oh, you already have a

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369757#comment-17369757 ] ASF GitHub Bot commented on KAFKA-12993: ableegoldman commented on pull request

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369756#comment-17369756 ] A. Sophie Blee-Goldman commented on KAFKA-12993: Ah, I didn't realize th

[GitHub] [kafka] showuon commented on pull request #10928: KAFKA-12993: fix memory-mgmt.html

2021-06-25 Thread GitBox
showuon commented on pull request #10928: URL: https://github.com/apache/kafka/pull/10928#issuecomment-868871415 Please ignore this PR. I was wrong about the code tag. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] showuon closed pull request #10928: KAFKA-12993: fix memory-mgmt.html

2021-06-25 Thread GitBox
showuon closed pull request #10928: URL: https://github.com/apache/kafka/pull/10928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-25 Thread GitBox
IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-868867986 Encounter and error on compileTestScala, so change `endOffsets.view.filterKeys(assignedTopicPartitions.contains).toMap.asJava` to `endOffsets.filter{ case (

[jira] [Updated] (KAFKA-12997) Expose log record append time to the controller/broker

2021-06-25 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-12997: --- Priority: Minor (was: Major) > Expose log record append time to the controller/broker > ---

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

2021-06-25 Thread GitBox
niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r659060915 ## File path: clients/src/main/resources/common/message/SnapshotHeaderRecord.json ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (A

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-06-25 Thread amuthan Ganeshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369720#comment-17369720 ] amuthan Ganeshan commented on KAFKA-12559: -- [~msundeq] ya go for it, let me kno

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-25 Thread GitBox
IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-868855492 Some compileTestScala Error arised. Looking on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] junrao commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-06-25 Thread GitBox
junrao commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659056491 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r659051878 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-25 Thread GitBox
IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-868844354 Hi @dajac, thanks again for review and support. Made some changes to the PR taking them into account. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r659040080 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] cmccabe commented on a change in pull request #10927: MINOR: add MockConfigRepository

2021-06-25 Thread GitBox
cmccabe commented on a change in pull request #10927: URL: https://github.com/apache/kafka/pull/10927#discussion_r659043629 ## File path: core/src/test/scala/unit/kafka/server/metadata/MockConfigRepositoryTest.scala ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10927: MINOR: add MockConfigRepository

2021-06-25 Thread GitBox
cmccabe commented on a change in pull request #10927: URL: https://github.com/apache/kafka/pull/10927#discussion_r659042611 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -564,7 +563,7 @@ class LogManagerTest { @Test def testBrokerConfigChange

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r659039997 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[jira] [Assigned] (KAFKA-12997) Expose log record append time to the controller/broker

2021-06-25 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12997: -- Assignee: Jose Armando Garcia Sancio > Expose log record appe

[jira] [Created] (KAFKA-12997) Expose log record append time to the controller/broker

2021-06-25 Thread Niket Goel (Jira)
Niket Goel created KAFKA-12997: -- Summary: Expose log record append time to the controller/broker Key: KAFKA-12997 URL: https://issues.apache.org/jira/browse/KAFKA-12997 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-12952) Metadata Snapshot File Delimiters

2021-06-25 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-12952: --- Description: Create new Control Records that will serve as the header and footer for a Metadata Sna

[jira] [Updated] (KAFKA-12952) Metadata Snapshot File Delimiters

2021-06-25 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-12952: --- Labels: kip-500 (was: ) > Metadata Snapshot File Delimiters > - > >

[GitHub] [kafka] mumrah commented on a change in pull request #10927: MINOR: add MockConfigRepository

2021-06-25 Thread GitBox
mumrah commented on a change in pull request #10927: URL: https://github.com/apache/kafka/pull/10927#discussion_r659005600 ## File path: core/src/test/scala/unit/kafka/server/metadata/MockConfigRepositoryTest.scala ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software F

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-25 Thread GitBox
dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658996808 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify(admin,

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-25 Thread GitBox
dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658995349 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify(admin,

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658995018 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658993775 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658978444 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-25 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r658978444 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +62,84 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] spena commented on a change in pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

2021-06-25 Thread GitBox
spena commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r658928595 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -186,12 +190,17 @@ public void process(final K

[GitHub] [kafka] rajinisivaram opened a new pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

2021-06-25 Thread GitBox
rajinisivaram opened a new pull request #10930: URL: https://github.com/apache/kafka/pull/10930 If fetchOffset < startOffset, we currently throw OffsetOutOfRangeException when attempting to read from the log in the regular case. But for diverging epochs, we return Errors.NONE with the new

[jira] [Assigned] (KAFKA-10819) The freeze operation should validate the content of the snapshot

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-10819: --- Assignee: HaiyuanZhao > The freeze operation should validate the content of the snapshot >

[jira] [Created] (KAFKA-12996) OffsetOutOfRange not handled correctly for diverging epochs when fetch offset less than leader start offset

2021-06-25 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-12996: -- Summary: OffsetOutOfRange not handled correctly for diverging epochs when fetch offset less than leader start offset Key: KAFKA-12996 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (KAFKA-10819) The freeze operation should validate the content of the snapshot

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369610#comment-17369610 ] HaiyuanZhao commented on KAFKA-10819: - Hi, [~jagsancio] I would like to take this i

[jira] [Comment Edited] (KAFKA-10884) Limit the size of Fetch and FetchSnapshot response based on broker configuration

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369437#comment-17369437 ] HaiyuanZhao edited comment on KAFKA-10884 at 6/25/21, 5:21 PM: ---

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-868693590 Thanks a lot @cadonna and @ableegoldman for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] rondagostino commented on pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

2021-06-25 Thread GitBox
rondagostino commented on pull request #10918: URL: https://github.com/apache/kafka/pull/10918#issuecomment-868693454 I've reverted the change that made the `io.dropwizard.metrics:metrics-core` library a test-only dependency due to packaging concerns -- would it be included in the release,

[GitHub] [kafka] thomaskwscott commented on pull request #10748: MINOR: Add missing apiversion test for 3.0

2021-06-25 Thread GitBox
thomaskwscott commented on pull request #10748: URL: https://github.com/apache/kafka/pull/10748#issuecomment-868689620 > I also find #10760 bumped the IBP to V3.0.1 but forgot to add a test for it. ping @thomaskwscott @dajac to have a look. thanks for the catch @dengziming, lgtm --

[GitHub] [kafka] cadonna merged pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
cadonna merged pull request #10840: URL: https://github.com/apache/kafka/pull/10840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
cadonna commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-868685809 The test failures are unrelated and known to be flaky: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, us

[GitHub] [kafka] xdgrulez commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2021-06-25 Thread GitBox
xdgrulez commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-868681639 > @showuon I think one of the reasons to use `DEBUG` is no decrease the log messages which woiuld not be the case with `INFO`. Absolutely - we had a big influx of these W

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-868680664 It seems that the test failures were RaftClusterTest and SslTransportLayerTest ones. Both groups being known flaky ones AFAIU. -- This is an automated message from the Apache G

[GitHub] [kafka] cadonna commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2021-06-25 Thread GitBox
cadonna commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-868663085 @showuon I think one of the reasons to use `DEBUG` is no decrease the log messages which woiuld not be the case with `INFO`. -- This is an automated message from the Apache Gi

[GitHub] [kafka] cadonna commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
cadonna commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-868661683 I am just waiting for the builds to finish and then I will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] svudutala commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-06-25 Thread GitBox
svudutala commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-868564730 @dongjinleekr Thanks for all the effort on this feature. Do you have a target ETA on this to be merged? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] tombentley commented on a change in pull request #10221: KAFKA-12379: Allow configuring the location of the offset-syncs topic…

2021-06-25 Thread GitBox
tombentley commented on a change in pull request #10221: URL: https://github.com/apache/kafka/pull/10221#discussion_r658822455 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java ## @@ -262,4 +264,65 @@ public void testTarg

[GitHub] [kafka] mimaison commented on a change in pull request #10221: KAFKA-12379: Allow configuring the location of the offset-syncs topic…

2021-06-25 Thread GitBox
mimaison commented on a change in pull request #10221: URL: https://github.com/apache/kafka/pull/10221#discussion_r658821310 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java ## @@ -262,4 +264,65 @@ public void testTarget

[GitHub] [kafka] dengziming commented on pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver

2021-06-25 Thread GitBox
dengziming commented on pull request #10467: URL: https://github.com/apache/kafka/pull/10467#issuecomment-868551740 Thank you @dajac I will check #10760 soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] dajac commented on pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver

2021-06-25 Thread GitBox
dajac commented on pull request #10467: URL: https://github.com/apache/kafka/pull/10467#issuecomment-868550485 @dengziming Sorry for the delay on this one. I wanted to get https://github.com/apache/kafka/pull/10760 merge first before tackling this one. Could you rebase your PR to include t

[jira] [Assigned] (KAFKA-12873) Log truncation due to divergence should also remove snapshots

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-12873: --- Assignee: HaiyuanZhao > Log truncation due to divergence should also remove snapshots > ---

[jira] [Commented] (KAFKA-12873) Log truncation due to divergence should also remove snapshots

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369489#comment-17369489 ] HaiyuanZhao commented on KAFKA-12873: - Hi, [~jagsancio] I would like to take this i

[jira] [Commented] (KAFKA-12995) AdminClient listOffsets fail with old Kafka Broker

2021-06-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369479#comment-17369479 ] Alan Artigao Carreño commented on KAFKA-12995: -- I've created a PR [#10929|h

[GitHub] [kafka] aartigao opened a new pull request #10929: KAFKA-12995 [WIP] Allow old Broker compatibility for Metadata calls

2021-06-25 Thread GitBox
aartigao opened a new pull request #10929: URL: https://github.com/apache/kafka/pull/10929 Old Brokers prior to Metadata V4 don't support the allowAutoTopicCreation field. The implementation of #3098 introduced a check for old Brokers compatibility falling back to _*true*_ in *Metad

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-868513219 @cadonna accepted your suggestions. Thanks a bunch!a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-12995) AdminClient listOffsets fail with old Kafka Broker

2021-06-25 Thread Jira
Alan Artigao Carreño created KAFKA-12995: Summary: AdminClient listOffsets fail with old Kafka Broker Key: KAFKA-12995 URL: https://issues.apache.org/jira/browse/KAFKA-12995 Project: Kafka

[GitHub] [kafka] dengziming commented on pull request #10748: MINOR: Add missing apiversion test for 3.0

2021-06-25 Thread GitBox
dengziming commented on pull request #10748: URL: https://github.com/apache/kafka/pull/10748#issuecomment-868504153 I also find #10760 bumped the IBP to V3.0.1 but forgot to add a test for it. ping @thomaskwscott @dajac to have a look. -- This is an automated message from the Apache Git

[GitHub] [kafka] cadonna commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

2021-06-25 Thread GitBox
cadonna commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r658722233 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsMetadata.java ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369459#comment-17369459 ] Luke Chen edited comment on KAFKA-12993 at 6/25/21, 1:14 PM: -

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369459#comment-17369459 ] Luke Chen commented on KAFKA-12993: --- [~cadonna], yes, I know this is been done by [ht

[jira] [Comment Edited] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369454#comment-17369454 ] Bruno Cadonna edited comment on KAFKA-12993 at 6/25/21, 1:01 PM: -

[jira] [Comment Edited] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369454#comment-17369454 ] Bruno Cadonna edited comment on KAFKA-12993 at 6/25/21, 1:00 PM: -

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369454#comment-17369454 ] Bruno Cadonna commented on KAFKA-12993: --- I thinkthis has already been done by htt

[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369452#comment-17369452 ] ASF GitHub Bot commented on KAFKA-12993: cadonna commented on pull request #361:

[GitHub] [kafka] vanhoale removed a comment on pull request #10239: KAFKA-12372: Enhance TimestampCoverter Connect transformation to handle multiple timestamp or date fields

2021-06-25 Thread GitBox
vanhoale removed a comment on pull request #10239: URL: https://github.com/apache/kafka/pull/10239#issuecomment-789110876 I ran my test, checkstyle and spotbugs successful at my local, but not sure some checks failed here -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] vanhoale removed a comment on pull request #10239: KAFKA-12372: Enhance TimestampCoverter Connect transformation to handle multiple timestamp or date fields

2021-06-25 Thread GitBox
vanhoale removed a comment on pull request #10239: URL: https://github.com/apache/kafka/pull/10239#issuecomment-802059907 hi @kkonstantine, should one of your team members review the PR? we want to use this feature ASAP -- This is an automated message from the Apache Git Service. To res

[jira] [Resolved] (KAFKA-12541) Extend ListOffset to fetch offset with max timestamp (KIP-734)

2021-06-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12541. - Reviewer: David Jacot Resolution: Fixed > Extend ListOffset to fetch offset with max times

[jira] [Updated] (KAFKA-12541) Extend ListOffset to fetch offset with max timestamp (KIP-734)

2021-06-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12541: Summary: Extend ListOffset to fetch offset with max timestamp (KIP-734) (was: AdminClient.listOff

[GitHub] [kafka] dajac merged pull request #10760: KAFKA-12541; Extend ListOffset to fetch offset with max timestamp (KIP-734)

2021-06-25 Thread GitBox
dajac merged pull request #10760: URL: https://github.com/apache/kafka/pull/10760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] dajac commented on pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-25 Thread GitBox
dajac commented on pull request #10760: URL: https://github.com/apache/kafka/pull/10760#issuecomment-868463282 Failures are not related: ``` Build / JDK 16 and Scala 2.13 / kafka.server.ReplicationQuotasTest.shouldThrottleOldSegments() Build / JDK 16 and Scala 2.13 / org.apache.ka

[jira] [Commented] (KAFKA-12958) Add simulation invariant for leadership and snapshot

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369439#comment-17369439 ] HaiyuanZhao commented on KAFKA-12958: - Hi, [~jagsancio] I would like to take this i

[jira] [Assigned] (KAFKA-12958) Add simulation invariant for leadership and snapshot

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-12958: --- Assignee: HaiyuanZhao > Add simulation invariant for leadership and snapshot >

[jira] [Commented] (KAFKA-10884) Limit the size of Fetch and FetchSnapshot response based on broker configuration

2021-06-25 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369437#comment-17369437 ] HaiyuanZhao commented on KAFKA-10884: - Hi, [~jagsancio] I would like to take this i

  1   2   >