jsancio commented on pull request #10812: URL: https://github.com/apache/kafka/pull/10812#issuecomment-868894446
> I realize this is a bit messy to test, but it would be good to have a test that the QuorumController really did trigger a snapshot after X bytes of records were added to the log. > >One way to do it would be to just keep doing some operation or set of operations. For example, you could keep setting and clearing the same configuration key over and over. If you set a relatively low threshold (like 10,000 bytes or something) you should hit it quickly. Okay. I added a test for this called `testSnapshotOnlyAfterConfiguredMinBytes` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org