skaundinya15 commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r659102319
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##########
@@ -24,7 +24,7 @@
public final String idValue;
Review comment:
@dajac Ah I see the issue now, you're right - we don't need to return
`CoordinatorKey` as part of the result. I was mistaken here - we can just keep
the original method signature and convert the internal `CoordinatorKey` mapping
to the `String` group id. Apologies for the confusion, the way that @mimaison
has it here works just fine, I'll use a similar approach when implementing
KIP-709.
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##########
@@ -24,7 +24,7 @@
public final String idValue;
Review comment:
@mimaison @dajac Ah I see the issue now, you're right - we don't need to
return `CoordinatorKey` as part of the result. I was mistaken here - we can
just keep the original method signature and convert the internal
`CoordinatorKey` mapping to the `String` group id. Apologies for the confusion,
the way that @mimaison has it here works just fine, I'll use a similar approach
when implementing KIP-709.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
