mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644511461
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##
@@ -319,7 +321,7 @@ public void setRecordMet
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644510969
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/NamedCacheTest.java
##
@@ -43,16 +43,12 @@
private final Headers header
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644510969
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/NamedCacheTest.java
##
@@ -43,16 +43,12 @@
private final Headers header
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644510383
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorRecordContext.java
##
@@ -43,12 +43,11 @@ public ProcessorRecordC
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644509797
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration i
mjsax commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r644508311
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java
##
@@ -75,14 +75,21 @@
void init(final ProcessorCont
mjsax opened a new pull request #10810:
URL: https://github.com/apache/kafka/pull/10810
Follow up to #10731
I am not totally happy with this PR yet, and we might need to descope or
split it up. While working on the PR, I figured that headers should actually
never be `null` but I am
mjsax commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r644507242
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java
##
@@ -158,7 +158,11 @@ public void init(final Pr
abbccdda opened a new pull request #10809:
URL: https://github.com/apache/kafka/pull/10809
As title suggested, made some style fixes to the class `KafkaRaftClient`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
mjsax commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-853547323
Thanks @vitojeng! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mjsax merged pull request #10668:
URL: https://github.com/apache/kafka/pull/10668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356149#comment-17356149
]
Matthias J. Sax commented on KAFKA-12629:
-
Sweet!
Failed again:
[https://githu
saddays commented on pull request #10781:
URL: https://github.com/apache/kafka/pull/10781#issuecomment-853546556
> I don't think this is correct, since we are verifying the node
authentication status after request being disconnected. Do you recall the
reasoning for calling this API like th
[
https://issues.apache.org/jira/browse/KAFKA-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12883:
---
Labels: StarterProject newbie++ (was: StarterProject streams)
> Adress KIP-
[
https://issues.apache.org/jira/browse/KAFKA-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12883:
---
Component/s: streams
> Adress KIP-100 type constraints now that Java 7 suppo
Xavier Léauté created KAFKA-12883:
-
Summary: Adress KIP-100 type constraints now that Java 7 support
is dropped
Key: KAFKA-12883
URL: https://issues.apache.org/jira/browse/KAFKA-12883
Project: Kafka
hachikuji commented on pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#issuecomment-853495182
@dengziming Thanks for the patch. Looks like the parser has some additional
validations which are not present in `MetadataRecordSerde`. Are any of them
worth porting over?
-
[
https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
loboxu reassigned KAFKA-9220:
-
Assignee: loboxu
> TimeoutException when using kafka-preferred-replica-election
> --
[
https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356061#comment-17356061
]
loboxu commented on KAFKA-9220:
---
[~akumar] Have you started work yet? If not, I can pick th
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10493:
Fix Version/s: (was: 3.0.0)
4.0.0
> KTable out-of-order updates are
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356055#comment-17356055
]
Matthias J. Sax commented on KAFKA-10493:
-
Seems we cannot agree on a solution f
socutes commented on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-853456306
@jsancio Code format fix completed! Thank you very much for your Review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan C. Gonzalez-Zurita reassigned KAFKA-12317:
---
Assignee: Juan C. Gonzalez-Zurita
> Relax non-null key requirement
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356044#comment-17356044
]
Juan C. Gonzalez-Zurita edited comment on KAFKA-12718 at 6/2/21, 11:34 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356044#comment-17356044
]
Juan C. Gonzalez-Zurita commented on KAFKA-12718:
-
I will try to get thi
vitojeng commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-853445357
Thanks @mjsax !
Please take a look.🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
cmccabe merged pull request #10787:
URL: https://github.com/apache/kafka/pull/10787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Ryan Dielhenn created KAFKA-12882:
-
Summary: Add RegisteredBrokerCount and UnfencedBrokerCount metrics
to the QuorumController
Key: KAFKA-12882
URL: https://issues.apache.org/jira/browse/KAFKA-12882
P
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356005#comment-17356005
]
Matthias J. Sax commented on KAFKA-12718:
-
Thanks [~guozhang] – given the last m
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Description:
Currently, for a stream-streams and stream-table/globalTable join KafkaStream
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Description:
Currently, for a stream-streams and stream-table/globalTable join KafkaStream
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Summary: Relax non-null key requirement for left/outer KStream joins (was:
Relax non-null
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Description:
Currently, for a stream-table join KafkaStreams drops all stream records with
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Summary: Relax non-null key requirement for left KStream joins (was: Relax
non-null key r
dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053
Just tagging @ijuma here again (to bring back this PR up to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12878:
--
Priority: Critical (was: Major)
> Support --bootstrap-server kafka-streams-application-reset
[
https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12878:
--
Fix Version/s: 3.0.0
> Support --bootstrap-server kafka-streams-application-reset
> --
[
https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356001#comment-17356001
]
Guozhang Wang commented on KAFKA-12878:
---
[~nbuesing] Could you please file a small
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356000#comment-17356000
]
Guozhang Wang commented on KAFKA-12718:
---
Hi folks, I'm bumping up the priority of
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12718:
--
Priority: Critical (was: Major)
> SessionWindows are closed too early
> -
dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053
Just tagging @ijuma here again (to put back this PR up to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644356441
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
guozhangwang commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-853412114
Thank you @showuon !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
guozhangwang merged pull request #10552:
URL: https://github.com/apache/kafka/pull/10552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
guozhangwang commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-853411553
The failed tests are irrelevant to this PR, I'm merging to trunk now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dejan2609 commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-853411084
Shameless plug and related to CheckStyle: ⏩ #10698 (needs a review /
approval).
--
This is an automated message from the Apache Git Service.
To respond to the mess
guozhangwang commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r644345818
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##
@@ -593,6 +575,111 @@ public void should
dejan2609 commented on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053
Just tagging @ijuma here again (to come back up to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
guozhangwang commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r644344196
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -462,39 +512,49 @@ private void cleanRemo
guozhangwang commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r644343550
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##
@@ -125,6 +130,29 @@ public int
[
https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355976#comment-17355976
]
Kalpesh Patel commented on KAFKA-4793:
--
(y)
> Kafka Connect: POST /connectors/(stri
[
https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kalpesh Patel reassigned KAFKA-4793:
Assignee: Kalpesh Patel (was: Randall Hauch)
> Kafka Connect: POST /connectors/(string: n
[
https://issues.apache.org/jira/browse/KAFKA-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryanne Dolan resolved KAFKA-7815.
-
Fix Version/s: 2.4.0
Resolution: Fixed
Equivalent functionality was included as part of KI
[
https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355973#comment-17355973
]
Randall Hauch commented on KAFKA-4793:
--
[~kpatelatwork], thanks for offering. Yes, y
[
https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355967#comment-17355967
]
Kalpesh Patel commented on KAFKA-4793:
--
[~rhauch] this is a great proposal, would it
Josep Prat created KAFKA-12881:
--
Summary: Consider Un-Deprecation of Consumer#committed methods
Key: KAFKA-12881
URL: https://issues.apache.org/jira/browse/KAFKA-12881
Project: Kafka
Issue Type:
cmccabe commented on pull request #10787:
URL: https://github.com/apache/kafka/pull/10787#issuecomment-853338511
OK. Thanks for the reviews. I will commit after Jenkins runs if there are no
objections
(current PR just moves KafkaEventQueue)
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-12864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-12864:
-
Summary: Move KafkaEventQueue into server-common (was: Move
KafkaEventQueue and timeline data s
[
https://issues.apache.org/jira/browse/KAFKA-12864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-12864:
-
Description: Move KafkaEventQueue into server-common (was: Move
KafkaEventQueue and timeline da
ijuma commented on pull request #10787:
URL: https://github.com/apache/kafka/pull/10787#issuecomment-853338002
Makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cmccabe commented on pull request #10787:
URL: https://github.com/apache/kafka/pull/10787#issuecomment-853335116
> I would personally not move these classes unless we believe we will use
them from other modules. They're a bit specialized, especially the timeline
ones.
`KafkaEventQue
ijuma commented on pull request #10787:
URL: https://github.com/apache/kafka/pull/10787#issuecomment-853323788
I would personally not move these classes unless we believe we will use them
from other modules. They're a bit specialized, especially the timeline ones.
--
This is an automated
ijuma commented on pull request #10787:
URL: https://github.com/apache/kafka/pull/10787#issuecomment-853316612
Are we using these classes from any module besides metadata atm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/KAFKA-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-12867.
Fix Version/s: 3.0.0
Reviewer: Rajini Sivaram
Resolution: Fixed
> Trogdor
[
https://issues.apache.org/jira/browse/KAFKA-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram reassigned KAFKA-12867:
--
Assignee: Kowshik Prakasam
> Trogdor ConsumeBenchWorker quits prematurely with maxMes
ijuma merged pull request #10808:
URL: https://github.com/apache/kafka/pull/10808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
rajinisivaram merged pull request #10797:
URL: https://github.com/apache/kafka/pull/10797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ijuma commented on pull request #10808:
URL: https://github.com/apache/kafka/pull/10808#issuecomment-853284235
One unrelated failure:
> Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.integration.ConnectorClientPolicyIntegrationTest.testCreateWithNotAllowedOverridesForPrincip
vvcephei commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r644196594
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java
##
@@ -75,14 +75,20 @@
void init(final ProcessorC
tombentley commented on pull request #10807:
URL: https://github.com/apache/kafka/pull/10807#issuecomment-853251332
@weeco you're right it's not super helpful, because you would have to
post-process the log to figure out who was causing the problem (i.e. observe
that the same principal and
mjsax commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-853249482
@vitojeng -- Seems there is some conflicts. Can you rebase your PR so we can
merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r644184061
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -491,25 +493,23 @@ public void testStateThreadClose() throws Except
weeco commented on pull request #10807:
URL: https://github.com/apache/kafka/pull/10807#issuecomment-853223533
Hey @tombentley , thanks for tackling this! I understand your performance
concerns in regards to the quota implementation; I can't judge if a quota for
that is actually too expens
jsancio commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r644156023
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -68,15 +68,27 @@ public static Path snapshotPath(Path logDir, OffsetAndEpo
[
https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355860#comment-17355860
]
Randall Hauch commented on KAFKA-4793:
--
I've created a KIP that expands the existing
jsancio commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r644148707
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -372,27 +371,23 @@ private void maybeFireLeaderChange() {
@Overri
ryannedolan commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r644125908
##
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##
@@ -58,7 +58,11 @@ import scala.util.{Failure, Success, Try}
*enable.
[
https://issues.apache.org/jira/browse/KAFKA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355841#comment-17355841
]
Ryanne Dolan commented on KAFKA-12436:
--
[~ijuma] can I get a review please?
> depr
[
https://issues.apache.org/jira/browse/KAFKA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryanne Dolan updated KAFKA-12436:
-
Reviewer: Ismael Juma (was: Konstantine Karantasis)
> deprecate MirrorMaker v1
> --
[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355728#comment-17355728
]
loboxu edited comment on KAFKA-10900 at 6/2/21, 3:52 PM:
-
[~jags
satishd commented on a change in pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#discussion_r636298299
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
##
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355801#comment-17355801
]
Chia-Ping Tsai commented on KAFKA-12847:
{quote}
ARG UID="1000" ==> Has no effec
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355791#comment-17355791
]
Abhijit Mane edited comment on KAFKA-12847 at 6/2/21, 3:12 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355791#comment-17355791
]
Abhijit Mane commented on KAFKA-12847:
--
[~chia7712]
Thanks for looking into this.
[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355728#comment-17355728
]
loboxu edited comment on KAFKA-10900 at 6/2/21, 3:11 PM:
-
[~jags
[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355728#comment-17355728
]
loboxu edited comment on KAFKA-10900 at 6/2/21, 3:04 PM:
-
[~jags
[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355728#comment-17355728
]
loboxu commented on KAFKA-10900:
[~jagsancio] Can you give me some guidance? Show me wh
ijuma commented on pull request #10808:
URL: https://github.com/apache/kafka/pull/10808#issuecomment-853032815
@dajac did you intend to keep these when you removed `Sum` and `Total` or
was it an oversight?
--
This is an automated message from the Apache Git Service.
To respond to the mes
ijuma opened a new pull request #10808:
URL: https://github.com/apache/kafka/pull/10808
They were both deprecated in Apache Kafka 2.4 and it's a straightforward
change
to use the non deprecated variants.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
[
https://issues.apache.org/jira/browse/KAFKA-12880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12880:
Summary: Remove deprecated Count and SampledTotal in 3.0 (was: Remove
deprecated Count and Rate i
Ismael Juma created KAFKA-12880:
---
Summary: Remove deprecated Count and Rate in 3.0
Key: KAFKA-12880
URL: https://issues.apache.org/jira/browse/KAFKA-12880
Project: Kafka
Issue Type: Bug
ijuma merged pull request #10806:
URL: https://github.com/apache/kafka/pull/10806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
ijuma merged pull request #10800:
URL: https://github.com/apache/kafka/pull/10800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355675#comment-17355675
]
Luke Chen commented on KAFKA-12598:
---
[~ijuma], I see. Will do! Thanks.
> Remove depre
tombentley commented on pull request #10807:
URL: https://github.com/apache/kafka/pull/10807#issuecomment-852970504
@dajac please could you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
tombentley opened a new pull request #10807:
URL: https://github.com/apache/kafka/pull/10807
[KAFKA-12797](https://issues.apache.org/jira/browse/KAFKA-12797) describes
the difficulty in discovering bad clients that are responsible for evicting
every other non-privileged session from the ca
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-852954993
@mumrah Thanks for the feedback, just addressed, but the potential
concurrency issue needs more discussion~
--
This is an automated message from the Apache Git Service.
To
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-852954180
> > Are there any concerns with multi-threading here? I think the answer is
"no". Any thoughts @feyman2016 or @jsancio?
>
> Good point. There may be some concurrency is
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r643850904
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2276,6 +2277,24 @@ public void resign(int epoch) {
);
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r643850801
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2276,6 +2277,24 @@ public void resign(int epoch) {
);
1 - 100 of 115 matches
Mail list logo
