[ 
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355728#comment-17355728
 ] 

loboxu edited comment on KAFKA-10900 at 6/2/21, 3:11 PM:
---------------------------------------------------------

[~jagsancio]  Can you give me some guidance? Where the metrics are added in the 
code. I have looked at the code and the logic is not very clear.

Here is my understanding of the position:
 * GenSnapshotLatencyMs:KafkaMetadataLog.createSnapshot()

 - LoadSnapshotLatencyMs:KafkaMetadataLog.readSnapshot()
 - SnapshotSizeBytes: KafkaMetadataLog.createSnapshot()
 - SnapshotLag: KafkaMetadataLog.appendAsLeader()


was (Author: loboxu):
[~jagsancio]  Can you give me some guidance? Show me where these four metrics 
are added in the code. I have looked at the code and the logic is not very 
clear.

Here is my understanding of the position:
 * GenSnapshotLatencyMs:KafkaMetadataLog.createSnapshot()

 - LoadSnapshotLatencyMs:KafkaMetadataLog.readSnapshot()
 - SnapshotSizeBytes
 - SnapshotLag

> Add metrics enumerated in KIP-630
> ---------------------------------
>
>                 Key: KAFKA-10900
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10900
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: replication
>            Reporter: Jose Armando Garcia Sancio
>            Assignee: loboxu
>            Priority: Major
>
> KIP-630 enumerates a few metrics. Makes sure that those metrics are 
> implemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to