[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356044#comment-17356044
]
Juan C. Gonzalez-Zurita edited comment on KAFKA-12718 at 6/2/21, 11:34 PM:
---------------------------------------------------------------------------
I will try to get this PR tonight or tomorrow night depending on circumstances.
This test case is the last I need to update in order to agree with the gap
changes within the streams test. As to the new ticket itself I would love to
pick it up but I've not investigated it with enough depth to be certain whether
or not I could beat the 14th deadline for it. I would be happy to try, though
:) [~mjsax].
Edit: I thought it was June 14th but it's really July. Yes I'll add myself rn
was (Author: gonzur):
I will try to get this PR tonight or tomorrow night depending on circumstances.
This test case is the last I need to update in order to agree with the gap
changes within the streams test. As to the new ticket itself I would love to
pick it up but I've not investigated it with enough depth to be certain whether
or not I could beat the 14th deadline for it. I would be happy to try, though
:) [~mjsax].
> SessionWindows are closed too early
> -----------------------------------
>
> Key: KAFKA-12718
> URL: https://issues.apache.org/jira/browse/KAFKA-12718
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Juan C. Gonzalez-Zurita
> Priority: Critical
> Labels: beginner, easy-fix, newbie
> Fix For: 3.0.0
>
>
> SessionWindows are defined based on a {{gap}} parameter, and also support an
> additional {{grace-period}} configuration to handle out-of-order data.
> To incorporate the session-gap a session window should only be closed at
> {{window-end + gap}} and to incorporate grace-period, the close time should
> be pushed out further to {{window-end + gap + grace}}.
> However, atm we compute the window close time as {{window-end + grace}}
> omitting the {{gap}} parameter.
> Because default grace-period is 24h most users might not notice this issues.
> Even if they set a grace period explicitly (eg, when using suppress()), they
> would most likely set a grace-period larger than gap-time not hitting the
> issue (or maybe only realize it when inspecting the behavior closely).
> However, if a user wants to disable the grace-period and sets it to zero (on
> any other value smaller than gap-time), sessions might be close too early and
> user might notice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
