madrob commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2725303749
I would consider pulling the entire scriptlets into separate files and then
you can run spellcheck on those?
--
This is an automated message from the Apache Git Service.
To respond t
HoustonPutman commented on PR #3258:
URL: https://github.com/apache/solr/pull/3258#issuecomment-2725240315
This will also fix our failing Windows builds. Much easier to do this, than
track down which test is failing there.
--
This is an automated message from the Apache Git Service.
To re
HoustonPutman commented on issue #760:
URL: https://github.com/apache/solr-operator/issues/760#issuecomment-2725179743
@aloosnetmatch can you provide the status of your solrcloud objects as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/SOLR-17702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935553#comment-17935553
]
Houston Putman commented on SOLR-17702:
---
So what you mentioned at
[https://github.
gerlowskija merged PR #767:
URL: https://github.com/apache/solr-operator/pull/767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
HoustonPutman closed pull request #3213: Fix flaky TestSchemaDesignerAPI
URL: https://github.com/apache/solr/pull/3213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
gerlowskija commented on issue #761:
URL: https://github.com/apache/solr-operator/issues/761#issuecomment-2711518166
Hi @aloosnetmatch - can you please share some more information to help us
understand and reproduce the issue?
1. What does your SolrCloud resource configuration look li
gerlowskija commented on issue #760:
URL: https://github.com/apache/solr-operator/issues/760#issuecomment-2718204202
I spent some time this morning trying to trigger this using the
`release-0.9` branch (Operator 0.9.0, essentially), and Solr 9.8.0, and
couldn't reproduce. Since @aloosnetma
sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1984122197
##
solr/core/src/java/org/apache/solr/search/ReRankCollector.java:
##
@@ -205,18 +205,29 @@ public TopDocs topDocs(int start, int howMany) {
ScoreDoc[] scoreDocs =
dsmiley commented on PR #3262:
URL: https://github.com/apache/solr/pull/3262#issuecomment-2726984646
I love what you wrote -- what this PR accomplishes. It's a mystery to me
**how** this PR accomplishes that goal. A test would be nice.
--
This is an automated message from the Apache Git
epugh commented on code in PR #3258:
URL: https://github.com/apache/solr/pull/3258#discussion_r1991163882
##
solr/core/src/test/org/apache/solr/cli/CLITestHelper.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933186#comment-17933186
]
Aviral Sinha edited comment on SOLR-17691 at 3/7/25 3:18 AM:
-
github-actions[bot] commented on PR #2940:
URL: https://github.com/apache/solr/pull/2940#issuecomment-2727066623
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
gerlowskija commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2725240241
I think our existing testing (see
`tests/e2e/solrcloud_security_json_test.go`) is sufficient here. It never
caught the #759 error, because it's not actually an error ("just" some
[
https://issues.apache.org/jira/browse/SOLR-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935796#comment-17935796
]
David Smiley commented on SOLR-17699:
-
I pushed a test.
My first attempt to test it
sijuv commented on PR #2960:
URL: https://github.com/apache/solr/pull/2960#issuecomment-2704533403
In the current implementation, the _EarlyTerminatingCollector_ is not used
in any code path.
The collector is instantiated at only one place
https://github.com/apache/solr/blob/ac3d349dac53
HoustonPutman opened a new pull request, #3268:
URL: https://github.com/apache/solr/pull/3268
This is a small fix and I really don't think it warrants a JIRA and
especially a changelog entry. I can make a JIRA if people thinks it deserves
one.
The `DistributedApiAsyncTracker` mention
[
https://issues.apache.org/jira/browse/SOLR-17562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934542#comment-17934542
]
Jason Gerlowski commented on SOLR-17562:
Yep, I'll close this out (but am happy t
HoustonPutman commented on PR #3261:
URL: https://github.com/apache/solr/pull/3261#issuecomment-2718974649
Could we also disable it by default in the OS/Arch values we know are
unsupported, as well as the ALT JDK option?
--
This is an automated message from the Apache Git Service.
To resp
solrbot opened a new pull request, #3245:
URL: https://github.com/apache/solr/pull/3245
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.apache.curator:curator-test](https://curator.apache.org)
([source](https://redirect.githu
janhoy commented on PR #3145:
URL: https://github.com/apache/solr/pull/3145#issuecomment-2703529578
Any news on final location @madrob ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
gerlowskija commented on PR #756:
URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2711077517
(Confirmed this PR works with Solr 8.11 as well - so we should be covered
for the full range of supported Solr versions!)
--
This is an automated message from the Apache Git Ser
epugh commented on code in PR #3236:
URL: https://github.com/apache/solr/pull/3236#discussion_r1994384497
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -349,4 +361,31 @@ private static MetricsConfiguration
loadMetricsConfigura
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1996350108
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
dsmiley commented on PR #3233:
URL: https://github.com/apache/solr/pull/3233#issuecomment-2719102856
I've hit a blocking test failure in which
https://issues.apache.org/jira/browse/SOLR-13510 has reappeared here because
onQueued isn't necessarily called from the submitting thread :-(
`org.
David Smiley created SOLR-17704:
---
Summary: Change ZkDistributedLock to use Curator
Key: SOLR-17704
URL: https://issues.apache.org/jira/browse/SOLR-17704
Project: Solr
Issue Type: Sub-task
stillalex commented on code in PR #3258:
URL: https://github.com/apache/solr/pull/3258#discussion_r1995593321
##
solr/core/src/java/org/apache/solr/cli/ToolRuntime.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributo
gerlowskija commented on PR #756:
URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2710826399
Will do a sanity-check with 8.11 and start prepping to merge this.
Thanks for the quick update @elangelo !
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-14410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-14410:
--
Labels: pull-request-available (was: )
> Switch from SysV init script to systemd service defin
davispuh commented on PR #428:
URL: https://github.com/apache/solr/pull/428#issuecomment-2727008300
Wouldn't it be better to run `solr` in `foreground` mode? Then systemd would
be able to log stderr/out in journal. Now that output is just dropped. I know
that we don't lose logs because of s
NikolaiJDev closed pull request #2818: Solr 12276 angularjs to angular migration
URL: https://github.com/apache/solr/pull/2818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
NikolaiJDev commented on PR #2818:
URL: https://github.com/apache/solr/pull/2818#issuecomment-2726991544
Not needed anymore - CLOSED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
//
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
//
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997244468
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java:
##
@@ -38,7 +38,8 @@ public class SolrPing extends
CollectionRequiringSolrRequest {
/** Cr
35 matches
Mail list logo
