Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-20 Thread via GitHub
renatoh commented on PR #3163: URL: https://github.com/apache/solr/pull/3163#issuecomment-2670744975 > FYI I'm _very_ eager to examine this in detail but am on vacation this week. No worries, enjoy your vacation, I will off next week and limited to my phone -- This is an automate

[I] Zk-setup error [solr-operator]

2025-02-20 Thread via GitHub
idjemaoune opened a new issue, #759: URL: https://github.com/apache/solr-operator/issues/759 https://github.com/apache/solr-operator/blob/0ffddb6a4be25ffb3fdad6cb3ffe759d89c5fcf2/controllers/util/solr_security_util.go#L243 Zk setup container produce this error ```grep: ]: No such file

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-02-20 Thread via GitHub
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2673329627 @dsmiley @gus-asf pls relook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (SOLR-17679) Request for Documentation on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-02-20 Thread Khaled Alkhouli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khaled Alkhouli updated SOLR-17679: --- Attachment: Screenshot from 2025-02-20 16-31-48.png Description: Hello Apache Solr team,

[jira] [Created] (SOLR-17679) Request for Documentation on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-02-20 Thread Khaled Alkhouli (Jira)
Khaled Alkhouli created SOLR-17679: -- Summary: Request for Documentation on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic Key: SOLR-17679 URL: https://issues.apache.org/jira/browse/SOLR-17

Re: [I] Text to Vector Filter for Indexing [solr-operator]

2025-02-20 Thread via GitHub
epugh commented on issue #758: URL: https://github.com/apache/solr-operator/issues/758#issuecomment-2671659642 Is the correct repo? Did you mean `apache/solr`? For issues in the core Solr project we use JIRA. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (SOLR-17679) Request for Documentation on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-02-20 Thread Khaled Alkhouli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khaled Alkhouli updated SOLR-17679: --- Description: Hello Apache Solr team, I was able to implement a hybrid search engine that com

[jira] [Updated] (SOLR-17679) Request for Documentation/Feature Improvement on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-02-20 Thread Khaled Alkhouli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khaled Alkhouli updated SOLR-17679: --- Summary: Request for Documentation/Feature Improvement on Hybrid Lexical and Vector Search wi

[jira] [Updated] (SOLR-17679) Request for Documentation on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-02-20 Thread Khaled Alkhouli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khaled Alkhouli updated SOLR-17679: --- Description: Hello Apache Solr team, I was able to implement a hybrid search engine that com

[jira] [Commented] (SOLR-17677) {!join} in delete-by-query throws ClassCastException and closes IndexWriter

2025-02-20 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928868#comment-17928868 ] Jason Gerlowski commented on SOLR-17677: A few small updates: First, this is pre

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1964081310 ## solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java: ## @@ -0,0 +1,105 @@ +/* + * Licen

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1964083376 ## solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/search/TextToVectorQParserTest.java: ## @@ -29,6 +30,11 @@ public static void init() throws

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1964064479 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1964094479 ## solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactoryTest.java: ## @@ -0,0 +1,130 @@ +/* + * L

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1964100880 ## solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactoryTest.java: ## @@ -0,0 +1,130 @@ +/* + * L

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-20 Thread via GitHub
alessandrobenedetti commented on PR #3151: URL: https://github.com/apache/solr/pull/3151#issuecomment-2672286942 I've done another round of cleanup, documentation and improvements. There's still the annoying problem with the beforeClass/afterClass and tests leftovers. I'll be back

[PR] SOLR-17518: Deprecate UpdateRequest.getXml() and replace it with XMLRequestWriter [solr]

2025-02-20 Thread via GitHub
psalagnac opened a new pull request, #3200: URL: https://github.com/apache/solr/pull/3200 https://issues.apache.org/jira/browse/SOLR-17518 # Description Update request in XML are written directly by `UpdateRequest`. It would be much cleaner to have a dedicated c

[jira] [Commented] (SOLR-14414) New Admin UI

2025-02-20 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928885#comment-17928885 ] Chris M. Hostetter commented on SOLR-14414: --- The jetbrains issue was just an ex

[jira] [Updated] (SOLR-17518) Refactor out a XmlRequestWriter so that RequestWriter is abstract

2025-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17518: -- Labels: newdev pull-request-available (was: newdev) > Refactor out a XmlRequestWriter so that

Re: [PR] SOLR-17518: Deprecate UpdateRequest.getXml() and replace it with XMLRequestWriter [solr]

2025-02-20 Thread via GitHub
epugh commented on code in PR #3200: URL: https://github.com/apache/solr/pull/3200#discussion_r1964253721 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Commented] (SOLR-14414) New Admin UI

2025-02-20 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928898#comment-17928898 ] Christos Malliaridis commented on SOLR-14414: - I completely agree with your p

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-02-20 Thread via GitHub
epugh commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2672563684 thanks for the ref guide improvments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-02-20 Thread via GitHub
laminelam commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2672567020 > thanks for the ref guide improvments! Attached is a PDF version for better review experience [CertificateAuthenticationPlugin _ RefGuide_PDF.pdf](https://github.com/user-attach

[PR] Feature/update web dependencies [solr]

2025-02-20 Thread via GitHub
malliaridis opened a new pull request, #3201: URL: https://github.com/apache/solr/pull/3201 # Description With NodeJS v16 reaching EOL in 2023, we should upgrade to the latest LTS. # Solution This PR updates the ref-guide dependencies (web), including NodeJS to v22 (late

[jira] [Updated] (SOLR-14414) New Admin UI

2025-02-20 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-14414: Labels: new-ui pull-request-available ui (was: pull-request-available) > New Admin

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-02-20 Thread via GitHub
laminelam commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2672611692 Thank @epugh for your time on this. When you're ready to merge let me know will update the CHANGES file (or feel free to do it). I you think we could have another pair of eyes that would

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-20 Thread via GitHub
dsmiley commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2672660493 Ported to branch_9_8 so that it gets in 9.8.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-20 Thread via GitHub
dsmiley merged PR #3199: URL: https://github.com/apache/solr/pull/3199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[PR] LogListener: remove no-arg convenience methods [solr]

2025-02-20 Thread via GitHub
dsmiley opened a new pull request, #3202: URL: https://github.com/apache/solr/pull/3202 These are hazardous/sloppy. Tests should listen to a specific class/package. Motivated by: https://issues.apache.org/jira/browse/SOLR-17667?focusedCommentId=17928175&page=com.atlassian.jira.plugin

Re: [PR] SOLR-17650: Fix tests for unordered buffered updates [solr]

2025-02-20 Thread via GitHub
markrmiller commented on code in PR #3197: URL: https://github.com/apache/solr/pull/3197#discussion_r1964347792 ## solr/test-framework/src/java/org/apache/solr/util/SolrMatchers.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] LogListener: remove no-arg convenience methods [solr]

2025-02-20 Thread via GitHub
hossman commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672710644 Not really sure i understand why you consider them hazardous? FWIW: The intent of these was to make it as easy as possible for folks to write tests asserting that "No code run in this

[jira] [Updated] (SOLR-17677) {!join} in delete-by-query throws ClassCastException and closes IndexWriter

2025-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17677: -- Labels: pull-request-available (was: ) > {!join} in delete-by-query throws ClassCastException

Re: [PR] LogListener: remove no-arg convenience methods [solr]

2025-02-20 Thread via GitHub
dsmiley commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672795343 For the hazard, see what I linked to. Houston agrees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] LogListener: remove no-arg convenience methods [solr]

2025-02-20 Thread via GitHub
madrob commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672807785 Maybe we remove the debug (and info?) no-arg versions, leave a comment why, and leave the warn and error versions around? -- This is an automated message from the Apache Git Service. To res

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-02-20 Thread via GitHub
epugh commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2672811726 I assigned this to myself to not forget. I will leave this open for another day or so and then merge it. I can take care of the CHANGES.txt as that always seems to have merge challenges!

Re: [PR] LogListener: remove no-arg convenience methods [solr]

2025-02-20 Thread via GitHub
hossman commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672823452 > For the hazard, see what I linked to. Houston agrees. Ah ok -- yeah, sorry i didn't notice that jira link. The crux of the problem being that in order to listen to the logs at