psalagnac opened a new pull request, #3200: URL: https://github.com/apache/solr/pull/3200
https://issues.apache.org/jira/browse/SOLR-17518 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Update request in XML are written directly by `UpdateRequest`. It would be much cleaner to have a dedicated class, specific to XML, similar to existing `BinaryRequestWriter`. # Solution Add `XMLRequestWriter`. Methods `UpdateRequest.getXML()` and `UpdateRequest.writeXML()` are flagged as deprecated, so the change may be merged in 9x branch. I plan to fully remove them from 10 in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
