hossman commented on PR #3202:
URL: https://github.com/apache/solr/pull/3202#issuecomment-2672823452
> For the hazard, see what I linked to. Houston agrees.
Ah ok -- yeah, sorry i didn't notice that jira link.
The crux of the problem being that in order to listen to the logs at a
particular level, we must enable the logs at that level, and enabling something
like DEBUG at the ROOT level can really slow things down.
Totally valid point.
> Maybe we remove the debug (and info?) no-arg versions, leave a comment
why, and leave the warn and error versions around?
We could, but that functionality is still available by referring to the root
level logger by `""` (which is already mentioned as possible in the jdocs) for
the rare case where it's useful ... I agree with David: we should "Make the
common/safe thing easy, Make the rare/scary thing hard"
BTW David: skimming the code i see an out of date TODO that should also be
removed..
```
// TODO: no-arg factory variants that use "" -- simpler syntax for ROOT
logger?
```
(don't want to leave a TODO suggesting someone re-add the thing you're
removing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
