[jira] [Commented] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921732#comment-17921732 ] Jan Høydahl commented on SOLR-17342: I can confirm that the ASF web site compliance c

[jira] [Commented] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-28 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921779#comment-17921779 ] Houston Putman commented on SOLR-17342: --- Thanks for handling this Jan! For now, le

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932439155 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -399,6 +399,22 @@ For example, setting `cpuAllowed=500` gives a limit of at mos

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932441426 ## solr/core/src/java/org/apache/solr/search/QueryCommand.java: ## @@ -194,7 +195,7 @@ public QueryCommand setNeedDocSet(boolean needDocSet) { } public boole

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1932707839 ## solr/core/src/java/org/apache/solr/schema/CurrencyFieldType.java: ## @@ -387,7 +386,7 @@ private Query getRangeQueryInternal( (p1 != null) ? p1.getCurren

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-28 Thread via GitHub
cpoerschke commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1932657684 ## solr/core/src/java/org/apache/solr/schema/CurrencyFieldType.java: ## @@ -387,7 +386,7 @@ private Query getRangeQueryInternal( (p1 != null) ? p1.getCurrencyC

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-28 Thread via GitHub
cpoerschke commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1932717320 ## solr/core/src/java/org/apache/solr/schema/CurrencyFieldType.java: ## @@ -387,7 +385,8 @@ private Query getRangeQueryInternal( (p1 != null) ? p1.getCurrencyC

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932759503 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -68,6 +68,7 @@ public class SolrQueryResponse { public static final String RESPONSE_HEADER_PA

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932760465 ## solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollector.java: ## @@ -29,11 +30,15 @@ */ public class EarlyTerminatingCollector extends FilterCollector {

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932762106 ## solr/core/src/java/org/apache/solr/search/QueryCommand.java: ## @@ -194,7 +195,7 @@ public QueryCommand setNeedDocSet(boolean needDocSet) { } public boolean getTe

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2619918214 > A test is needed. added tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932766821 ## solr/core/src/java/org/apache/solr/search/QueryResult.java: ## @@ -22,6 +22,7 @@ public class QueryResult { // Object for back compatibility so that we render true not

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932767430 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -399,6 +399,22 @@ For example, setting `cpuAllowed=500` gives a limit of at most 500 ms

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2619919386 @dsmiley @HoustonPutman updated, pls take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2025-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921867#comment-17921867 ] ASF subversion and git services commented on SOLR-17504: Commit 3

[jira] [Commented] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921865#comment-17921865 ] Jan Høydahl commented on SOLR-17342: The deadline is March 1st, so no rush. But we co

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on code in PR #3142: URL: https://github.com/apache/solr/pull/3142#discussion_r1932899214 ## solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java: ## @@ -1037,8 +1036,7 @@ private int indexDirCount(String ddir) { @Over

[jira] [Commented] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2025-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921869#comment-17921869 ] ASF subversion and git services commented on SOLR-17504: Commit d

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on PR #3142: URL: https://github.com/apache/solr/pull/3142#issuecomment-2620119361 > Thanks @HoustonPutman for looking at these, and sorry I didn't catch them, as I think I reviewed both of those PR's. Is there some more unit testing that we need that would have prev

[jira] [Commented] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2025-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921871#comment-17921871 ] ASF subversion and git services commented on SOLR-17504: Commit 3

[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2025-01-28 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921874#comment-17921874 ] Anshum Gupta commented on SOLR-17334: - is this good to be closed? > Minor bugs in So

[jira] [Updated] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2025-01-28 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-17334: Fix Version/s: (was: 9.8) > Minor bugs in Solr dedicated coordinator mode > ---

[jira] [Resolved] (SOLR-17590) Complete Major changes and Upgrade Notes in RefGuide for 9.8.0

2025-01-28 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta resolved SOLR-17590. - Resolution: Fixed > Complete Major changes and Upgrade Notes in RefGuide for 9.8.0 >

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2025-01-28 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921977#comment-17921977 ] Houston Putman commented on SOLR-17379: --- So after far too much debugging, I figured

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-28 Thread via GitHub
cpoerschke commented on code in PR #3048: URL: https://github.com/apache/solr/pull/3048#discussion_r1932629861 ## solr/solrj/build.gradle: ## @@ -81,7 +81,7 @@ dependencies { testRuntimeOnly(libs.eclipse.jetty.alpnjavaserver, { exclude group: "org.eclipse.jetty.alpn", mo

[jira] [Updated] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17342: --- Attachment: Skjermbilde 2025-01-28 kl. 14.26.58.png > Comply with ASF website policy - external resou

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-01-28 Thread via GitHub
HoustonPutman commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2619714256 Ok I've undone the pointField stuff, as the only clean way is to throw an error to users. So let's do https://issues.apache.org/jira/browse/SOLR-14199 completely separately. -- This

Re: [PR] Jetty12 + EE10 [solr]

2025-01-28 Thread via GitHub
dsmiley commented on code in PR #2876: URL: https://github.com/apache/solr/pull/2876#discussion_r1932792887 ## solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java: ## @@ -414,16 +415,16 @@ public void contextInitialized(ServletContextEvent event) {

[PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
HoustonPutman opened a new pull request, #3142: URL: https://github.com/apache/solr/pull/3142 This actually stems from two commits on the same day, kind of eerie. ### [SOLR-17306](https://issues.apache.org/jira/browse/SOLR-17306) This uncommented out: ```java System.setPropert

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
epugh commented on PR #3142: URL: https://github.com/apache/solr/pull/3142#issuecomment-2620046961 @mlbiscoc I should have reminded/and or run the nightly tests when I was reviewing the path stuff.. Let's remember to do that as we continue! -- This is an automated message from the Apache

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
epugh commented on PR #3142: URL: https://github.com/apache/solr/pull/3142#issuecomment-2620051699 Thanks @HoustonPutman for looking at these, and sorry I didn't catch them, as I think I reviewed both of those PR's. Is there some more unit testing that we need that would have prevented th

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
epugh commented on code in PR #3142: URL: https://github.com/apache/solr/pull/3142#discussion_r1932855830 ## solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java: ## @@ -1037,8 +1036,7 @@ private int indexDirCount(String ddir) { @Override

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-28 Thread via GitHub
dsmiley commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1933299568 ## solr/core/src/java/org/apache/solr/search/QueryResult.java: ## @@ -22,6 +22,7 @@ public class QueryResult { // Object for back compatibility so that we render true n

Re: [PR] Fix TestReplicationHandler [solr]

2025-01-28 Thread via GitHub
dsmiley commented on PR #3142: URL: https://github.com/apache/solr/pull/3142#issuecomment-2620779247 I raised the topic on the dev list but FYI I'm our resident Crave expert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-28 Thread via GitHub
dsmiley commented on code in PR #3048: URL: https://github.com/apache/solr/pull/3048#discussion_r1933308834 ## solr/solrj/build.gradle: ## @@ -48,7 +48,6 @@ dependencies { }) implementation libs.apache.httpcomponents.httpclient implementation libs.apache.httpcomponents.

[jira] [Resolved] (SOLR-17519) CloudSolrClient with HTTP ClusterState can forget live nodes and then fail

2025-01-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17519. - Fix Version/s: 9.9 Resolution: Fixed Merged and done. Thanks for your contribution here M

Re: [I] Use custom name for the ServiceAccount of Zookeeper operator [solr-operator]

2025-01-28 Thread via GitHub
saurabh-adhikari commented on issue #750: URL: https://github.com/apache/solr-operator/issues/750#issuecomment-2620881139 By default, the Zookeeper Operator creates a ServiceAccount named zookeeper-operator when installed via the Solr Operator dependency chart. This behavior can be modified