HoustonPutman commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1932441426
########## solr/core/src/java/org/apache/solr/search/QueryCommand.java: ########## @@ -194,7 +195,7 @@ public QueryCommand setNeedDocSet(boolean needDocSet) { } public boolean getTerminateEarly() { - return (flags & SolrIndexSearcher.TERMINATE_EARLY) != 0; + return (flags & SolrIndexSearcher.TERMINATE_EARLY) != 0 || maxHits < Integer.MAX_VALUE; Review Comment: I agree, the name of the param does not really indicate that it could lead to partial results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org