HoustonPutman opened a new pull request, #3142: URL: https://github.com/apache/solr/pull/3142
This actually stems from two commits on the same day, kind of eerie. ### [SOLR-17306](https://issues.apache.org/jira/browse/SOLR-17306) This uncommented out: ```java System.setProperty("solr.directoryFactory", "solr.StandardDirectoryFactory"); ``` Apparently when using the StandardDirectoryFactory, we see core snapshot directories when we don't see them using the default DirectoryFactory. The code already accounted for snapshot metadata, but not snapshots themselves. I updated the check to ignore any snapshot directory when counting index directories. @dsmiley, you wrote the snapshot metadata filtering, so can you check this for me? ### [SOLR-17548](https://issues.apache.org/jira/browse/SOLR-17548) In `ReplicationTestHelper`, this changed ```java FileUtils.copyFile( new File(SolrTestCaseJ4.TEST_HOME(), "solr.xml"), new File(instance.getHomeDir(), "solr.xml")); ``` to ```java Files.copy( Path.of(SolrTestCaseJ4.TEST_HOME(), "solr.xml"), Path.of(instance.getHomeDir(), "solr.xml")); ``` However, this forgot to allow for overwrites, as was done in other cases in this PR. Probably because nightly tests are usually forgotten. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
