dsmiley commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1911478242
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912129#comment-17912129
]
ASF subversion and git services commented on SOLR-17556:
Commit 1
dsmiley commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1911643958
##
encryption/src/test/java/org/apache/solr/encryption/EncryptionTestUtil.java:
##
@@ -130,16 +144,32 @@ public EncryptionStatus encrypt(String keyId) throws
Except
dsmiley commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911878590
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,7 +37,7 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpco
dsmiley commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911881108
##
gradle/testing/randomization.gradle:
##
@@ -199,7 +199,12 @@ allprojects {
// Enable security manager, if requested. We could move the selection
of security
dsmiley commented on code in PR #2940:
URL: https://github.com/apache/solr/pull/2940#discussion_r1911884285
##
solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc:
##
@@ -1703,7 +1703,8 @@ The default is `\*:*` which will export all documents.
HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911678951
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,7 +37,7 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.
[
https://issues.apache.org/jira/browse/SOLR-17616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912149#comment-17912149
]
David Smiley commented on SOLR-17616:
-
A simple alternative that's probably good enou
[
https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912145#comment-17912145
]
David Smiley commented on SOLR-17519:
-
bq. (ZK) so this probably was never an issue e
HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911639009
##
solr/modules/cross-dc/build.gradle:
##
@@ -0,0 +1,70 @@
+import org.apache.tools.ant.taskdefs.condition.Os
+
+/*
+ * Licensed to the Apache Software Foundation (A
HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911647147
##
gradle/testing/randomization.gradle:
##
@@ -199,7 +199,12 @@ allprojects {
// Enable security manager, if requested. We could move the selection
of se
dsmiley commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911520815
##
gradle/testing/randomization.gradle:
##
@@ -199,7 +199,12 @@ allprojects {
// Enable security manager, if requested. We could move the selection
of security
dsmiley commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1911469240
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -194,15 +258,22 @@ public void handleRequestBody(SolrQueryRequest req,
S
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912130#comment-17912130
]
ASF subversion and git services commented on SOLR-17556:
Commit 4
HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911661589
##
gradle/validation/validate-log-calls.gradle:
##
@@ -118,7 +118,7 @@ class ValidateLogCallsTask extends DefaultTask {
if (hasPlus) {
cause = "hasPlus
dsmiley opened a new pull request, #3025:
URL: https://github.com/apache/solr/pull/3025
Motivated by needing to remove this from a failure reported by Crave's 96
core machine.
I tested this manually.
--
This is an automated message from the Apache Git Service.
To respond to the mes
cpoerschke commented on code in PR #2640:
URL: https://github.com/apache/solr/pull/2640#discussion_r1910131697
##
solr/core/src/test-files/solr/collection1/conf/solrconfig-tieredmergepolicyfactory.xml:
##
@@ -28,6 +28,7 @@
19
7
9
+ 1
Review Comment:
janhoy commented on PR #674:
URL: https://github.com/apache/solr-operator/pull/674#issuecomment-2582020954
So shall we try to conclude on this before 0.9? Do I understand correctly
that the feature itself looks good, no concerns wrt autoscaling here. And the
test is ok, but could have been
renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909977436
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +70,8 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return
HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911634896
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2158,7 +2158,8 @@ public static File getFile(String name) {
return file;
}
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912128#comment-17912128
]
ASF subversion and git services commented on SOLR-17556:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912139#comment-17912139
]
Matthew Biscocho commented on SOLR-17519:
-
Using a static set of URLs would simpl
dsmiley commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1911560169
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
dsmiley commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1910412721
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +69,42 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return
epugh commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1910305906
##
solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java:
##
@@ -367,10 +366,7 @@ private void close(CacheValue val) {
}
private static boolean isSubP
epugh merged PR #2974:
URL: https://github.com/apache/solr/pull/2974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2974:
URL: https://github.com/apache/solr/pull/2974#issuecomment-2582581881
Thank you for making Solr a better place!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
epugh commented on PR #2940:
URL: https://github.com/apache/solr/pull/2940#issuecomment-2582646623
I'd love a plus one on the this before I merge...For a lot of multi step
processes, like exporting and importing data, I find modeling them as BATS
tests makes them easier to understand in
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1910689266
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,7 +52,9 @@ public abstract class BaseHttpClusterStateProvider implem
Colvin Cowie created SOLR-17617:
---
Summary: v2 CollectionProp and InstallCoreData APIs are broken
Key: SOLR-17617
URL: https://issues.apache.org/jira/browse/SOLR-17617
Project: Solr
Issue Type:
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1910698804
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -413,6 +418,30 @@ public String getQuorumHosts() {
return String.jo
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1910697779
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -61,6 +67,7 @@ public abstract class BaseHttpClusterStateProvider implem
[
https://issues.apache.org/jira/browse/SOLR-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17617:
--
Labels: pull-request-available (was: )
> v2 CollectionProp and InstallCoreData APIs are broken
colvinco opened a new pull request, #3023:
URL: https://github.com/apache/solr/pull/3023
https://issues.apache.org/jira/browse/SOLR-17617
# Description
Add missing `@Inject` annotations.
# Tests
TODO: add a smoke test for all v2 APIs
# Checklist
dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1910436766
##
solr/core/src/java/org/apache/solr/core/CoreDescriptor.java:
##
@@ -96,7 +95,7 @@ public Properties getPersistableUserProperties() {
CORE_CONFIG, "solrconfig
jdyer1 commented on PR #2926:
URL: https://github.com/apache/solr/pull/2926#issuecomment-2583458199
@Paul-Blanchaert This is great, although I am surprised the host jetty
behaves such.
Can you both sync this branch to `main` and add a CHANGES.txt entry under
solr 9.9 (be sure to g
gerlowskija commented on PR #702:
URL: https://github.com/apache/solr-operator/pull/702#issuecomment-2583399653
No worries - thanks for getting back to me. I'll move the other PR forward
then, and hopefully that meets everyone's needs here 👍
--
This is an automated message from the Apac
HoustonPutman merged PR #3020:
URL: https://github.com/apache/solr/pull/3020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912039#comment-17912039
]
ASF subversion and git services commented on SOLR-17556:
Commit 9
gerlowskija closed pull request #702: Add security context config to SOLR
containers
URL: https://github.com/apache/solr-operator/pull/702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912065#comment-17912065
]
ASF subversion and git services commented on SOLR-17556:
Commit 0
dsmiley commented on PR #2935:
URL: https://github.com/apache/solr/pull/2935#issuecomment-2583773292
I simplified characterization of how I think this should be done:
* on initialization, copy the configured URLs to a field for safe keeping.
Convert to URL if you like (validates if malfo
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1911140452
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -413,6 +418,30 @@ public String getQuorumHosts() {
return String.jo
renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1911235569
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +69,42 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return
renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1911235569
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +69,42 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return
[
https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912109#comment-17912109
]
David Smiley commented on SOLR-17519:
-
Here's another proposal that I'd like an opini
gerlowskija commented on PR #3023:
URL: https://github.com/apache/solr/pull/3023#issuecomment-2583508494
@colvinco asked the following in a dev-thread related to this PR:
> I've not really looked at the BATS tests before. [...] I take it I can
just run
> curl to poke each API. So t
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1910989910
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -61,6 +67,7 @@ public abstract class BaseHttpClusterStateProvider impleme
gerlowskija merged PR #743:
URL: https://github.com/apache/solr-operator/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
gerlowskija commented on issue #489:
URL: https://github.com/apache/solr-operator/issues/489#issuecomment-2583662132
Alright all - I've added support for setting arbitrary container-level
SecurityContext settings in the recently merged PR #743.
Hoping to do an operator release in the
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1911044868
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -229,10 +236,9 @@ > getCacheTimeout()) {
for (String nodeName : li
solrbot commented on PR #2999:
URL: https://github.com/apache/solr/pull/2999#issuecomment-2584050313
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
[
https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912118#comment-17912118
]
ASF subversion and git services commented on SOLR-17556:
Commit a
dsmiley commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1911438449
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +69,42 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return
54 matches
Mail list logo
