HoustonPutman commented on code in PR #2062:
URL: https://github.com/apache/solr/pull/2062#discussion_r1911661589
##########
gradle/validation/validate-log-calls.gradle:
##########
@@ -118,7 +118,7 @@ class ValidateLogCallsTask extends DefaultTask {
if (hasPlus) {
cause = "hasPlus: " + hasPlus
- violation = true
+ violation = level != "error"
Review Comment:
Yeah, this was a misunderstanding of the log.error() function, and the fact
that the last parameter is treated as an exception and not a parameter to the
string format. I can undo this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
