Re: [I] Solr Backup recurrence/schedule not enabled by helm 0.7.1 [solr-operator]

2024-12-13 Thread via GitHub
ethicalmohit commented on issue #687: URL: https://github.com/apache/solr-operator/issues/687#issuecomment-2540829544 > That just configures a repository for your backups to use. You have to use a separate SolrBackup resource to actually take a backup. > > The Solr Helm chart does not

[jira] [Created] (SOLR-17594) Allow usage of sockstat to detect if solr could be started successfully

2024-12-13 Thread Matthias Fechner (Jira)
Matthias Fechner created SOLR-17594: --- Summary: Allow usage of sockstat to detect if solr could be started successfully Key: SOLR-17594 URL: https://issues.apache.org/jira/browse/SOLR-17594 Project:

[PR] Allow lsof and sockstat to detect if solr started successfully [solr]

2024-12-13 Thread via GitHub
mfechner opened a new pull request, #2906: URL: https://github.com/apache/solr/pull/2906 The tool lsof is not available on all systems, like FreeBSD. Added the possibility to use sockstat to detect if solr started successfully. The startup script is using the tool that is available.

[jira] [Commented] (SOLR-17594) Allow usage of sockstat to detect if solr could be started successfully

2024-12-13 Thread Matthias Fechner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905428#comment-17905428 ] Matthias Fechner commented on SOLR-17594: - I included the patch now in FreeBSD po

[jira] [Commented] (SOLR-17594) Allow usage of sockstat to detect if solr could be started successfully

2024-12-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905448#comment-17905448 ] Eric Pugh commented on SOLR-17594: -- [~mfechner]  thanks for this.    Are you familiar

[jira] [Commented] (SOLR-16909) Collections LIST command should fetch ZK data, not cached state

2024-12-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905590#comment-17905590 ] David Smiley commented on SOLR-16909: - Some people (not me) have strong opinions abou

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
epugh commented on code in PR #2907: URL: https://github.com/apache/solr/pull/2907#discussion_r1884509931 ## solr/core/src/test/org/apache/solr/cli/PostToolTest.java: ## @@ -294,7 +294,7 @@ public void testDoFilesMode() throws IOException { postTool.recursive = 0; post

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2024-12-13 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905557#comment-17905557 ] Houston Putman commented on SOLR-16116: --- I think the title is correct. All of Solr'

[jira] [Resolved] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2024-12-13 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16116. --- Fix Version/s: main (10.0) Assignee: Houston Putman Resolution: Fixed > Refac

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc commented on code in PR #2907: URL: https://github.com/apache/solr/pull/2907#discussion_r1884801241 ## solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java: ## @@ -277,8 +276,8 @@ public static boolean hasServers(Properties props) { return false; } - pu

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc commented on code in PR #2907: URL: https://github.com/apache/solr/pull/2907#discussion_r1884801317 ## solr/core/src/test/org/apache/solr/cli/PostToolTest.java: ## @@ -294,7 +294,7 @@ public void testDoFilesMode() throws IOException { postTool.recursive = 0; p

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc commented on code in PR #2907: URL: https://github.com/apache/solr/pull/2907#discussion_r1884801769 ## solr/core/src/test/org/apache/solr/cli/PostToolTest.java: ## @@ -303,7 +303,7 @@ public void testDoFilesMode() throws IOException { public void testDetectingIfRecur

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc commented on code in PR #2907: URL: https://github.com/apache/solr/pull/2907#discussion_r1884801824 ## solr/modules/scripting/src/test/org/apache/solr/scripting/update/ScriptUpdateProcessorFactoryTest.java: ## @@ -44,7 +44,7 @@ public static void beforeClass() throws Ex

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc commented on PR #2907: URL: https://github.com/apache/solr/pull/2907#issuecomment-2542818507 > Really excited about this refactoring! I made some comments, mostly around "hey, this is a nice chnage" or "hey, is this an opporutnity" versus "please change this" type comments. >

Re: [I] It is impossible to setup TLS between Solr and Zookeeper [solr-operator]

2024-12-13 Thread via GitHub
gerlowskija commented on issue #717: URL: https://github.com/apache/solr-operator/issues/717#issuecomment-2541483245 Thanks for the detailed writeup @jstaf! I noticed there are some other planned changes in how the operator interacts with ZK [here](https://github.com/apache/solr-operator/i

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-13 Thread via GitHub
gerlowskija commented on code in PR #406: URL: https://github.com/apache/solr/pull/406#discussion_r1884041488 ## solr/benchmark/README.md: ## @@ -1,339 +1,423 @@ -JMH-Benchmarks module -= + -* [JMH-Benchmarks module](#jmh-benchmarks-module) - * [Running be

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-13 Thread via GitHub
gerlowskija commented on code in PR #406: URL: https://github.com/apache/solr/pull/406#discussion_r1884046331 ## solr/benchmark/docs/jmh-profilers-setup.md: ## @@ -0,0 +1,406 @@ + + +# JMH Profiler Setup (Async-Profiler and Perfasm) + +JMH ships with a number of built-in profile

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-13 Thread via GitHub
gerlowskija commented on PR #406: URL: https://github.com/apache/solr/pull/406#issuecomment-2541629734 LGTM - I made a few tiny tweaks, but otherwise this is a clear net-positive for the benchmarking docs. Thanks to: - @markrmiller for the great docs - @epugh for noticing th

[jira] [Resolved] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2024-12-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14680. - Resolution: Abandoned > Provide simple interfaces to our concrete SolrCloud classes > ---

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-13 Thread via GitHub
gerlowskija merged PR #406: URL: https://github.com/apache/solr/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-13 Thread via GitHub
mlbiscoc opened a new pull request, #2907: URL: https://github.com/apache/solr/pull/2907 https://issues.apache.org/jira/browse/SOLR-17548 # Description Move from `File` to the more modern `java.nio.file.Path` # Solution Tried to find all of the public constructors/

[jira] [Commented] (SOLR-15625) Proper documentation for the benchmark module.

2024-12-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905521#comment-17905521 ] ASF subversion and git services commented on SOLR-15625: Commit b

[jira] [Updated] (SOLR-17548) Switch all public Java APIs from File to Path

2024-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17548: -- Labels: newdev pull-request-available (was: newdev) > Switch all public Java APIs from File to

[jira] [Resolved] (SOLR-15625) Proper documentation for the benchmark module.

2024-12-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15625. Fix Version/s: main (10.0) 9.8 Resolution: Fixed > Proper documen

[jira] [Created] (SOLR-17595) CLI examples are broken on Windows

2024-12-13 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17595: --- Summary: CLI examples are broken on Windows Key: SOLR-17595 URL: https://issues.apache.org/jira/browse/SOLR-17595 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-16909) Collections LIST command should fetch ZK data, not cached state

2024-12-13 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905542#comment-17905542 ] Matthew Biscocho commented on SOLR-16909: - [~dsmiley] [~gerlowskija] Read the dev

[jira] [Updated] (SOLR-17595) CLI examples are broken on Windows

2024-12-13 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17595: Fix Version/s: 9.8 > CLI examples are broken on Windows > -

[I] Improve docs for serviceAccount/RBAC-related settings [solr-operator]

2024-12-13 Thread via GitHub
gerlowskija opened a new issue, #737: URL: https://github.com/apache/solr-operator/issues/737 Users can customize the RBAC permissions given to the operator by various "serviceAccount" helm chart settings. But the docs for these settings don't go into much detail on what permissions are gi

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-13 Thread via GitHub
gerlowskija commented on PR #2899: URL: https://github.com/apache/solr/pull/2899#issuecomment-2541696918 This LGTM, pending figuring out the test-failure issue and adding a CHANGES.txt entry that highlights the deprecations/removals. > The following were not removed, but perhaps shoul

[jira] [Commented] (SOLR-15625) Proper documentation for the benchmark module.

2024-12-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905523#comment-17905523 ] ASF subversion and git services commented on SOLR-15625: Commit 7

[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path

2024-12-13 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905525#comment-17905525 ] Matthew Biscocho commented on SOLR-17548: - Ended up picking this up. Tried to kee

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-13 Thread via GitHub
jdyer1 commented on PR #2899: URL: https://github.com/apache/solr/pull/2899#issuecomment-2542564895 > Probably add a new method to org.apache.solr.security.HttpClientBuilderPlugin for the builder, Thank you for the insight on this. I went ahead and did this, but its a bit ugly. I'd