mfechner opened a new pull request, #2906:
URL: https://github.com/apache/solr/pull/2906

   The tool lsof is not available on all systems, like FreeBSD.
   Added the possibility to use sockstat to detect if solr started successfully.
   The startup script is using the tool that is available.
   
   https://issues.apache.org/jira/browse/SOLR-17594
   
   * SOLR-####: solr cannot detect start on FreeBSD as lsof does not exist
   
   # Description
   
   Allow the startup script to use lsof or sockstat to detect if solr was 
started successfully
   
   # Solution
   
   The script checks at first if lsof is available than if sockstat is 
available and than fallback to standard behaviour.
   
   # Tests
   
   I tested the patch on FreeBSD and will also commit the patch after the PR is 
created with a link to it.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to