mlbiscoc commented on code in PR #2907:
URL: https://github.com/apache/solr/pull/2907#discussion_r1884801241
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -277,8 +276,8 @@ public static boolean hasServers(Properties props) {
return false;
}
- public void setDataDir(File dataDir) {
- this.dataDir = dataDir;
+ public void setDataDir(Path dataDir) {
+ this.dataDir = dataDir.toFile();
Review Comment:
Yeah this one is setting `dataDir` from an import existing in
`org.apache.zookeeper.server.quorum.QuorumPeerConfig` which is outside of Solr.
If you see `toFile()` it is most likely because it either got out of hand and I
put `TODO` to come back later or it wasn't possible to use `Path` strictly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
