Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-12-09 Thread via GitHub
epugh commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2527829121 > I picked changes from #2835 i.e. Hadoop-auth module being removed and this one and pushed a new branch to my fork. > > Branch contains code for Jetty 12 + EE10 (Jakarta servlet api) h

Re: [PR] SOLR-15546: ShortestPathStream to handle ids with colons. [solr]

2024-12-09 Thread via GitHub
epugh commented on PR #236: URL: https://github.com/apache/solr/pull/236#issuecomment-2527855227 I'd love to see this get into 10 without the `legacyJoin` stuff, since that seems hard to explain? Thoughts? If you don't have bandwidth/energy on this one, let me know and I can take it on.

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-09 Thread via GitHub
epugh commented on PR #406: URL: https://github.com/apache/solr/pull/406#issuecomment-2527859524 I might have violated etiquette, but I emailed @markrmiller directly ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1875948497 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1875956112 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-12-09 Thread via GitHub
iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2527421496 I picked changes from #2835 i.e. Hadoop-auth module being removed and this one and pushed a new branch to my fork. https://github.com/iamsanjay/solr/tree/jetty12_ee10 I starte

Re: [I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]

2024-12-09 Thread via GitHub
janhoy commented on issue #720: URL: https://github.com/apache/solr-operator/issues/720#issuecomment-2527357456 I created https://github.com/apache/solr-operator/issues/731 to track this -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
mkhludnev commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1875992464 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
mkhludnev commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1876020574 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-12-09 Thread via GitHub
markrmiller commented on code in PR #406: URL: https://github.com/apache/solr/pull/406#discussion_r1876519771 ## solr/benchmark/docs/jmh-profilers-setup.md: ## @@ -0,0 +1,406 @@ + + +# JMH Profiler Setup (Async-Profiler and Perfasm) + +JMH ships with a number of built-in profile

[jira] [Created] (SOLR-17587) Prometheus Writer Duplicate TYPE exposition format

2024-12-09 Thread Matthew Biscocho (Jira)
Matthew Biscocho created SOLR-17587: --- Summary: Prometheus Writer Duplicate TYPE exposition format Key: SOLR-17587 URL: https://issues.apache.org/jira/browse/SOLR-17587 Project: Solr Issue T

[jira] [Resolved] (SOLR-17540) Remove hadoop-auth module

2024-12-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17540. -- Fix Version/s: main (10.0) Assignee: Eric Pugh Resolution: Fixed Hadoop Auth removed in

[jira] [Commented] (SOLR-17540) Remove hadoop-auth module

2024-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904250#comment-17904250 ] ASF subversion and git services commented on SOLR-17540: Commit c

Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-12-09 Thread via GitHub
epugh commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2529064270 > > I picked changes from #2835 i.e. Hadoop-auth module being removed and this one and pushed a new branch to my fork. > > Branch contains code for Jetty 12 + EE10 (Jakarta servlet api) htt

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-09 Thread via GitHub
dsmiley commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1876531872 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -94,35 +97,74 @@ * * @since solr 8.0 */ -public class LBHttp2SolrClient extend

Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]

2024-12-09 Thread via GitHub
dsmiley commented on PR #2853: URL: https://github.com/apache/solr/pull/2853#issuecomment-2528550933 [The test failure is known flaky](http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.hdfs.cloud.api.collections.TestHdfsCloudBackupRestore.test

[PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-09 Thread via GitHub
jdyer1 opened a new pull request, #2899: URL: https://github.com/apache/solr/pull/2899 With this PR makes `LBHttp2SolrClient` maintains an instance of `HttpSolrClientBuilderBase` per "Base Url". This makes the semantics of `LBHttp2SolrClient#getClient` consistent with that of the older `L

[jira] [Updated] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17541: -- Labels: pull-request-available (was: ) > LBSolrClient implementations should agree on 'getClie

[jira] [Commented] (SOLR-17381) Make CLUSTERSTATUS request configurable

2024-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904217#comment-17904217 ] ASF subversion and git services commented on SOLR-17381: Commit d

Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]

2024-12-09 Thread via GitHub
dsmiley merged PR #2853: URL: https://github.com/apache/solr/pull/2853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-17587) Prometheus Writer Duplicate TYPE exposition format

2024-12-09 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Biscocho updated SOLR-17587: Description: Solr's Prometheus writer duplicates `# TYPE ` in it's exposition format for c

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-12-09 Thread via GitHub
epugh merged PR #2835: URL: https://github.com/apache/solr/pull/2835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17587) Prometheus Writer Duplicate TYPE exposition format

2024-12-09 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904242#comment-17904242 ] Matthew Biscocho commented on SOLR-17587: - Working on a fix for this now. Going t

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2024-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904266#comment-17904266 ] Paul Rütter commented on SOLR-16441: For the package change, you might consider using

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1876714632 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -126,19 +125,24 @@ public class SearchHandler extends RequestHandlerBase private PluginI

Re: [PR] fix: do not return metrics for prom-exporter probes re-fix (#694) [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija merged PR #729: URL: https://github.com/apache/solr-operator/pull/729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

Re: [PR] fix: do not return metrics for prom-exporter probes re-fix (#694) [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija commented on PR #729: URL: https://github.com/apache/solr-operator/pull/729#issuecomment-2528514511 Thanks @smoldenhauer-ish ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] gen-pkcs12-keystore init container fails if the tls secret contains no ca.crt [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija closed issue #684: gen-pkcs12-keystore init container fails if the tls secret contains no ca.crt URL: https://github.com/apache/solr-operator/issues/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija merged PR #685: URL: https://github.com/apache/solr-operator/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

Re: [I] Adding ObservedGeneration in the CRD [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija commented on issue #650: URL: https://github.com/apache/solr-operator/issues/650#issuecomment-2528822755 Hey @Shashankft9 , @RavinaChidambaram - can you elaborate a little on your broader use case? What sort of changes/states are you trying to monitor, that are tough to track w

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija commented on code in PR #685: URL: https://github.com/apache/solr-operator/pull/685#discussion_r1876310454 ## helm/solr-operator/Chart.yaml: ## @@ -54,13 +54,21 @@ annotations: # Add change log for a single release here. # Allowed syntax is described at: https

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-12-09 Thread via GitHub
gerlowskija commented on PR #685: URL: https://github.com/apache/solr-operator/pull/685#issuecomment-2528643576 Hi @smoldenhauer-ish - this LGTM overall. I did try to push one minor change to your branch, to reword the `helm/solr-operator/Chart.yaml` entry slightly. But it looks like

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1876178441 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1876187008 ## solr/core/src/java/org/apache/solr/handler/component/UBIComponent.java: ## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]

2024-12-09 Thread via GitHub
aparnasuresh85 commented on PR #2853: URL: https://github.com/apache/solr/pull/2853#issuecomment-2528479499 > Should be ready, assuming tests pass. @aparnasuresh85 happy to review with you. LGTM - could be merged when all test pass -- This is an automated message from the Apache Gi

[jira] [Resolved] (SOLR-17381) Make CLUSTERSTATUS request configurable

2024-12-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17381. - Assignee: David Smiley Resolution: Fixed > Make CLUSTERSTATUS request configurable > --

[jira] [Commented] (SOLR-17381) Make CLUSTERSTATUS request configurable

2024-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904224#comment-17904224 ] ASF subversion and git services commented on SOLR-17381: Commit a

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-12-09 Thread via GitHub
smoldenhauer-ish commented on PR #685: URL: https://github.com/apache/solr-operator/pull/685#issuecomment-2528760533 Hi @gerlowskija - added your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-12-09 Thread via GitHub
epugh commented on code in PR #2452: URL: https://github.com/apache/solr/pull/2452#discussion_r1876795494 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -126,19 +125,24 @@ public class SearchHandler extends RequestHandlerBase private PluginI

Re: [I] metadata.annotations: Too long: must have at most 262144 bytes [solr-operator]

2024-12-09 Thread via GitHub
HoustonPutman closed issue #732: metadata.annotations: Too long: must have at most 262144 bytes URL: https://github.com/apache/solr-operator/issues/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] metadata.annotations: Too long: must have at most 262144 bytes [solr-operator]

2024-12-09 Thread via GitHub
HoustonPutman commented on issue #732: URL: https://github.com/apache/solr-operator/issues/732#issuecomment-2529644607 Please refer to the answer here: https://github.com/apache/solr-operator/issues/502#issuecomment-1339758128 -- This is an automated message from the Apache Git Service. T

Re: [I] metadata.annotations: Too long: must have at most 262144 bytes [solr-operator]

2024-12-09 Thread via GitHub
HoustonPutman closed issue #732: metadata.annotations: Too long: must have at most 262144 bytes URL: https://github.com/apache/solr-operator/issues/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[I] metadata.annotations: Too long: must have at most 262144 bytes [solr-operator]

2024-12-09 Thread via GitHub
andrewrothstein opened a new issue, #732: URL: https://github.com/apache/solr-operator/issues/732 kubectl apply -f "https://solr.apache.org/operator/downloads/crds/v0.8.1/a\ ll-with-dependencies.yaml"

[jira] [Updated] (SOLR-17588) javabin must support primitive arrays

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17588: -- Labels: pull-request-available (was: ) > javabin must support primitive arrays > -

[jira] [Created] (SOLR-17588) javabin must support primitive arrays

2024-12-09 Thread Noble Paul (Jira)
Noble Paul created SOLR-17588: - Summary: javabin must support primitive arrays Key: SOLR-17588 URL: https://issues.apache.org/jira/browse/SOLR-17588 Project: Solr Issue Type: Improvement Se

Re: [PR] upgrade-log4j2-2.24.2 [solr]

2024-12-09 Thread via GitHub
janhoy commented on PR #2895: URL: https://github.com/apache/solr/pull/2895#issuecomment-2530705029 I have no preference when license is ambiguous. Guess whatever is in the download tar for that version is safe. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-12-09 Thread via GitHub
iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2530557275 [c3c2f1c](https://github.com/apache/solr/pull/2876/commits/c3c2f1c11ef40a34484a4d322be56f4384857db6) removed hadoop-auth [f7d900b](https://github.com/apache/solr/pull/2876/commits/f7d9