epugh commented on code in PR #2452:
URL: https://github.com/apache/solr/pull/2452#discussion_r1876714632
##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -126,19 +125,24 @@ public class SearchHandler extends RequestHandlerBase
private PluginInfo shfInfo;
private SolrCore core;
+ /**
+ * The default set of components that every handler gets. You can change
this by defining the
+ * specific components for a handler. It puts the {@link QueryComponent}
first as subsequent
+ * components assume that the QueryComponent ran and populated the document
list.
+ *
+ * @return A list of component names.
+ */
protected List<String> getDefaultComponents() {
- ArrayList<String> names = new ArrayList<>(9);
- names.add(QueryComponent.COMPONENT_NAME);
- names.add(FacetComponent.COMPONENT_NAME);
- names.add(FacetModule.COMPONENT_NAME);
- names.add(MoreLikeThisComponent.COMPONENT_NAME);
- names.add(HighlightComponent.COMPONENT_NAME);
- names.add(StatsComponent.COMPONENT_NAME);
- names.add(DebugComponent.COMPONENT_NAME);
- names.add(ExpandComponent.COMPONENT_NAME);
- names.add(TermsComponent.COMPONENT_NAME);
-
- return names;
+ List<String> l = new
ArrayList<String>(SearchComponent.STANDARD_COMPONENTS.keySet());
Review Comment:
humm... Maybe I just back out this optimization...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
