jdyer1 opened a new pull request, #2899:
URL: https://github.com/apache/solr/pull/2899
With this PR makes `LBHttp2SolrClient` maintains an instance of
`HttpSolrClientBuilderBase` per "Base Url". This makes the semantics of
`LBHttp2SolrClient#getClient` consistent with that of the older
`LBHttpSolrClient`.
Behavior changes:
- `LBHttp2SolrClient` generates a Http Solr Client per base url
- (1) at constructon
- (2) whenever a previously-unseen base url is encountered
- NOTE: The Map holding the clients may grow unbounded; there is no
cleanup short of callng `close()`.
- `LBHttp2SolrClient` mutates the `baseSolrUrl` variable of the
caller-supplied instance of `HttpSolrClientBuilderBase` whenever it creates a
new Http Solr Client.
- Both `LBHttp2SolrClient` and `CloudHttp2SolrClient` always own the
internal/delegate clients. They are now always closed by us on `close()`.
The following class definitions are changed in the SolrJ public API:
- `LBHttp2SolrClient`
- from: `LBHttp2SolrClient<C extends HttpSolrClientBase> extends
LBSolrClient`
- to: `LBHttp2SolrClient<B extends HttpSolrClientBuilderBase<?, ?>>
extends LBSolrClient`
- `LBHttp2SolrClient.Builder`
- from: `Builder<C extends HttpSolrClientBase>`
- to: `Builder<B extends HttpSolrClientBuilderBase<?, ?>>`
- All methods on `LBHttp2SolrClient.Builder` return a `Builder<B>` instead
of a `Builder<C>`
The following are removed from the SolrJ public API:
- method `CloudHttp2SolrClient.Builder#withHttpClient`
- constructor `LBHttp2SolrClient.Builder(C solrClient, Endpoint...
endpoints)`
- replaced with: `public Builder(B solrClientBuilder, Endpoint...
endpoints)`
- method `HttpJdkSolrClient#requestWithBaseUrl` (main only, never released)
The following were not removed, but perhaps should be considered to be
marked "internal" or "Experimental"
- method `Http2SolrClient#requestWithBaseUrl` (main only, never released)
- interface `SolrClientFunction` (main only, never released)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
