Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1861295703 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -660,8 +660,8 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, Sol

[PR] Fix claim name in JWT Authentication Plugin docs [solr]

2024-11-27 Thread via GitHub
jasminjohal-els opened a new pull request, #2890: URL: https://github.com/apache/solr/pull/2890 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on PR #2886: URL: https://github.com/apache/solr/pull/2886#issuecomment-2505386291 Good. Only one thing missing now. Add a CHANGES.txt line under 9.8.0 Bugfix section, with your own and my name. I’ll then merge and backport. -- This is an automated message from the Apache

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
azagniotov commented on PR #2886: URL: https://github.com/apache/solr/pull/2886#issuecomment-2505404727 > [janhoy](/janhoy) @janhoy done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-27 Thread via GitHub
malliaridis commented on code in PR #2881: URL: https://github.com/apache/solr/pull/2881#discussion_r186076 ## solr/core/src/java/org/apache/solr/search/FunctionQParser.java: ## @@ -398,7 +398,7 @@ protected ValueSource parseValueSource(int flags) throws SyntaxError {

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-27 Thread via GitHub
malliaridis commented on code in PR #2881: URL: https://github.com/apache/solr/pull/2881#discussion_r1860806598 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java: ## @@ -38,14 +36,24 @@ * @lucene.experimental */ public abstract class DocRouter { - public s

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
azagniotov commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860812062 ## solr/modules/langid/src/java/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessor.java: ## @@ -111,19 +111,20 @@ private void initParams(SolrParams par

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
dsmiley commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1861223613 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -660,8 +660,8 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, So

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860712358 ## solr/modules/langid/src/java/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessor.java: ## @@ -111,19 +111,20 @@ private void initParams(SolrParams params)

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-27 Thread via GitHub
malliaridis commented on code in PR #2881: URL: https://github.com/apache/solr/pull/2881#discussion_r1860733744 ## solr/solrj/src/java/org/apache/solr/common/MapWriters.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [I] Configuration of Solr MultiAuthplugin with JWT and basic auth gives the error of PKI authentication on creating cores. [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #719: URL: https://github.com/apache/solr-operator/issues/719#issuecomment-2504105636 Knowledge sharing, because documentation does not disclose this --- [source code](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/secur

Re: [I] Uninstalling solr helm chart without uninstalling Zookeeper [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #665: URL: https://github.com/apache/solr-operator/issues/665#issuecomment-2504303062 My plan(not-tested): 1. Release SolrCloud and ZookeeperCluster with helm annotation that will prevent deletion during uninstall of the chart. [docs](https://helm.sh/

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
dsmiley commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1861203428 ## solr/CHANGES.txt: ## @@ -36,7 +36,8 @@ Improvements Optimizations - -(No changes) +* SOLR-17568: The CLI bin/solr export tool now contacts the a

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
dsmiley commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1861206865 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -60,6 +60,11 @@ Users who previously relied on collection-specific URLs to avoid i

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-27 Thread via GitHub
malliaridis commented on code in PR #2881: URL: https://github.com/apache/solr/pull/2881#discussion_r1860801651 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -1128,9 +1131,9 @@ protected SolrCore( initIndex(prev != null, reload); initWriters();

Re: [I] Solrcloud pods not starting with custom security.json [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #594: URL: https://github.com/apache/solr-operator/issues/594#issuecomment-2504331120 @liseli Do you fully re-create the cluster or just re-deploying. I would suggest looking into: ![image](https://github.com/user-attachments/assets/b145c2af-424

Re: [I] Configuration of Solr MultiAuthplugin with JWT and basic auth gives the error of PKI authentication on creating cores. [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #719: URL: https://github.com/apache/solr-operator/issues/719#issuecomment-2504534792 Anyone looking for `SolrPrometheusExporter` 9.6 or older and having problems with Basic Auth and `"blockUnknown": true` upgrade exporter to 9.7 and change SolrPrometheu

Re: [I] Configuration of Solr MultiAuthplugin with JWT and basic auth gives the error of PKI authentication on creating cores. [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #719: URL: https://github.com/apache/solr-operator/issues/719#issuecomment-2504547314 @janhoy @HoustonPutman forgot to ping you. Hope this will help :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on PR #2886: URL: https://github.com/apache/solr/pull/2886#issuecomment-2503984122 > glad to see we are tackling fixing a bug. In 10x we should move forward and delete the langid.whitelist. For sure. I expect there to be lots of such cleanup commits on the main b

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
epugh commented on PR #2886: URL: https://github.com/apache/solr/pull/2886#issuecomment-2503966827 glad to see we are tackling fixing a bug. In 10x we should move forward and delete the langid.whitelist. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-17352: CLI - Remove unsupported options for auth command [solr]

2024-11-27 Thread via GitHub
malliaridis merged PR #2858: URL: https://github.com/apache/solr/pull/2858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[PR] SOLR-17352: Backport removal of deprecated options for auth command (#2858) [solr]

2024-11-27 Thread via GitHub
malliaridis opened a new pull request, #2889: URL: https://github.com/apache/solr/pull/2889 https://issues.apache.org/jira/browse/SOLR-17352 # Description This PR backports the changes from #2858. # Solution Additionally to the changes from #2858 this also updates

Re: [I] Issue with basic auth [solr-operator]

2024-11-27 Thread via GitHub
VitalijusDBentley commented on issue #672: URL: https://github.com/apache/solr-operator/issues/672#issuecomment-2504266409 Also possible solution is to release with `replicas: 1` and after it is set-up change to desired replica count. Also @HoustonPutman maybe solr-operator could migrate fr

Re: [PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

2024-11-27 Thread via GitHub
gus-asf commented on code in PR #2887: URL: https://github.com/apache/solr/pull/2887#discussion_r1861332477 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -211,7 +205,7 @@ public static class IndexFetchResult { new IndexFetchResult("Local index c

Re: [PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

2024-11-27 Thread via GitHub
gus-asf commented on PR #2887: URL: https://github.com/apache/solr/pull/2887#issuecomment-2504958346 I'm confused. There seems to be a lot more in this than just touching up terminology to match the Leader/Follower? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
dsmiley commented on PR #2885: URL: https://github.com/apache/solr/pull/2885#issuecomment-2504980203 Thanks for feedback everyone. I'll merge in a day or two. Reminder: this is 10.0 only. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] SolrClientCache switch to Http2SolrClient [solr]

2024-11-27 Thread via GitHub
dsmiley commented on code in PR #2764: URL: https://github.com/apache/solr/pull/2764#discussion_r1802088278 ## solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java: ## @@ -533,11 +516,31 @@ List getStoredSampleDocs(final String configSet) throw

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860286943 ## solr/modules/langid/src/test/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessorFactoryTestCase.java: ## @@ -464,6 +466,101 @@ public void testMapIndividu

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860287923 ## solr/modules/langid/src/test/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessorFactoryTestCase.java: ## @@ -464,6 +466,101 @@ public void testMapIndividu

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860286943 ## solr/modules/langid/src/test/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessorFactoryTestCase.java: ## @@ -464,6 +466,101 @@ public void testMapIndividu

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
epugh commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1860494959 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## Review Comment: This is some nice simplification! ## solr/solr-ref-guide/modules/upgra

[jira] [Created] (SOLR-17576) Remove deprecated master/slave configuration support from Replication

2024-11-27 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17576: Summary: Remove deprecated master/slave configuration support from Replication Key: SOLR-17576 URL: https://issues.apache.org/jira/browse/SOLR-17576 Project: Solr I

[PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

2024-11-27 Thread via GitHub
epugh opened a new pull request, #2887: URL: https://github.com/apache/solr/pull/2887 https://issues.apache.org/jira/browse/SOLR-17576 # Description Remove deprecated terms. # Solution Deletes # Tests Existing tests # Checklist Please re

[jira] [Updated] (SOLR-17576) Remove deprecated master/slave configuration support from Replication

2024-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17576: -- Labels: pull-request-available (was: ) > Remove deprecated master/slave configuration support

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1860578922 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -660,8 +660,8 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, Sol

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-27 Thread via GitHub
janhoy commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1860578922 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -660,8 +660,8 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, Sol

[jira] [Created] (SOLR-17577) solr.indexfetcher.sotimeout property in tests non used

2024-11-27 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17577: Summary: solr.indexfetcher.sotimeout property in tests non used Key: SOLR-17577 URL: https://issues.apache.org/jira/browse/SOLR-17577 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-17577) solr.indexfetcher.sotimeout property in tests non used

2024-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17577: -- Labels: pull-request-available (was: ) > solr.indexfetcher.sotimeout property in tests non use

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-27 Thread via GitHub
malliaridis commented on code in PR #2881: URL: https://github.com/apache/solr/pull/2881#discussion_r1860657766 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java: ## @@ -38,14 +36,24 @@ * @lucene.experimental */ public abstract class DocRouter { - public s

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-27 Thread via GitHub
azagniotov commented on code in PR #2886: URL: https://github.com/apache/solr/pull/2886#discussion_r1860642411 ## solr/modules/langid/src/java/org/apache/solr/update/processor/LanguageIdentifierUpdateProcessor.java: ## @@ -111,18 +111,21 @@ private void initParams(SolrParams par

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-11-27 Thread via GitHub
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2503905736 A question for the smarter folks that me. Should the classes `UBIQuery` and `UBIQueryStream` be added to the `UBIComponent.java`? UBIQuery is just a pojo...And UBIQueryStream wires the

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-11-27 Thread via GitHub
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2503920206 Just stubbed my toe on the "Distributed processing is harder than single core processing"! With a two node set up, I discovered that I am logging to a SINGLE `userfiles/ubi_queries.jsonl` fi