malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860657766
##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java:
##########
@@ -38,14 +36,24 @@
* @lucene.experimental
*/
public abstract class DocRouter {
- public static final String DEFAULT_NAME = CompositeIdRouter.NAME;
- public static final DocRouter DEFAULT;
+ /**
+ * @deprecated Use {@link DocRouters#DEFAULT_NAME} instead.
+ */
+ @Deprecated(since = "9.8", forRemoval = true)
+ public static final String DEFAULT_NAME = DocRouters.DEFAULT_NAME;
Review Comment:
I considered this an option, but thought that it would be better to keep
`DEFAULT` (DocRouter) and `DEFAULT_NAME` (String) in the same class. So moving
`DEFAULT` out would also affect `DEFAULT_NAME`.
Since I also moved out the `getDocRouter(routerName)` method, we still have
a few more references to the new DocRouters. But perhaps that is also not
necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
