gus-asf commented on code in PR #2887:
URL: https://github.com/apache/solr/pull/2887#discussion_r1861332477
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -211,7 +205,7 @@ public static class IndexFetchResult {
new IndexFetchResult("Local index commit is already in sync with
peer", true, null);
public static final IndexFetchResult INDEX_FETCH_FAILURE =
- new IndexFetchResult("Fetching lastest index is failed", false, null);
+ new IndexFetchResult("Fetching latest index is failed", false, null);
Review Comment:
"Fetching the latest index failed" ?
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -1611,23 +1554,6 @@ private Collection<Map<String, Object>>
getModifiedConfFiles(
return nameVsFile.isEmpty() ? Collections.emptyList() :
nameVsFile.values();
}
- /**
Review Comment:
How is this related?
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1637,8 +1570,6 @@ private Long readIntervalNs(String interval) {
public static final String ALIAS = "alias";
- public static final String CONF_CHECKSUM = "confchecksum";
Review Comment:
unrelated?
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1577,28 +1522,16 @@ private Long readIntervalNs(String interval) {
public static final String LEADER_URL = "leaderUrl";
- /**
- * @deprecated Only used for backwards compatibility. Use {@link #LEADER_URL}
- */
- @Deprecated public static final String LEGACY_LEADER_URL = "masterUrl";
-
public static final String FETCH_FROM_LEADER = "fetchFromLeader";
// in case of TLOG replica, if leaderVersion = zero, don't do commit
- // otherwise updates from current tlog won't copied over properly to the new
tlog, leading to data
+ // otherwise updates from current tlog won't be copied over properly to the
new tlog, leading to
+ // data
Review Comment:
tidy not really helping here... :)
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -1526,49 +1512,6 @@ private void copyTmpConfFiles2Conf(Path tmpconfDir) {
}
}
- /**
- * The tlog files are moved from the tmp dir to the tlog dir as an atomic
filesystem operation. A
- * backup of the old directory is maintained. If the directory move fails,
it will try to revert
- * back the original tlog directory.
- */
- private boolean copyTmpTlogFiles2Tlog(File tmpTlogDir) {
Review Comment:
how is this related to this ticket?
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -848,14 +802,6 @@ private Date getNextScheduledExecTime() {
return nextTime;
}
- int getTimesReplicatedSinceStartup() {
Review Comment:
how is this change related to the ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
