Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-11-16 Thread via GitHub
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2480693921 Making progressI've added some tasks to do, and then I think I'm going to flip it from Draft to Ready for Review and email the community. I'd like to demo it at a upcoming community m

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-16 Thread via GitHub
dsmiley commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1845101285 ## settings.gradle: ## @@ -48,6 +48,7 @@ include "solr:modules:hadoop-auth" include "solr:modules:hdfs" include "solr:modules:jwt-auth" include "solr:modules:langid" +i

[jira] [Resolved] (SOLR-9615) NamedList:asMap method is no converted NamedList in List

2024-11-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-9615. Resolution: Won't Fix asMap without args is inherited via SimpleMap and that's going away in Solr 10

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-16 Thread via GitHub
dsmiley commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1839376359 ## solr/core/src/java/org/apache/solr/util/DataConfigNode.java: ## @@ -54,31 +53,17 @@ public DataConfigNode(ConfigNode root) { e.setValue(List.copyOf(e.getValue(

[jira] [Updated] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign

2024-11-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17566: Labels: newdev (was: ) > Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign >

[jira] [Created] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign

2024-11-16 Thread David Smiley (Jira)
David Smiley created SOLR-17566: --- Summary: Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign Key: SOLR-17566 URL: https://issues.apache.org/jira/browse/SOLR-17566 Project: Solr Issue Type:

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-16 Thread via GitHub
dsmiley commented on PR #2856: URL: https://github.com/apache/solr/pull/2856#issuecomment-2480968084 If I should break this up, or file another JIRA, let me know. The SimpleMap part feels kind of separate, especially since it impacts the ubiquitous NamedList. -- This is an automated mes

[jira] [Updated] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign

2024-11-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17566: Affects Version/s: 8.8 > Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign > -

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-11-16 Thread via GitHub
malliaridis commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480816742 > i expected the link to the /compose to work from old admin, but didn't see it... The old UI only links to the new UI if you go to "Java Properties". The idea is to have a button

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-16 Thread via GitHub
malliaridis commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2480818067 With `hadoop-auth` gone, we have only one more blocker (s3) before migrating to jetty12. :D -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Solr 12276 angularjs to angular migration [solr]

2024-11-16 Thread via GitHub
malliaridis commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2480897920 > > The current state of the PR seems to not integrate the Angular project into the current "deployment", resulting in CORS issues when running with `npm start`. Do you have any instruct

[jira] [Updated] (SOLR-16427) Evaluate and fix errorprone rules

2024-11-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16427: -- Labels: pull-request-available (was: ) > Evaluate and fix errorprone rules > -

[PR] SOLR-16427: Enable error-prone PatternMatchingInstanceof rule [solr]

2024-11-16 Thread via GitHub
malliaridis opened a new pull request, #2867: URL: https://github.com/apache/solr/pull/2867 https://issues.apache.org/jira/browse/SOLR-16427 # Description With the new errorprone rules and starting from 16+ we can use pattern-matching for `instanceof`. # Solution

Re: [PR] Solr 12276 angularjs to angular migration [solr]

2024-11-16 Thread via GitHub
malliaridis commented on code in PR #2818: URL: https://github.com/apache/solr/pull/2818#discussion_r1845274026 ## solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] forbidden-apis: Don't need java.solr.txt file [solr]

2024-11-16 Thread via GitHub
dsmiley commented on code in PR #2866: URL: https://github.com/apache/solr/pull/2866#discussion_r1845189541 ## gradle/validation/forbidden-apis.gradle: ## @@ -99,7 +99,6 @@ allprojects { prj -> "**.SuppressForbidden" ] - doFirst dynamicSignatures.curry(c

[jira] [Commented] (SOLR-17490) Don't require perl to run gradlew dev task

2024-11-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898872#comment-17898872 ] ASF subversion and git services commented on SOLR-17490: Commit 5

Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]

2024-11-16 Thread via GitHub
epugh commented on PR #2753: URL: https://github.com/apache/solr/pull/2753#issuecomment-2480554027 No Changes.txt needed, this is not user facing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]

2024-11-16 Thread via GitHub
epugh merged PR #2753: URL: https://github.com/apache/solr/pull/2753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17490) Don't require perl to run gradlew dev task

2024-11-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898874#comment-17898874 ] ASF subversion and git services commented on SOLR-17490: Commit c

[jira] [Resolved] (SOLR-17490) Don't require perl to run gradlew dev task

2024-11-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17490. -- Fix Version/s: 9.8 Resolution: Fixed > Don't require perl to run gradlew dev task >

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-11-16 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1844907292 ## solr/licenses/raleway-OFL.txt: ## @@ -0,0 +1,93 @@ +Copyright 2010 The Raleway Project Authors (impall...@gmail.com), with Reserved Font Name "Raleway". + +This Fo

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-11-16 Thread via GitHub
epugh commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480589176 Checking code out... I got a ``` task :solr:compose-ui:compileProductionExecutableKotlinWasmJs FAILED e: java.lang.OutOfMemoryError: GC overhead limit exceeded at org.jetb

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-11-16 Thread via GitHub
epugh commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480592397 i expected the link to the `/compose` to work from old admin, but didn't see it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-16 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2480560616 @malliaridis any chance you could look at this with me? I believe the `versions.lock` and `version.props` are actually the same because I copied from `main` over into my branch the files.

Re: [PR] chore(deps): update org.apache.tika:* to v3 (major) - autoclosed [solr]

2024-11-16 Thread via GitHub
solrbot closed pull request #2583: chore(deps): update org.apache.tika:* to v3 (major) - autoclosed URL: https://github.com/apache/solr/pull/2583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the