dsmiley commented on code in PR #2866:
URL: https://github.com/apache/solr/pull/2866#discussion_r1845189541
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -99,7 +99,6 @@ allprojects { prj ->
"**.SuppressForbidden"
]
- doFirst dynamicSignatures.curry(configurations.toolsCompileClasspath,
"lucene")
Review Comment:
I don't quite understand this line but the reference to "lucene" probably
matches nothing.
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
- // Configure solr-specific rules.
Review Comment:
the whole configuration overall is for Solr
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
- // Configure solr-specific rules.
- if (prj.path.startsWith(":solr")) {
- forbiddenApisMain {
- doFirst dynamicSignatures.curry(configurations.compileClasspath,
"solr")
- signaturesFiles += files(file("${resources}/java.solr.txt"))
- }
-
- forbiddenApisTest {
- doFirst dynamicSignatures.curry(configurations.testCompileClasspath,
"solr")
Review Comment:
Maybe I should have kept this line? I'm not sure what it accomplishes.
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
- // Configure solr-specific rules.
- if (prj.path.startsWith(":solr")) {
- forbiddenApisMain {
- doFirst dynamicSignatures.curry(configurations.compileClasspath,
"solr")
Review Comment:
Maybe I should have kept this line? I'm not sure what it accomplishes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
