epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824218403
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1823899972
##
solr/modules/llm/src/test-files/solr/collection1/conf/stopwords.txt:
##
Review Comment:
not at all, I'll remove it with the next commit!
##
malliaridis commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824945975
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) th
Houston Putman created SOLR-17537:
-
Summary: Let Curator handle state compression in ZooKeeper
Key: SOLR-17537
URL: https://issues.apache.org/jira/browse/SOLR-17537
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-17364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17364.
Resolution: Information Provided
> Vulnerabilities in Solr 8.11.3
> ---
Houston Putman created SOLR-17536:
-
Summary: Migrate SolrZkClient customizations to be Curator plugins
Key: SOLR-17536
URL: https://issues.apache.org/jira/browse/SOLR-17536
Project: Solr
Issu
David Smiley created SOLR-17538:
---
Summary: CloudHttp2SolrClient needs a custom ClusterStateProvider
option
Key: SOLR-17538
URL: https://issues.apache.org/jira/browse/SOLR-17538
Project: Solr
I
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824234733
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824808865
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17535:
Description: To avoid creating intermediary maps for ClusterState
consumers, and to limit the direc
gerlowskija opened a new pull request, #2827:
URL: https://github.com/apache/solr/pull/2827
# Description
We've recently tweaked the Jenkins jobs that we run, in order to get as many
'test' runs as possible out of our hardware. This involved changing some job
names and details in Je
jdyer1 commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2450126360
I opened a better PR #2828 with a generic client. Please review/compare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450147305
> @janhoy in commit
[2f3c0ef](https://github.com/apache/solr/commit/2f3c0ef959b6a1f921217ef30da5347ec17a5b5f)
I removed the passing of the `-j` (Jetty options) into the RunExampleTool
because
dsmiley commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824671510
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -610,7 +611,7 @@ private void checkAZombieServer(EndpointWrapper
zombieServer) {
iamsanjay merged PR #2821:
URL: https://github.com/apache/solr/pull/2821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824809265
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450344779
I **think** I am done and ready for more review. I clearly was NOT done
when I thought I was the first time!!!
I love that while we added 176 lines we remove 1092
--
This is
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450346488
I also anticipate that post this merge and some of the other inflight PR's,
that we will want to reach out and ask the community for another round of
testing on LInux and windows ;-)
--
Thi
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450138855
@janhoy in commit 2f3c0ef959b6a1f921217ef30da5347ec17a5b5f I removed the
passing of the `-j` (Jetty options) into the RunExampleTool because it was an
option that was ignored. You added the
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824622966
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449846136
I am leaving `SolrCLI#getOptionWithDeprecatedAndDefault` but adding some
docs about what it's for, since I suspect we will have another deprecation soon!
--
This is an automated message from
HoustonPutman commented on PR #2824:
URL: https://github.com/apache/solr/pull/2824#issuecomment-2450294605
It is not advertised at all, I believe it is just used for testing. But I
think default in the name is fine. `Solr.cloud.prs=true`, doesn't really tell
me what I'm setting to true. May
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894646#comment-17894646
]
ASF subversion and git services commented on SOLR-17448:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894647#comment-17894647
]
ASF subversion and git services commented on SOLR-17497:
Commit 9
dsmiley commented on PR #2811:
URL: https://github.com/apache/solr/pull/2811#issuecomment-2450153694
I know it's out of scope... sort of... but @iamsanjay recently updated
SolrClientNodeStateProvider.invoke to not call setBasePath but the result is
more lines of code / complexity than neede
gerlowskija commented on PR #2811:
URL: https://github.com/apache/solr/pull/2811#issuecomment-2450109394
Alright - either adopted or responded to your comments @dsmiley . Take a
look when you get a few!
--
This is an automated message from the Apache Git Service.
To respond to the messag
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824611991
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,14 +480,35 @@ private static boolean isTimeExceeded(long
timeAllowedNano, long
jdyer1 opened a new pull request, #2828:
URL: https://github.com/apache/solr/pull/2828
Similar to #2805, this is a minimal PR to add Load Balancing functionality
for `HttpJdkSolrClient`. Included is test refactoring, adding the *JdkClient as
a random choice for the integration test.
[
https://issues.apache.org/jira/browse/SOLR-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16821:
Assignee: Eric Pugh
> Make all boolean options not take a true/false but just the -option be enoug
[
https://issues.apache.org/jira/browse/SOLR-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894619#comment-17894619
]
Eric Pugh commented on SOLR-16821:
--
Nope. Turns out we have some places. [~mall
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894640#comment-17894640
]
ASF subversion and git services commented on SOLR-17448:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894641#comment-17894641
]
ASF subversion and git services commented on SOLR-17497:
Commit c
iamsanjay merged PR #2800:
URL: https://github.com/apache/solr/pull/2800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824240009
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824239234
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824242674
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
epugh commented on PR #2819:
URL: https://github.com/apache/solr/pull/2819#issuecomment-2449795520
If this is important to a 9.7.1, then yes. I think what we normally do is
communicate in the release thread on dev@ about these things. Otherwise, being
on branch_9x is fine because it'll be
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449861488
for "AuthTool uses flags with Boolean arguments, should be deprecated and
changed before 10" we should make another ticket.
--
This is an automated message from the Apache Git Service.
To re
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824243229
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
gerlowskija commented on PR #1993:
URL: https://github.com/apache/solr/pull/1993#issuecomment-2449994798
Superceded by #2788; closing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gerlowskija closed pull request #1993: SOLR-16390: Tweak clusterprop APIs to be
more REST-ful
URL: https://github.com/apache/solr/pull/1993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
janhoy commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824575199
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws
[
https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894591#comment-17894591
]
ASF subversion and git services commented on SOLR-11191:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17535:
Description:
To avoid creating intermediary maps for ClusterState consumers, and to limit
the dire
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449839719
I hope in the future `solr.cmd` doesn't have helper methods like
`parse_config_args`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
janhoy commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2449966915
> Users generally don't refer to the LB client nor ClusterStateProvider; we
shouldn't constrain ourselves, especially in a major release.
Agree, wouldn't care too much about breaking th
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824584360
##
solr/core/src/test/org/apache/solr/handler/TestUserManagedReplicationWithAuth.java:
##
@@ -227,26 +228,26 @@ private QueryResponse queryWithBasicAuth(SolrClient
cl
gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824597751
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##
@@ -358,28 +358,29 @@ private void addRunner() {
@Override
publ
iamsanjay opened a new pull request, #2832:
URL: https://github.com/apache/solr/pull/2832
https://issues.apache.org/jira/browse/SOLR-17538
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https
[
https://issues.apache.org/jira/browse/SOLR-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894692#comment-17894692
]
Eric Pugh commented on SOLR-17537:
--
I really really really like this idea. I ran into t
solrbot opened a new pull request, #2829:
URL: https://github.com/apache/solr/pull/2829
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| org.apache.hadoop:hadoop-minikdc | test | patch | `3.4.0` -> `3.4.1` |
| org.apache.hadoop:h
solrbot opened a new pull request, #2830:
URL: https://github.com/apache/solr/pull/2830
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.bouncycastle:bcpkix-jdk18on](https://www.bouncycastle.org/java.html)
([source](https://re
dsmiley commented on PR #2824:
URL: https://github.com/apache/solr/pull/2824#issuecomment-2450823568
Even if today we only use it for testing (because only we know of its secret
existence), isn't the same mechanism appropriate for a cluster? It needn't be
the *only* way to set it, of cours
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824235207
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
solrbot opened a new pull request, #2831:
URL: https://github.com/apache/solr/pull/2831
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[org.mockito:mockito-subclass](https://redirect.github.com/mockito/mockito) |
test | minor |
iamsanjay commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2451302759
Possibility of relating to this one.
Build scan data https://ge.apache.org/s/63ya5yavjnh5o
> Error from server at http://127.0.0.1:43991/solr: Cannot talk to ZooKeeper
- Updates a
dsmiley commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1825196815
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -173,8 +173,8 @@ public NamedList request(SolrRequest
solrRequest, String collectio
57 matches
Mail list logo
